Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3318428rwa; Tue, 23 Aug 2022 02:43:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR72KzD+oszvM/gj6wEqBgo+EpeF2KgCPy3zScoZV8xMG1xVMUEHO0InbUzRoxYoF09cNYK2 X-Received: by 2002:a17:90b:3b46:b0:1fb:5993:f893 with SMTP id ot6-20020a17090b3b4600b001fb5993f893mr2496118pjb.229.1661247812672; Tue, 23 Aug 2022 02:43:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661247812; cv=none; d=google.com; s=arc-20160816; b=AEIPiOLwEyAFOmtZms9e2kVg8AiVKUa8FdMwMtD+RM4Bkb9v7bIhECbJq+IPLnh9r+ 19z1QuYKm0k1MfpndpLgX4QvvPTqxLB1+6+Yd16OxHsGR3u5Pm7TYYHwNc+wbXIvJiZk 0PGcdAFsjjoexkqdFu66MsQkSu7B+s2eXYSYDc2IKDlnju52bjpo6JY7OGXjU6BcHOOM Sf86c69+fhjY7LKDa2bjI7zcl+VRFnYRr4LRpaCZc+JSDmi3wWVcmxAoztC5zUSzKczn zxS+jCOPc8lTPg7MvdpFf95Q6bQU1ZVDnuAe6Fl/FoQ8DdRjEAb07sCNRrd3KWT/0pkm MSWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UMQqgnZVeiH2ciSH9YzRFcOUfXeC9gQHIkwDrgs2CSM=; b=W3LbKeUN0e2EVb0yogoTGd0Y/hI3Dj+B2HbKccHyljF9s8gRKYjhgrbqj6WL+NwiR2 ha7kTRjACqN56A8c3qq2CWgSugJci9qlfW/SyzJ5xXc1FMWI5DaiBsTbslW3qI0GOEKh f8+ah73zocNwBnroyGAh2WCUSF2Mva64Zz6/hq7PtKIB1KrUNPyQz1h5cc5l/+q3gDrR UbJc3CANGjIywRfRgn7NE1pxK09j3mNEW0j9jBbTOeuAuRU5DbVJtntL9iEAPNkpqM26 D5iI0nuowjJvKZDlLXNauBnH485YWvFaw/v2my70ZGAohUEHlPRDy06ubBo+KwZTzDKn JOeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ImR31oXT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s35-20020a634523000000b004161e72a055si9941406pga.310.2022.08.23.02.43.22; Tue, 23 Aug 2022 02:43:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ImR31oXT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243944AbiHWJTV (ORCPT + 99 others); Tue, 23 Aug 2022 05:19:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348936AbiHWJRR (ORCPT ); Tue, 23 Aug 2022 05:17:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFC92B28; Tue, 23 Aug 2022 01:33:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 891186123D; Tue, 23 Aug 2022 08:32:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A746C433D6; Tue, 23 Aug 2022 08:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661243570; bh=j6NV3NHZXdnVzeVJMsRHbm/l1Gnb2Ly24LwoKMCdh4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ImR31oXTAZ6yjQ/FnHzfRgbA+BRdgFgIzSMFRtC+Y4uONA18IFSVWKC/8kE4/71KA G1/dF7rC5kXU/F8hdVyB1yt6G3rT6aX1974uaSYC72lcRKtYFrAHkOi0PKuNrGxoDt HXvsRwKk8N2trTjK1rEQ3AnLS/yCNj7q7nhdMrQs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guenter Roeck , Steven Rostedt , Andrew Morton , Sasha Levin Subject: [PATCH 5.19 318/365] lib/list_debug.c: Detect uninitialized lists Date: Tue, 23 Aug 2022 10:03:39 +0200 Message-Id: <20220823080131.483274512@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220823080118.128342613@linuxfoundation.org> References: <20220823080118.128342613@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck [ Upstream commit 0cc011c576aaa4de505046f7a6c90933d7c749a9 ] In some circumstances, attempts are made to add entries to or to remove entries from an uninitialized list. A prime example is amdgpu_bo_vm_destroy(): It is indirectly called from ttm_bo_init_reserved() if that function fails, and tries to remove an entry from a list. However, that list is only initialized in amdgpu_bo_create_vm() after the call to ttm_bo_init_reserved() returned success. This results in crashes such as BUG: kernel NULL pointer dereference, address: 0000000000000000 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 1 PID: 1479 Comm: chrome Not tainted 5.10.110-15768-g29a72e65dae5 Hardware name: Google Grunt/Grunt, BIOS Google_Grunt.11031.149.0 07/15/2020 RIP: 0010:__list_del_entry_valid+0x26/0x7d ... Call Trace: amdgpu_bo_vm_destroy+0x48/0x8b ttm_bo_init_reserved+0x1d7/0x1e0 amdgpu_bo_create+0x212/0x476 ? amdgpu_bo_user_destroy+0x23/0x23 ? kmem_cache_alloc+0x60/0x271 amdgpu_bo_create_vm+0x40/0x7d amdgpu_vm_pt_create+0xe8/0x24b ... Check if the list's prev and next pointers are NULL to catch such problems. Link: https://lkml.kernel.org/r/20220531222951.92073-1-linux@roeck-us.net Signed-off-by: Guenter Roeck Cc: Steven Rostedt Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- lib/list_debug.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/list_debug.c b/lib/list_debug.c index 9daa3fb9d1cd..d98d43f80958 100644 --- a/lib/list_debug.c +++ b/lib/list_debug.c @@ -20,7 +20,11 @@ bool __list_add_valid(struct list_head *new, struct list_head *prev, struct list_head *next) { - if (CHECK_DATA_CORRUPTION(next->prev != prev, + if (CHECK_DATA_CORRUPTION(prev == NULL, + "list_add corruption. prev is NULL.\n") || + CHECK_DATA_CORRUPTION(next == NULL, + "list_add corruption. next is NULL.\n") || + CHECK_DATA_CORRUPTION(next->prev != prev, "list_add corruption. next->prev should be prev (%px), but was %px. (next=%px).\n", prev, next->prev, next) || CHECK_DATA_CORRUPTION(prev->next != next, @@ -42,7 +46,11 @@ bool __list_del_entry_valid(struct list_head *entry) prev = entry->prev; next = entry->next; - if (CHECK_DATA_CORRUPTION(next == LIST_POISON1, + if (CHECK_DATA_CORRUPTION(next == NULL, + "list_del corruption, %px->next is NULL\n", entry) || + CHECK_DATA_CORRUPTION(prev == NULL, + "list_del corruption, %px->prev is NULL\n", entry) || + CHECK_DATA_CORRUPTION(next == LIST_POISON1, "list_del corruption, %px->next is LIST_POISON1 (%px)\n", entry, LIST_POISON1) || CHECK_DATA_CORRUPTION(prev == LIST_POISON2, -- 2.35.1