Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3320046rwa; Tue, 23 Aug 2022 02:45:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR4HaAU98CvDWd2a1ckHmbjAedkmf7DXxIM/2yLe0LAzgwXyfM17BSCGu9dCS4wiFEhSYHoU X-Received: by 2002:a17:907:6890:b0:73d:a567:568c with SMTP id qy16-20020a170907689000b0073da567568cmr759178ejc.521.1661247959108; Tue, 23 Aug 2022 02:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661247959; cv=none; d=google.com; s=arc-20160816; b=0L4lwJDHDK9rd/U0UrjVkWBqfL0RrwkkasaenVFLL43sXA+AJhWGyFGJa2bB+hpvhG snVzVhQ0xZ1rRUsD/SSlMv2EBgkkUHNlbggom/0hqaPwb+k/Fnxs+Rxu4iux9Cp4i8GQ Xh1rKqxOwTm6Hves5BQZWSnyjBvlSnSHEYXg1yFSUMe/yPLyuA5O6NV8qvYY9h+Rk+rf PsfP/rk27/Wn4iDrmmTWc0UJldwOQpZHRNJ30vw9V/9ODWWxpkSBNmsLITpp55INjlzh xrtWpIw02u5BqXC9LXcuty92lQzqffsnsh9l5Gar3y3uMMWwbKnwRSRuL21kiJdO9m2a 7rfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=F+5yVrf2toWobmjjbMycRUMUYr1HibosAX8wZbYW6I8=; b=WFEwqbn616hZqWd1LaSH/lvU+Qnv0g1frEpVV7a+W8F7YE6LndlD9Mk554gY5L/CHe eQVWX6jrELpC9fuuunJOfMydiHA20nfuKOPEFeWyrEQ479Ye6dWXmqH6aDx7oMLUhjmk nscxOFcUXITSjVvXGo0B6cUvErf44TXJzvzlCQI84vEl24E0DQRfj9lsbJcArv3kiCmj VK+G74iH110hKjgumC70hpZ1HEusTLWiAwqPsltcB9k3Xl3GQg7YZbgwrmMZFbyvYQ3o 8Ll35rx2i+9rmIUw6ix3mt3/ZYZnOHOFcyb6+H7zTFPINHazGVL1TriwXqPA/fhW0KC2 o8Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ME5pga0x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr2-20020a170907720200b0072eece129bdsi11754089ejc.59.2022.08.23.02.45.33; Tue, 23 Aug 2022 02:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ME5pga0x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240347AbiHWJST (ORCPT + 99 others); Tue, 23 Aug 2022 05:18:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349551AbiHWJQF (ORCPT ); Tue, 23 Aug 2022 05:16:05 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B7FD86FFE for ; Tue, 23 Aug 2022 01:32:25 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id s1so15900800lfp.6 for ; Tue, 23 Aug 2022 01:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=F+5yVrf2toWobmjjbMycRUMUYr1HibosAX8wZbYW6I8=; b=ME5pga0xqukFaQ68m0vfi01ZcbRzB6yRE0fmlS7+txX0bQzWcwtEDRVyRioYOwi0MK 78InqOKpEzQjwwoKp2jLetMmVf+U5kGfjAGpCioYESzh0Nn7R6NnQEhEpy83phb2wUBE vONvAXl1ssbqNdhWgsw2pgINK15PKwGEugYDYXQ0DvtuYmJnc+kHLoqrcq/t9TBGW18o dZU7d/N5EaKR+aOL8epf9dLFNAFMKp9E+bD7gskVr4SPbXoi96eOAvH4hzX2GgWwnC3o g1IWqumSlGK5va3jXsEv35nL23bMbFlCDl0w5NvXP0nYtKGxRoJwWq/DNhDBDzGG9reA nMpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=F+5yVrf2toWobmjjbMycRUMUYr1HibosAX8wZbYW6I8=; b=aPo9R3yFQEiaqcAe8SmgjLj3RRd43Mapnwm/LvSkUA2YYV/vn58NhFiSxdjj9F/dDr K+4ya9GGM1r+jaJKRCTjdaMsQUJq2YvF6cqy1x0HcK7YZOIYmxBMmZzWeMPgijUaQzep lE2v6EqecMsNukTiWwKcrpQrWinwgA5O2t7l4SXKfc0Wt8dVhWub+j2xIUGgZ7sH9lXX ckS6m6CJxnr6nZx/iEOw1ckMTi8Kh4wOOZtbwE4tEur6+3WvbtIgUPdr7WULlQh/C4n9 rMZyUmljuAKdQEyeVK5B+tBaacnDAKKRDrvu9JLhPxoxD43bG+FARwFj2vN4P/n/d5au /ehw== X-Gm-Message-State: ACgBeo0guUa2vf9vATiXV1krsRDeY5dZ0qzdIU6kvWEue2TjkX30p4iN fgbvvgqfSNEFP47gPHrErZBDAg== X-Received: by 2002:a05:6512:3d08:b0:48b:123e:fcf3 with SMTP id d8-20020a0565123d0800b0048b123efcf3mr8057965lfv.418.1661243543099; Tue, 23 Aug 2022 01:32:23 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id v20-20020a05651203b400b0048a83ab2d32sm1193907lfp.0.2022.08.23.01.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 01:32:22 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 11:32:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH,2/2] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm. Content-Language: en-US To: xinlei.lee@mediatek.com, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <1661239875-19841-1-git-send-email-xinlei.lee@mediatek.com> <1661239875-19841-3-git-send-email-xinlei.lee@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <1661239875-19841-3-git-send-email-xinlei.lee@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/08/2022 10:31, xinlei.lee@mediatek.com wrote: > From: xinlei lee > > In the original mtk_disp_pwm_get_state() function, the result of reading > con0 & BIT(0) is enabled as disp_pwm. > In order to conform to the register table, we should use the disp_pwm > base address as the enabled judgment. > > Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()") > Signed-off-by: xinlei lee This is a fix so not really related with the change adding new device. Send them separately in the future. Best regards, Krzysztof