Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755226AbXFMEec (ORCPT ); Wed, 13 Jun 2007 00:34:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751079AbXFMEeY (ORCPT ); Wed, 13 Jun 2007 00:34:24 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:39049 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754AbXFMEeY (ORCPT ); Wed, 13 Jun 2007 00:34:24 -0400 Date: Wed, 13 Jun 2007 06:35:26 +0200 From: Sam Ravnborg To: Satyam Sharma Cc: Jan Beulich , Venkatesh Pallipadi , Andi Kleen , linux-kernel@vger.kernel.org, patches@x86-64.org Subject: Re: [PATCH] x86: fix improper .init-type section references Message-ID: <20070613043526.GA20088@uranus.ravnborg.org> References: <466E6BDF.76E4.0078.0@novell.com> <466EB12B.76E4.0078.0@novell.com> <466EC08A.76E4.0078.0@novell.com> <20070612180002.GC15329@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 22 > > Yup, we were only discussing possibility that modpost not complain > about .init -> .exit references that will never go oops (because the arch > guarantees that). And there are no good reasosns why the rules should be different for i386 and powerpc. This type of special casing is always bad. Think about it a little. Someone writes a generic driver and test it on i386 - OK. But for powerpc it result in a build failure. It would be so much better to warn about this situation early. We had this exact issue in loop.c recently - so it is not a made up example. [I recall it was ia64 that had a build failure but the example still holds ture] Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/