Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3329733rwa; Tue, 23 Aug 2022 02:59:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR75rVtzgltOfRuBWTwYJbV5VxdRynLz5hd/JtMN3PcIg3nOck5j6W/RGkUq0KVfdKiu7rgm X-Received: by 2002:a17:907:6890:b0:73d:70eb:d98b with SMTP id qy16-20020a170907689000b0073d70ebd98bmr8483106ejc.18.1661248788448; Tue, 23 Aug 2022 02:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661248788; cv=none; d=google.com; s=arc-20160816; b=BFpJizC4vAqOT/nrBpQW8Wqiq+H2KKIuDTrQY91aFT3v+s3t45RdQKW43eOAGe5KZD 45kVCI9VYZCmX8JsU35RknJkhrzaiZ3gq2YsldpEozqZ01q8jCi2eORaaSTDNAocbb9q 1uLNqx0KzLMghTw92KADF64DtMLBWFbn9mcnmObL5BjmkQhwFR2yg/fGV28EmwfZJ8d3 6aMCdOBqEO4FPXnoAsFrv54o5BQz77T9K/517+yvzJA9V0gNMr6acmKNGBrzeTMI+eiU mUAYxRnfU+DJr4K8toUwbzxiXEDmNmuUlVbrUIK4OwzXdiX8Bh/ChF6OBPYvoshT/7Lx h0FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WUVArxfYINO9Mxv2wNMqMq1VtEcu3GtC/FhuWPsP5DQ=; b=lNum32t0Q8wyrAahO5DbDC05GzRnfrdDm53oTW3qQANdaTzN4kcavYzYW1D5Qoav1H EIQg+Oh7Nou64GuaLVK7onN3aG/U8OyUdx4cXQMByYuYqXL0xerGX80nR+/fdb0eEbu9 hlrdWVi5X6e65TwpYew9SHjI7igniR35YUX05JBOr70fmU/LGuz8zrnQYA4LUeoVelax HPxlj68CNIcgI2yGrl7iak9mjdfCw7I28cXdQwbpWuAQggnXAIT68SRF5zefitB62I1d qYY1v0Bimc25WQp9kOUXNmJf426Cf0IldhdeTiZhx1SaucxY4hjufrPrNzFvKtzGGmY5 w2LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YAHmlnZ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz2-20020a1709072ce200b0073174501deesi10890898ejc.24.2022.08.23.02.59.22; Tue, 23 Aug 2022 02:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YAHmlnZ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234280AbiHWJqt (ORCPT + 99 others); Tue, 23 Aug 2022 05:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352563AbiHWJld (ORCPT ); Tue, 23 Aug 2022 05:41:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F1D979625; Tue, 23 Aug 2022 01:41:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19F6061446; Tue, 23 Aug 2022 08:41:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20E77C433C1; Tue, 23 Aug 2022 08:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661244112; bh=20lKauL1YVUqyPxh4iNRKgHY+P1m62xaHe6u7/78kJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YAHmlnZ48hQ8iS2n7fWa5pZfT5k6k+a5m5Dk1KB+yCycCcy89FsBQf7tLXCi/10nh 7+aiW2cIye25f8mI/tRrBdnFB6KkYftYTbqXemwtN24m8fnuX6+ivkLVE5wyKGti7W sCuWWt9+88U7XMsxcDX4hIbmP0d+5NA/lqPfys9k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Trond Myklebust Subject: [PATCH 5.15 038/244] NFSv4.1: Handle NFS4ERR_DELAY replies to OP_SEQUENCE correctly Date: Tue, 23 Aug 2022 10:23:17 +0200 Message-Id: <20220823080100.329675799@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220823080059.091088642@linuxfoundation.org> References: <20220823080059.091088642@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust commit 7ccafd4b2b9f34e6d8185f796f151c47424e273e upstream. Don't assume that the NFS4ERR_DELAY means that the server is processing this slot id. Fixes: 3453d5708b33 ("NFSv4.1: Avoid false retries when RPC calls are interrupted") Signed-off-by: Trond Myklebust Signed-off-by: Greg Kroah-Hartman --- fs/nfs/nfs4proc.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -856,7 +856,6 @@ static int nfs41_sequence_process(struct __func__, slot->slot_nr, slot->seq_nr); - nfs4_slot_sequence_acked(slot, slot->seq_nr); goto out_retry; case -NFS4ERR_RETRY_UNCACHED_REP: case -NFS4ERR_SEQ_FALSE_RETRY: