Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3396000rwa; Tue, 23 Aug 2022 04:12:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR6FmT5vWvlr9OOSNh6DLfoIw9nWfBbtce4XUisNQDrAVKgfTuZ17iYlc5OXWb8wPBXjw5N7 X-Received: by 2002:a17:903:230c:b0:173:361:c345 with SMTP id d12-20020a170903230c00b001730361c345mr1836772plh.20.1661253126196; Tue, 23 Aug 2022 04:12:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661253126; cv=none; d=google.com; s=arc-20160816; b=HR91/fAuDYbHCGf3cidqF3JXVsAmDA6uzDEk6TBZRQBv+AZmqpB0hI6ICWkTaZNKga xkO13KNwsSIaJv9o1tsBxpQX8gP2o9cE8D1ZSbdNyTYtfCTU4hyD4ClkGur3K3i64Qvw BUNIXKpmpgVToIS9PLm2e2H/jt6g+R+cyk3XSdValeQh1rvoZdHDKyFvURWYuPCsTqPX W4Q2QSQCG+gvmk2b0NypG9RztXFudQFzBfoAxn2yQCzatDxJkufwy/Q0n9FYp2TpQ4G8 Qb36V/JfQzBK+y8GxSRjsC31/m6EaEXRM2nD1ko691hRKMXj6hp2/nycfs0nb6EIiW/r h8qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=29hiS4yHaycTVDSJ07IYc6Qx0rAHMB/phUF8CIdrp+A=; b=zGUkKiBpknqdNf/IAECbGaz93T1RopYONfMCxtfjzxAKsNHoJIvlNIPhlabqX2hSJ5 EpX+VVld995JItdrYcOEd1cbPvMLoW14B/OSjPiiasOVwNkMAyFc3JknIqjZiT8oK9ym kUPzb3X1X6jTaFUR3eETOD4ispOg+DOlOBcSDBMY3LpdwSC3h2xIT3Ra8FDsEeaNe7Se BqBwGg4QjSKd+S69GnjVxvdyVYlboKS1AIWkngIjocsWW6pq/i8UOMO3V8rpwgD5YFtv 0k5ql211Sv6cLgjYIO1aG3n7Pm1vNEwXDjNf/OMRgbgaRaURPMX1s1fuvZIiXX4tP2fl CfNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CWF1Z9nh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bw11-20020a056a00408b00b00536542c9c23si9398930pfb.67.2022.08.23.04.11.55; Tue, 23 Aug 2022 04:12:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CWF1Z9nh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348007AbiHWJOU (ORCPT + 99 others); Tue, 23 Aug 2022 05:14:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349098AbiHWJLL (ORCPT ); Tue, 23 Aug 2022 05:11:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40B17286D5; Tue, 23 Aug 2022 01:31:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E4EC6132D; Tue, 23 Aug 2022 08:31:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8281FC433D6; Tue, 23 Aug 2022 08:30:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661243459; bh=cFQps2UgGzKfxxucgJAhHcyTCzeTMbAGguhyK1OacKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CWF1Z9nhrRlE6ZAXegC8VGI0H8NWto1hBTRZV/TIZMNltDrWskq9wuxAGEgMg+Mcn w/wNCxJaVBdcv+6CkmIlD+p151jLkIbtxBdB/CyQ6GyBlCGop3dhq6I5w+r2rHbZyr ELljfYUD62v/s/MbEumOMBiTvipS6XLKLI7pE77M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Justin Tee , James Smart , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.19 284/365] scsi: lpfc: Prevent buffer overflow crashes in debugfs with malformed user input Date: Tue, 23 Aug 2022 10:03:05 +0200 Message-Id: <20220823080130.060142264@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220823080118.128342613@linuxfoundation.org> References: <20220823080118.128342613@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: James Smart [ Upstream commit f8191d40aa612981ce897e66cda6a88db8df17bb ] Malformed user input to debugfs results in buffer overflow crashes. Adapt input string lengths to fit within internal buffers, leaving space for NULL terminators. Link: https://lore.kernel.org/r/20220701211425.2708-3-jsmart2021@gmail.com Co-developed-by: Justin Tee Signed-off-by: Justin Tee Signed-off-by: James Smart Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_debugfs.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index 7b24c932e812..25deacc92b02 100644 --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -2607,8 +2607,8 @@ lpfc_debugfs_multixripools_write(struct file *file, const char __user *buf, struct lpfc_sli4_hdw_queue *qp; struct lpfc_multixri_pool *multixri_pool; - if (nbytes > 64) - nbytes = 64; + if (nbytes > sizeof(mybuf) - 1) + nbytes = sizeof(mybuf) - 1; memset(mybuf, 0, sizeof(mybuf)); @@ -2688,8 +2688,8 @@ lpfc_debugfs_nvmestat_write(struct file *file, const char __user *buf, if (!phba->targetport) return -ENXIO; - if (nbytes > 64) - nbytes = 64; + if (nbytes > sizeof(mybuf) - 1) + nbytes = sizeof(mybuf) - 1; memset(mybuf, 0, sizeof(mybuf)); @@ -2826,8 +2826,8 @@ lpfc_debugfs_ioktime_write(struct file *file, const char __user *buf, char mybuf[64]; char *pbuf; - if (nbytes > 64) - nbytes = 64; + if (nbytes > sizeof(mybuf) - 1) + nbytes = sizeof(mybuf) - 1; memset(mybuf, 0, sizeof(mybuf)); @@ -2954,8 +2954,8 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf, char mybuf[64]; char *pbuf; - if (nbytes > 63) - nbytes = 63; + if (nbytes > sizeof(mybuf) - 1) + nbytes = sizeof(mybuf) - 1; memset(mybuf, 0, sizeof(mybuf)); @@ -3060,8 +3060,8 @@ lpfc_debugfs_hdwqstat_write(struct file *file, const char __user *buf, char *pbuf; int i; - if (nbytes > 64) - nbytes = 64; + if (nbytes > sizeof(mybuf) - 1) + nbytes = sizeof(mybuf) - 1; memset(mybuf, 0, sizeof(mybuf)); -- 2.35.1