Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <673e200f-f458-7866-f956-3d5bd7160a49@os.amperecomputing.com>
Date:   Tue, 23 Aug 2022 15:27:32 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.0
Subject: Re: [PATCH v3 2/2] ARM: dts: aspeed: Add device tree for Ampere's Mt.
 Mitchell BMC
Content-Language: en-CA
To:     Arnd Bergmann <arnd@arndb.de>, Joel Stanley <joel@jms.id.au>
Cc:     openbmc@lists.ozlabs.org, Olof Johansson <olof@lixom.net>,
        soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Jeffery <andrew@aj.id.au>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        thang@os.amperecomputing.com
References: <20220817071539.176110-1-quan@os.amperecomputing.com>
 <20220817071539.176110-3-quan@os.amperecomputing.com>
 <CACPK8XdDpG3ONM1=-E6qvHL1FgMNWSMPoL_sVGJK6BmmnT3w_w@mail.gmail.com>
 <CAK8P3a2LZKfZpdTQ-R4o9mJ6dk52VRF+Bxj=PJEx-1MA4yH8+w@mail.gmail.com>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <CAK8P3a2LZKfZpdTQ-R4o9mJ6dk52VRF+Bxj=PJEx-1MA4yH8+w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnJEeENLZkhoVlRnaU00MkxlQjFNSDcxU0hmTUhMdVlqbjl5NStMTHZLMXVY?=
 =?utf-8?B?RC84aUdrTnhJR2VoSVZRb3pqYWZxSFBhYlhyOUp3dXVqR3l0QU5qY0o1MG9u?=
 =?utf-8?B?L05RalpOVjVpcmpDTUdXa3Y1cGR2VFpWSGloQzEydTc3b0Q0ZTE2VFcxYlF3?=
 =?utf-8?B?SVVON2phYzdYc3VENDJ5czRGVFJoSWlFY3E5QnRwTDVDdm5SbnFXZlFxUEdm?=
 =?utf-8?B?Q1RzdlQ1VmM2VTZKUGViUDdqeXl4dGdBK3R0RGphakN2YUNMd0hFdFR5ZWpm?=
 =?utf-8?B?TlNjbGtHSGVIakxmeHpxamxpck9zbkQ4YzZuNHltaEk5K0VJbkQzWUY5cExP?=
 =?utf-8?B?U3YxMkNJU25ub0d3cFRiWGZjZDdCTVlXT2RIbkw3SmJub01sTnJFRCtTa3ha?=
 =?utf-8?B?Vjk4WDQ1OFhCTEVSRU5QOGR1UkpOYWlodFk1Yi9kUmlJdS9pWmdUOGpjcjRs?=
 =?utf-8?B?RUw2eS9tUHdxaWF1bnJUbkVIbkh5WmJiQVIvTFJ0aTY4UzNVSDl2Vlk4bmpX?=
 =?utf-8?B?OHU2ak9xSHBXUGFkcnphVGpTaWJpKzdOUVVDUFRleUtvbkNUdEFyZ0VDdjIr?=
 =?utf-8?B?TTBpMmkxY1l1VkxIMW1aczJWVWN1M1FqMkVtazE3SDBXNXE2YkJpMWpKSDM0?=
 =?utf-8?B?R0ZERXpJVHMzMk1sZW5pbnQ1OW1ZTU1nQnM2bzBaamhFS28wRWlSODZNdXJB?=
 =?utf-8?B?bEhvME9YTHhTblcyNURRb20wM2NOVEw3SW1RaC9sa1QxQ0RWektTdEluY0dV?=
 =?utf-8?B?UFdZdHhwMXVSZTRjWllzbFhxVjlKR2lmSG1ieEY3TzJPK0xha0RSeHpMMEl5?=
 =?utf-8?B?OElMdm82SDBPWVpoVVIyWCtpQlBkMFFCakt0RWdiTWV0REhqUGhkdWFPVCs2?=
 =?utf-8?B?RVNFQ2ViOFJHRVdHZWlPbXdpOEtxRzNvb2MzcU53WWtTUXNLVXdPMVVnRWpx?=
 =?utf-8?B?YVFKUEdLeUNyTFpOSTlpUHNtYU9PN1NmSUVaSVd1T29rZVlEbnNvOFMwLzhp?=
 =?utf-8?B?T29TODdsT1gyY1NMa1VJcUtaYXU2cVJBRjhUSzV3TEdMcmFoWUE5ZGlYSGs5?=
 =?utf-8?B?dEFDSFJrek5ZM2pLbjRwZGZkalFPdVE5ODdPTlB0aVY1LzhlMGdUQ2pmTGor?=
 =?utf-8?B?dlRZc1I0V2tiT0xIU2I2T0hlTk5UakwxL1IxdEVlbUl0N3NaRVBYV29DallQ?=
 =?utf-8?B?V1NXeWJ6SXh5MSs2NzVSK21ZSEZqUk4yNWs3elMxV3FlZGQ5R2F0U2FCbWxH?=
 =?utf-8?B?YTk2TXFVMXJaMkRwR045eGdMQUdZRWxvN1ZSU3pJT1R0aDRXaXljRWlXVU5W?=
 =?utf-8?B?YWlkVGZnUHFRbE1aYTRTYnEwRTloY2cxUlNaUXYreXVKS201ZnAzZ1VwV1Rr?=
 =?utf-8?B?c2JrL2t2ZlFmNkpSL3htSHlBWnlBSUxRLzBLdjJyYU5ha3F0Zyt4eWVvR1Vt?=
 =?utf-8?B?a1RhQlZmSE8rYWpjMXdxdVRiWmVYUmxSUm1DSjhsRHo2VDZ4cUY2aUlPWC9p?=
 =?utf-8?B?SHBManQwYlBqT25GOFZyNEN6MUF5ZjYwYnVycXBZTWlFNkZYZkMyK1RFUWlv?=
 =?utf-8?B?WEh0bGluYmxUUWdFbkdhRmpOS3NMNUs0QzRkbU1hYnVDR25qc3JYaFFveW5S?=
 =?utf-8?B?c0tRTTNsUURMUENnMjZQcTUxOXhLOVJDbXp5M24rdmRWVU9STHFtS2ZjMm8w?=
 =?utf-8?B?L2FwWkJwMDhJKzJNRXlaNUNOdGhaNU81RTM5RldtZVQyVWcxcmJlK1dFUEZq?=
 =?utf-8?B?L2U3UXF5WjExRnFtdjF3YlBwa2J5OVR4Vi9ITHJ1K3cyV1BvSGV3SXg3eG5k?=
 =?utf-8?B?alhpNk9XVTJqN1JDVUdWUjJtVEpEOHZ5emRROERTRm1hc1o3TExIRmxEb2lk?=
 =?utf-8?B?cFNRQ3ErNTU2RFJTdnJlcXBPRFJsdnJ1U1hyNGIycVo3OHY1TWhxN3ljeFdW?=
 =?utf-8?B?WGo5R3RncEhCbXczZDVRaXprVURhaVpPbWxOL0x6WnYvWGZ3aDUvQng2eE1t?=
 =?utf-8?B?Yy8wZmdCQ0xPc2tHaDY5UnE4bGJNdVJ2VW5SQU9SanM0SlhRTFlJOG1GcUxF?=
 =?utf-8?B?dkxUdXRqNXRvL0lqekJGY0tFT3gvc0YxOGg3WFI3OS9vaTBDUFgvNFhuOWxG?=
 =?utf-8?B?c0lKOXpvWVM2cjRYRm1pNGIzUFhZb2VyZk93cFIyU2FyM0t6cVRmaWVjVHNo?=
 =?utf-8?Q?nXO2EXhn9RkzodNqpOwejkk=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab534e5c-b2c9-4752-9119-08da84e15901
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 08:27:42.7284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vBMfKqW82urWFPOfbA5dIMzFRFI5zq96iJEO5u9PiX8KydJLRNpBtSeRj6SQT5SWz9kkxO6jczjD0uB5bC75N6jQOWnvUhGQAd9BB0BVrk8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR01MB4788
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 18/08/2022 19:06, Arnd Bergmann wrote:
> On Thu, Aug 18, 2022 at 9:33 AM Joel Stanley <joel@jms.id.au> wrote:
>>> +
>>> +/ {
>>> +       model = "Ampere Mt.Mitchell BMC";
>>> +       compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
>>> +
>>> +       chosen {
>>> +               stdout-path = &uart5;
>>
>> I know you've been told by Arnd and others to remove the default
>> command line here, but without it your device tree fails to produce
>> any output in my tests:
>>
>> qemu-system-arm -M ast2600-evb -nographic -dtb
>> arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dtb -kernel
>> arch/arm/boot/zImage
>>
>> Without a working test, I can't tell the difference between a broken
>> device tree and one that omits the serial device on the command line.
>> Can you work with Arnd to come to a solution here?
> 
> If you use qemu as the boot loader, I think the expected way to do
> this is to use the "-append" command line argument along with "-kernel".
> 
> Is there any reason for this machine to be special here?
> 

Thanks Arnd for the comment.

I think adding -append could solve the issue.

But as the bootargs still exist in all other 
arch/arm/boot/dts/aspeed-bmc-*.dts should we still keep bootargs for 
this dts?

Thanks,
- Quan