Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757595AbXFMJa0 (ORCPT ); Wed, 13 Jun 2007 05:30:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756738AbXFMJaR (ORCPT ); Wed, 13 Jun 2007 05:30:17 -0400 Received: from frosty.hhs.nl ([145.52.2.15]:32988 "EHLO frosty.hhs.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756728AbXFMJaQ (ORCPT ); Wed, 13 Jun 2007 05:30:16 -0400 Message-ID: <466FB80E.7050902@hhs.nl> Date: Wed, 13 Jun 2007 11:25:34 +0200 From: Hans de Goede User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Jiri Kosina CC: "H. Peter Anvin" , Linux Kernel Mailing List , Stanislav Brabec , Vojtech Pavlik Subject: Re: Proposal: change keycode for scancode e0 32 from 150 to 172 References: <466F1462.5090008@hhs.nl> <466F1E5C.5090002@zytor.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.2/RELEASE, bases: 13062007 #321577, status: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1625 Lines: 40 Jiri Kosina wrote: > On Tue, 12 Jun 2007, H. Peter Anvin wrote: > >> In PS/2 mode it reports E0 32 which gets converted to keycode 150. In >> USB mode it reports E0 02 which gets converted to keycode 172. >> I don't know if it's the keyboard itself that's being inconsistent, or >> if it is the table in usbkbd.c that's broken (in which case it should be >> fixed to be consistent with the keyboard in PS/2 mode.) > > Hi Peter, > > First, usbkbd.c has very probably zero business with this - the mappings > are being done in hid-input.c, usbkdb.c is only for embedded/debugging > cases, and is almost never used on modern systems (see the corresponding > Kconfig help text). > >> You seem to be of the opinion that "usb behaviour is correct", but don't >> give any motivation why usb should take precedence. Offhand, I would >> expect there to be fewer translation layers for PS/2 and would therefore >> assume PS/2 is more inherently correct. > > For USB, we have Hid Usage Pages, which define this to be KEY_HOMEPAGE. > There is no such specification for PS/2 though, so what Hans is proposing > is to make it consistent with behavior of USB HID devices, which I agree > with. > Good to hear, so as everyone smees to agree, shall I write a (massive, complex, intrusive) patch to fix this, or are there until now silent parties that object? Regards, Hans - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/