Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 Aug 2022 11:41:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     Christopher Carbone <chris.m.carbone@gmail.com>,
        sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
        gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Split multiple assignments to individual lines.
Message-ID: <20220823084133.GG2695@kadam>
References: <YwOjt+ZrQkKFGRH9@valhalla>
 <434d644b-2688-c3e8-814e-b9b2f2b86f85@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <434d644b-2688-c3e8-814e-b9b2f2b86f85@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UXJ8pQ9yHvi+y8MnZduTUEWJflGubqKEZJpA2SIwiXD1pyjJLJGnJxrZpOnd?=
 =?us-ascii?Q?rqB8rANToi7WTlonVTxU451oPDBUZ7HHxUbAnIYBkYp0Se4ICbGesyT7J8g2?=
 =?us-ascii?Q?TJ0acsXPFy33Gy2noa9D9n/mtGjPEJxokwK/ys9WzmzzdqP5Nmscg9oVfGeE?=
 =?us-ascii?Q?ZoiRJzF4xIdoRNHVewkLBk8sziKugo/QscSvnzUZfweGa/4UaSVW/9EWNIt/?=
 =?us-ascii?Q?HPAXUe2N2k4I3HqFarIkwmRXIUKmJ2JZMx34jAdPt7U6POOUxyIyfkw0HOeH?=
 =?us-ascii?Q?FaY1MKw19dpL0ImWHBJ4zsjDMdVgZzFXGggEIq2svtloIxNyiwH1nGtx9MiM?=
 =?us-ascii?Q?wgUwPz/d7ZqLvDZt+FQ1Om1xWpYKJUqZ02jKI+oKEtPjkR6PBggLbmvdGWSD?=
 =?us-ascii?Q?hOqaVcdpogqE0n9bS2UxTZaUI42Y4J+DcrOaTBPBak89OEMR8Md2mr2biLG5?=
 =?us-ascii?Q?wZpzXSQ8dK5fQpGIcBcI6nLDVxb8QnSh831yZRHGguqJXcQL8rwO7yUZUkUK?=
 =?us-ascii?Q?AOGfM1K9GW4gss1qWw6sQeyh8u3PVrE5u7g73vxmgvTS28WI8nPeby6qQeat?=
 =?us-ascii?Q?eLrolVKpDqt0EIw+HcyRmVTYa4zFlVZDN4lKwcwKvfb1XjTmd0NUa/WREIWr?=
 =?us-ascii?Q?ZtlnNIF8DQxOclSEnK3wHPKLRfKI54QN+ejt3GvWiWR7p19XDCtXFWIXqRxO?=
 =?us-ascii?Q?lwkbNi3is90gwz5kObLZEfwqhFBz78jAH1WKDTh6xV3Jwo1h5MKgP1xq3fl5?=
 =?us-ascii?Q?t1RZY2AyzV1LwH7OaX0oVJM5K1Qc/Ks6O/7nH6HX/BG1saPezOjUtc90tP/0?=
 =?us-ascii?Q?nLqAVMipv9IfcmEiiR3EUZw/OHMphNm6KhTgZu151izkt31k6cKK1VrJzvZn?=
 =?us-ascii?Q?ugiYi8HjNYU2zMJvJfSTxUpOykqdN+cxPCOP+bLTLRlPu+TPODtJ7CLM7fI+?=
 =?us-ascii?Q?eEFD38l8aQ41AGeh9g8AgL/YTiMe/PjG15UPeONiktK+oK3HXE7O/c95JRG5?=
 =?us-ascii?Q?A4+JWIBvLXhjM2ElQSJmPujerxk0oHqc4g9POvdqw8dW4/VC1j1Ytx+/UnnY?=
 =?us-ascii?Q?ysnJmxKyjv1ZK0IBxxQrGnjlBF/ibolwOp/kovMmU+79IGL6y4C4cLQpmfEd?=
 =?us-ascii?Q?ciMFKg7Jo0nCpCcriTk/q3xOOF040N9NYxsJzLDIag89hH9SgGh7FARAjZ4B?=
 =?us-ascii?Q?T8JTe4cNPu5frzYmKkatYFHj5u8UXcvywoHeBPl+EQ3UiJLGQKM4Wcp0gCsY?=
 =?us-ascii?Q?wbI1276O20YJtKAq+qUeNGYWwtH5iRnwj/ftVtPPj4qIajz1qjkGmiL5HBZm?=
 =?us-ascii?Q?VhKrR18nR80kY7L/6oSmsqYLZhueu9R75SYe7pI4/KVO3oe4BcP4/WbNcuaI?=
 =?us-ascii?Q?GtoX0vBgPHW2FcChyAJvL8HQJIMX30UVwKrHiB5elSz9zg/aX+y87mgpVlEd?=
 =?us-ascii?Q?E56iutlL0RTblUi6y0JEXc19i9UUXuu1O7yXXaJ9AgbJ3w6Tnxk44vMJDdA4?=
 =?us-ascii?Q?nZAAe3VGHg8vp6Ykn0pV+1eOhiPj+mFJrBh7stRuuvbV5uzFXjFCGq1P4qdc?=
 =?us-ascii?Q?sG/k8G+6DW5GSPRlXxcrvqbKq8+o0N5C3pYinkBPvrofFBPYAYqQgTGWthAm?=
 =?us-ascii?Q?gA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cb51a69-9c4d-4793-1e80-08da84e35710
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 08:41:58.1494
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ed9fJcYX9Ee/vj6dFl99E79jnKDHg2mOYW6IExvYLPosXOWRMm2zwd6BDp+w0d8d0XjQ64XxLvKnQVNiFWFzl6FZv9z5QjXqXX1g4aufsQk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB2027
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-23_04,2022-08-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=872
 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208230033
X-Proofpoint-GUID: EdfHFwYMn4tIxHAgHZI7nSC6TCvg72y2
X-Proofpoint-ORIG-GUID: EdfHFwYMn4tIxHAgHZI7nSC6TCvg72y2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 22, 2022 at 08:05:57PM +0200, Philipp Hortmann wrote:
> I personally prefer more this:
> 
> > +	sm750_dev->fbinfo[1] = NULL;
> > +	sm750_dev->fbinfo[0] = NULL;
> 
> That gives a better overview.
> 

Same for everywhere.  Literals are clear than variables.

 Bad:	foo = bar;
Good:	foo = -1;

Avoid pointless indirection.

regards,
dan carpenter