Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3488487rwa; Tue, 23 Aug 2022 05:42:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR4NPRcUdETPT30Jz7xTd9LU9Megm4Bj8Id2ARUkIzO0caYLJqND0AsCOi1nv+iWh8xqFniL X-Received: by 2002:a17:907:72cc:b0:73d:72c1:cc19 with SMTP id du12-20020a17090772cc00b0073d72c1cc19mr8063873ejc.130.1661258572805; Tue, 23 Aug 2022 05:42:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661258572; cv=none; d=google.com; s=arc-20160816; b=BtxasXnWyBWr2wspwiE/HinCtNK5Ut0p5EKynOpcBi9+zjeeBeR/vyWdnAod/cLtfX pyLPlYDYEYBITbJ5iqjNWM2aAu7TYhuiIeM7cDNVhIWOqo3Lk3M9DSsDVWrHobioAbwT HZDRQkBJNs5cYQ14vhvzkZYA8zLJ2WuulgeuZdUdQgu3DBx6hIUao2gaKK/FSzW0p1vO F6gx6gXSpsP2JhgJnsZ631Irw5+djZTeTdb4f2R2CZGb47dBn25tKrLZPaln0fRKFuD3 kSbFvI+d6AVWrAwwhn1XRo5fWDV07aOj1y1NDHybdmmsC+d73pBf7f7gBfsqMUDM5pXK jj3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ckhKREICQJf8TDxBSCS+LSro7d8kHthsuD0AC3a6B60=; b=vwunlmuvTYTinsq43nxSAr6m1NVfSwFkN0X83X6Oa7bD44qaiBN9wOpd8TNdVXMBXr uIxsf2C53823TQ9q196rargPFbxM3KscjbpolWoyIrV2u/xY31fAxCESZlKxTMGqFUT+ NiNb3OfXvLXddAlzmdqTbSk/L7P3KjmBfV3+aEFqE0j4vLEZPNjeEjY0Xmvi+ggysH8Z P2na1nUVJCGp/q8H+kYhO6tUfUUhx4e01UNTCYbKeVXn3xt4/GjkYiknnyCqbZt9Ez4q pdI4eQH0cruWhC9IQTEsJy2bwlGXAthEIs/xY8Be9hJHrnQP8V99llLy6M5tWyXmQhYQ pwoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EVF6wkeX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t23-20020a056402241700b00445f3dd3861si1831657eda.313.2022.08.23.05.42.26; Tue, 23 Aug 2022 05:42:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EVF6wkeX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349545AbiHWLav (ORCPT + 99 others); Tue, 23 Aug 2022 07:30:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357676AbiHWL0i (ORCPT ); Tue, 23 Aug 2022 07:26:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0763BFE81; Tue, 23 Aug 2022 02:24:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 94108B81C86; Tue, 23 Aug 2022 09:24:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C625FC433C1; Tue, 23 Aug 2022 09:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661246654; bh=BsiNkFf8a+ud4pJ0SB7cr/5NOTD3WmS0vMiFC0bRA84=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EVF6wkeXchpJ0tpZX/TdrOJvvZY7AdtIRCpQSqZp2wgaekQM1xQIN5sX/knKI0mOs R0rollJRtK3SZN5zWYhKVY/SjGk6Wy/9Ly+blkhea+OjGfr78iw/qN+hm8ob2Jr1jx 3KmDMKRZRJQhJv0hx+OjupVgylkU1WoW2N3AqmpI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Ulf Hansson , Sasha Levin Subject: [PATCH 5.4 178/389] mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage_switch Date: Tue, 23 Aug 2022 10:24:16 +0200 Message-Id: <20220823080123.076834713@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220823080115.331990024@linuxfoundation.org> References: <20220823080115.331990024@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit b5899a3e2f783a27b268e38d37f9b24c71bddf45 ] of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() checks null pointer. Fixes: ea35645a3c66 ("mmc: sdhci-of-esdhc: add support for signal voltage switch") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220523144255.10310-1-linmq006@gmail.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/sdhci-of-esdhc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 0ff339004d8a..69c133e7ced0 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -844,6 +844,7 @@ static int esdhc_signal_voltage_switch(struct mmc_host *mmc, scfg_node = of_find_matching_node(NULL, scfg_device_ids); if (scfg_node) scfg_base = of_iomap(scfg_node, 0); + of_node_put(scfg_node); if (scfg_base) { sdhciovselcr = SDHCIOVSELCR_TGLEN | SDHCIOVSELCR_VSELVAL; -- 2.35.1