Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eacfe142-7f60-d938-4421-4d7b464759e8@axentia.se>
Date:   Tue, 23 Aug 2022 11:51:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] extcon: usbc-tusb320: make sure the state is initialized
 on probe
Content-Language: en-US
From:   Peter Rosin <peda@axentia.se>
To:     Chanwoo Choi <cwchoi00@gmail.com>, linux-kernel@vger.kernel.org
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Michael Auchter <michael.auchter@ni.com>
References: <ab1ad93b-4d39-8863-9704-da779fc4c426@axentia.se>
 <c6d43dab-57bf-7041-9a5a-345fa35ca0c7@gmail.com>
 <38ab6884-d0a9-8acd-84cd-dcf6f3f40bc8@axentia.se>
In-Reply-To: <38ab6884-d0a9-8acd-84cd-dcf6f3f40bc8@axentia.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWJBbDBmdzNsOGx3YS9ydDBUSG5YWGtRcXZhM04rcUNEUE5PM3dZb0dFSDBo?=
 =?utf-8?B?bzJnZk9yZWRzTVJJSlJSaWdYQlVhWk9MOVFqbm8zQ1VxVmJnZFVZVW11Z1Jm?=
 =?utf-8?B?ZEdOaVMzNndnM2ZBQUVIeG1ZckVtRmRKRGhkMkFEbmpienh1UkhiRHNoclJn?=
 =?utf-8?B?NWZwdVVaR3ZNUlZSeldQOFNObnhkTjlkWC9BbEtVNm1rRThmQXF0bGdmZFo1?=
 =?utf-8?B?a3ozT2F6M2IvQkwwTG1HZHAwYVkyTXVrUk41MzFlTWxEM1NxSkZ1NTQwU1dM?=
 =?utf-8?B?UVVQc2g3SExFdXBnYmtXTWFWcURuVFlRdXZERFBkdFovZnE2NFRBSmc1b25l?=
 =?utf-8?B?VytlazNqWkgzMmVyZFFQTzdEOHErUmhiYXFLdUdZNlRhaFpnelY0TlltS3Jv?=
 =?utf-8?B?UnVNQ0MyZm5JN3ZGYnZEakJxRGkrMmRtUytwZERIN2dleGN2YTIvZURkS3lx?=
 =?utf-8?B?aXI4RzVFUTBHMENBbm1GRTY0Y3pRdFZtTXI0ZXVSMzFnNS80VTU5K01Vb3Iv?=
 =?utf-8?B?UlpOM1Z0YVV0QWljQlJQclJKVnhrbEVLUUwyS0orcFk0QWVZdzVvN0hkUGl1?=
 =?utf-8?B?cEY2ajBNWFRnVEZFby84d0pGZEpud0hPQlF4TjRSZHE0N3ZQN3htWk95ejgw?=
 =?utf-8?B?bGtkMTNodHA4NEpGdXVoYm9PenJlTTN2bXpmbmpuL0FGZ0pkcWZaM0JMamUy?=
 =?utf-8?B?WlBacU1YVFhET1JYdXA1TG1xZ1RDTG01YWl5bGRTU1MrQm5nYndUYTBUK0gy?=
 =?utf-8?B?VkZhZDdSWURhYjRjRDYyUnRUSHJCc1lpSTJHS3REdUFUejJER0oxWTFJYjRV?=
 =?utf-8?B?aUdzOEFWWFNpUDJLVVowY1RkOWNIOTRmTkJNak1xaTJiRGdTak5GejVXZFFV?=
 =?utf-8?B?OURTUnM2aDFPSFNYeWl5andtNXJxOGFHbUw1dExESHNDTUZsbmJoRTZsb3Ft?=
 =?utf-8?B?YjgvYWQ5ckQxQS9jR0FKdStiK3cxbHk3dlkwYmIxV245SFc3SkNqV0RMdGZt?=
 =?utf-8?B?YzJvV2RRQ2F6d1Q2M2Rsa0hVRnprN3hCNlFMRXBsemVSVi9oV0Q1Y0JaSmtW?=
 =?utf-8?B?U0d4T0p3dFR6ckFCRE9vSS9jMko3UFlGQXEyQ1hPbXREenFQSC9NRy9YV2lH?=
 =?utf-8?B?WnhTWG1ONUtlVnNKSnB0ZTZ5UGM3eDUzMlBqcnB6SGlqSGplNmFLRFFOeitC?=
 =?utf-8?B?UUl2VTBXWlJ0S2I5ZEJOQWpUOW5ocDVGdE5WbGVVU0NuUUw1QmYzazFDOE5G?=
 =?utf-8?B?OHB5cnArUGI3MDRSdEJ4c1BwcHY3dmN3V2tTYUpRWUYvajRNNlNqeGYwT3Iv?=
 =?utf-8?B?b1B5NTNZa3lpUWFybS9MbFZ6a3dhcEdEb3p3dEdud2RnVGlPUWgyN2p0eVJ6?=
 =?utf-8?B?MzR0eGh2NWdEMGVxaXNveGw5OHhvTTZIRE5NTWxSWnhvSVUzODVqdngrOE9I?=
 =?utf-8?B?ZGErUTZtTytOME14ZVRHYkZQdzd0d0xoNExtS0tJL1F6amNRM3lnVWlvcGtQ?=
 =?utf-8?B?cVdDeXZYVHpjcVZXY3puRlFyU0FIOWppZGwzcm9EZnQ1bmp5VEwrUnRCTkJq?=
 =?utf-8?B?UW9JdzRlRGg2N25YaG9JY3JhV3lCTGFXRkVvMkVEREo4SUppc3VwVS9CNmE4?=
 =?utf-8?B?K2xJcGMrS3AwdDRUcDlKVnhPU2piNUJMN1p1VGZxdSt4WWtoMWJMTC8xTFJu?=
 =?utf-8?B?RXZGc0c0bXUxcmlFL0FIbmFZNXY4QytOZytEM2NidWIrellPR1d5RGEzaWtm?=
 =?utf-8?B?ZklvSlpSMjNjbkkwVVVxYTNDNFIvRmplbGhGR3lUUDNReWhVSGZ1ZkVYeU82?=
 =?utf-8?B?MzlYU1cxbHk5UVN3Umg2ZVZnVm1FRDJod0w5TDh0ZHZMNUlRdERvRTZHN0RI?=
 =?utf-8?B?SjJ4d09JNll5c2pURkZ0N3FtbnRreEw4OC9tZk9USkNvbXdJYldianFHOTZi?=
 =?utf-8?B?RzM0Rk9nNFNwV0xjb3RFOEl3bVNWZzBpcTNlTWN5M1JXUjB3SDE0RHVVQlRD?=
 =?utf-8?B?OE4yMXY4eVhSanlSTklaVndjUWUwS2F2VGJ3VnNNaGNCdzk0N0tvaFJXRjhx?=
 =?utf-8?B?Wnk3ZmFwek1BWHhPQWthT0o0T1UzK2FhWHErT0JVdThFdGd5QXU3dHRSbWxY?=
 =?utf-8?Q?43262AAPV8TYBYeUtUMf8L6QR?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 1800c84e-2b80-4480-1f5c-08da84ecfdc7
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 09:51:03.2742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oFAmsMbvzuprh+HBYJXubTGuVuPQiOUTWsKC1EoUPD/naF8XerHFooUmcOjb797P
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR02MB5114
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

2022-06-30 at 08:03, Peter Rosin wrote:
> Hi!
> 
> 2022-06-29 at 21:54, Chanwoo Choi wrote:
>> On 22. 6. 23. 20:21, Peter Rosin wrote:
>>> When the port is connected at boot, there is not necessarily
>>> an interrupt flagged in the interrupt status register, causing
>>> the IRQ handler to bail out early without reading the state when
>>> it is invoked directly from probe.
>>>
>>> Add a flag that overrides the interrupt status register and reads
>>> the state regardless during probe.
>>>
>>> Fixes: 06bc4ca115cd ("extcon: Add driver for TI TUSB320")
>>> Signed-off-by: Peter Rosin <peda@axentia.se>
>>> ---
>>>  drivers/extcon/extcon-usbc-tusb320.c | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/extcon/extcon-usbc-tusb320.c b/drivers/extcon/extcon-usbc-tusb320.c
>>> index 6ba3d89b106d..bd3645ae0d52 100644
>>> --- a/drivers/extcon/extcon-usbc-tusb320.c
>>> +++ b/drivers/extcon/extcon-usbc-tusb320.c
>>> @@ -55,6 +55,7 @@ struct tusb320_priv {
>>>  	struct extcon_dev *edev;
>>>  	struct tusb320_ops *ops;
>>>  	enum tusb320_attached_state state;
>>> +	bool initialized;
>>>  };
>>>  
>>>  static const char * const tusb_attached_states[] = {
>>> @@ -195,7 +196,7 @@ static irqreturn_t tusb320_irq_handler(int irq, void *dev_id)
>>>  		return IRQ_NONE;
>>>  	}
>>>  
>>> -	if (!(reg & TUSB320_REG9_INTERRUPT_STATUS))
>>> +	if (priv->initialized && !(reg & TUSB320_REG9_INTERRUPT_STATUS))
>>>  		return IRQ_NONE;
> 
> Do not return early if priv->initialized is false. Behave as before if
> priv->initialized is true.
> 
>>>  
>>>  	state = (reg >> TUSB320_REG9_ATTACHED_STATE_SHIFT) &
>>> @@ -297,6 +298,8 @@ static int tusb320_extcon_probe(struct i2c_client *client,
>>>  		 */
>>>  		tusb320_irq_handler(client->irq, priv);
>>>  
>>> +	priv->initialized = true;
>>> +
>>
>> After initializing as 'priv->initialized = true', 
>> tusb320_irq_handler() is not anymore detecting the external connector changes.
> 
> Have you tested the patch and observed the trouble you are reporting, or
> have you simply misread the patch?
> 
>>
>> If external connector is detached after finished kernel boot,
>> how to change the state of external connector by using extcon_set_state()?
>>
> 
> If you did test this and there actually is a problem, maybe there should be
> READ_ONCE in the irq handler when checking and WRITE_ONCE when assigning
> priv->initialized. But if that's really what's going on I'd be surprised
> when it's a variable that changes *once* before the interrupt has even
> been requested.
> 
> Cheers,
> Peter

Ping?

Cheers,
Peter