Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f3c614e5-cc96-4313-0279-4b4500049f90@riseup.net>
Date:   Tue, 23 Aug 2022 08:46:47 -0300
MIME-Version: 1.0
Subject: Re: [PATCH v2] drm/amd: remove duplicated argument to &&
Content-Language: en-US
To:     Bernard Zhao <bernard@vivo.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Samson Tam <Samson.Tam@amd.com>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     zhaojunkui2008@126.com
References: <20220823071426.26015-1-bernard@vivo.com>
From:   =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>
In-Reply-To: <20220823071426.26015-1-bernard@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Bernard

On 8/23/22 04:14, Bernard Zhao wrote:
> This patch trf to fis cocci warning:

I believe that there are a couple of typos on this description. Maybe 
you could fixed to s/trf/try and s/fis/fix.

> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c:
> 2349:8-34: duplicated argument to && or ||
> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c:
> 3680:8-55: duplicated argument to && or ||
> 
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Also, it would be nice to have a changelog between the versions.

Other than those small nits,

Reviewed-by: Maíra Canal <mairacanal@riseup.net>

Best Regards,
- Maíra Canal

> ---
>   .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c    | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> index cb2025771646..f99c1696a1f6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> @@ -2346,8 +2346,7 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
>   
>   			if (mode_lib->vba.DSCEnable[k] && mode_lib->vba.ForcedOutputLinkBPP[k] != 0)
>   				mode_lib->vba.DSCOnlyIfNecessaryWithBPP = true;
> -			if ((mode_lib->vba.DSCEnable[k] || mode_lib->vba.DSCEnable[k])
> -					&& mode_lib->vba.OutputFormat[k] == dm_n422
> +			if (mode_lib->vba.DSCEnable[k] && mode_lib->vba.OutputFormat[k] == dm_n422
>   					&& !mode_lib->vba.DSC422NativeSupport)
>   				mode_lib->vba.DSC422NativeNotSupported = true;
>   
> @@ -3678,7 +3677,6 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
>   			if (mode_lib->vba.SourcePixelFormat[k] != dm_444_64
>   					&& mode_lib->vba.SourcePixelFormat[k] != dm_444_32
>   					&& mode_lib->vba.SourcePixelFormat[k] != dm_444_16
> -					&& mode_lib->vba.SourcePixelFormat[k] != dm_444_16
>   					&& mode_lib->vba.SourcePixelFormat[k] != dm_444_8
>   					&& mode_lib->vba.SourcePixelFormat[k] != dm_rgbe) {
>   				if (mode_lib->vba.ViewportWidthChroma[k] > mode_lib->vba.SurfaceWidthC[k]