Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3725655rwa; Tue, 23 Aug 2022 09:06:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR5YyJOAvuBcG95xWoEAhap5HxYjEGchaXA/g7jHFkyX+TLIytnBdfxOg+af6U7dURTJxuAS X-Received: by 2002:a17:907:87b0:b0:738:e618:99ca with SMTP id qv48-20020a17090787b000b00738e61899camr181762ejc.357.1661270794942; Tue, 23 Aug 2022 09:06:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661270794; cv=none; d=google.com; s=arc-20160816; b=kONpjCplqyv36zzLHNCVvTd1NuEtIrZNLJ8rlfAab0uYOumLMGsgrYG/0klTjoDjNH E0WsjAljrSYO1szRF8jVqVGISet5h7Wq+bVvcALcqt16cUVayW7eq653fKwuMVAvfou1 tRtIQF3s8RqRdPpW4Dbj7TUK6mDj4KmqfYFBiSPy0EmLFVkbrU1JtdT13USWs0mmorWr s1G7wp7IIV75xTHPKWpmCIdyhdWsiniry6DjhnK3D26d8D5p+rgwrAxH5H480qzyRlgG pzx/+7/LvOlppLnqleg9TymT9WekpGT3OEFksu8bWSivbAW8OxLf18rNo6aB/iX/hvWW ANFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=b2hnowcwHFxAOiyT+aX7MdafAY2coAhzu9xYD4AoLfY=; b=wax5zPYCyV6gAqXMGH7JNzHP1aEQ91ZehfoNZGI4gs7fMEELkqmTuKTqXwkMedImjd yGFWi5Boj3DjroMGwOJm3zdcEc1oa7YkIXBgkhClQKKJcz0w6ufKuOjSHrK4i+lW7/3r fTyJtHEwErGUdMqXE5eZeRmioq9GvsmUK+/VUV/zSZdZ9ZIcnlQ7WOOCe9LqeBuwWBF6 WoJ6nsqeEaYu0z9jq7ydA9baKFEx9E5BJw/8NM/jxnKEU7t4tzk5HD60+KlWe52OQG53 egtT8WJnlENkna9BMsrA2G5VBS8eAd4qn0wTMpRSRcWNTLFVkC4H4HuKZOksuPKrcB41 lrIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020a1709060ac300b007316ac034a5si29750ejf.844.2022.08.23.09.06.07; Tue, 23 Aug 2022 09:06:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242776AbiHWPvK (ORCPT + 99 others); Tue, 23 Aug 2022 11:51:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244030AbiHWPua (ORCPT ); Tue, 23 Aug 2022 11:50:30 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E42DB21FA3D; Tue, 23 Aug 2022 04:55:19 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oQSTe-0004TT-EA; Tue, 23 Aug 2022 13:53:50 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Krzysztof Kozlowski , Vinod Koul , Chris Ruehl , Jensen Huang , Brian Norris , Doug Anderson Cc: Jensen Huang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on rk3399 Date: Tue, 23 Aug 2022 13:53:49 +0200 Message-ID: <23552842.6Emhk5qWAg@diego> In-Reply-To: <20220822074139.3810-1-jensenhuang@friendlyarm.com> References: <20220822074139.3810-1-jensenhuang@friendlyarm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 22. August 2022, 09:41:39 CEST schrieb Jensen Huang: > Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled > by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode. > > Tested on NanoPC-T4. > > Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts") > Signed-off-by: Jensen Huang ok, so this looks like it restores previous functionality. I'm just wondering as the "offending" patch is from 2020, why this only turns up now. Any ideas? > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 9d5b0e8c9cca..9491cafbbaa3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1561,6 +1561,7 @@ emmc_phy: phy@f780 { > clock-names = "emmcclk"; > drive-impedance-ohm = <50>; > #phy-cells = <0>; > + rockchip,enable-strobe-pulldown; > status = "disabled"; > }; > >