Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 Aug 2022 07:26:36 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     Zeng Heng <zengheng4@huawei.com>
Cc:     linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] xfs: remove redundant else for clean code
Message-ID: <YwTjnM/vvzTKLQWk@magnolia>
References: <20220823014745.4156948-1-zengheng4@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220823014745.4156948-1-zengheng4@huawei.com>
Precedence: bulk

On Tue, Aug 23, 2022 at 09:47:45AM +0800, Zeng Heng wrote:
> "else" is not generally useful after a return, so remove it for clean code.
> 
> There is no logical changes.
> 
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
> ---
>  fs/xfs/xfs_log.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 386b0307aed8..f6e7e4fd72ae 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -226,12 +226,12 @@ xlog_ticket_reservation(
>  	if (head == &log->l_write_head) {
>  		ASSERT(tic->t_flags & XLOG_TIC_PERM_RESERV);
>  		return tic->t_unit_res;
> -	} else {
> -		if (tic->t_flags & XLOG_TIC_PERM_RESERV)
> -			return tic->t_unit_res * tic->t_cnt;
> -		else
> -			return tic->t_unit_res;
>  	}
> +
> +	if (tic->t_flags & XLOG_TIC_PERM_RESERV)
> +		return tic->t_unit_res * tic->t_cnt;
> +
> +	return tic->t_unit_res;

I think this looks correct
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

>  }
>  
>  STATIC bool
> -- 
> 2.25.1
>