Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3797677rwa; Tue, 23 Aug 2022 10:14:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR7a06AodxlC08CAMyNd5NPMYq8dM3dVo0IOxT016NZeedVQoh7CgMmlidDnKS2hNIyDsp2l X-Received: by 2002:a17:903:2412:b0:173:1c7:a9ef with SMTP id e18-20020a170903241200b0017301c7a9efmr3335155plo.62.1661274895960; Tue, 23 Aug 2022 10:14:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661274895; cv=none; d=google.com; s=arc-20160816; b=PzxHssDLLkVuk5G8ZUPAZR8L9UvphsjACpX8/d+2sAZXR96p9rZQdVwRr4zh6bT4Bv mIg0CEOiEDbHQImOmDNbRcn65C/lZUCnHw+wTG/92zztw4ej8PzDiTpgJ3IgASXNJZDG DdtB59wa+fz/lbCb37XWRzp3ejzNKuXMDgjMORSaJuYMxUYfXF/S6V/m3k04VVxC9rAg AmtHt3DP5qM9OdybOQCdvHQUVbo2yUNS4e24r4fyCQMaZxRozoykMVmTHEcGkmOrJNNL ZnEoUFIF+vQZ7Up+NJQMXV3+rK9A9JlIoZOgSUy3Wl6fs1V3ahCO9M49qiP0FHJCp7Lc nsPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=34PbuF0eVwU1fZKmyxntLGj0oriQwCLeUvgJJbU6faI=; b=UJbbD7NNFTQAd2+mnMBg0LJDdG+koq1H+1/KPKv2SjADoqcNT98GzI5F2sIXTV7IQB dWQ8wuMtK+ekjRJeen3LkdB51sBTH266ANjQ1tr+RH6N+EwOVe41UYaNo0OdQ8TrJpG1 JvD+oXBgbumxPyyKcNHTOI+o2elJyOHuO9Pavn3K20BYbZvExVwAipXOq+bu9+57lA// hXPm6vfbVr2jcr1GzGBBde9UAYCkdaI3EMRQ6xq0EAUWVxI1UAh7DjW2NDsYiALXZJnl GudTyw5ilYw4TrvsekZ2SAXGkMLIw4wPHbuVRSA6Jw0MUxmGUFc3ryxkh9XI6dlFtJm0 pozA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gPDHTqxC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l17-20020a63da51000000b004202cb15b7dsi15374751pgj.81.2022.08.23.10.14.45; Tue, 23 Aug 2022 10:14:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gPDHTqxC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245341AbiHWQ64 (ORCPT + 99 others); Tue, 23 Aug 2022 12:58:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245232AbiHWQ6b (ORCPT ); Tue, 23 Aug 2022 12:58:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A13CB7675C for ; Tue, 23 Aug 2022 07:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661264099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=34PbuF0eVwU1fZKmyxntLGj0oriQwCLeUvgJJbU6faI=; b=gPDHTqxComfuxYHBM3hqAdRbNvAeCGf6NLqKiGQluW0tuGiDVM07HlC1b030JbiWFSbZHy PpD2rNsmWMJQh1kf/grYGWCFwsOsB4YIpO0Kw1Rcge4K8F5YkC2PR9lykmRGlGnSWoof0d iDD1Qc67o9TlNRNRS6y6UyUeposKgSI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-327-Q7bLziqjNHmD9kYI60vzyg-1; Tue, 23 Aug 2022 10:14:56 -0400 X-MC-Unique: Q7bLziqjNHmD9kYI60vzyg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 229909682A2; Tue, 23 Aug 2022 14:14:56 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 013C81415138; Tue, 23 Aug 2022 14:14:54 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <166126004083.548536.11195647088995116235.stgit@warthog.procyon.org.uk> <166126006184.548536.12909933168251738646.stgit@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, sfrench@samba.org, linux-cifs@vger.kernel.org, lsahlber@redhat.com, jlayton@kernel.org, dchinner@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, samba-technical@lists.samba.org Subject: Re: [PATCH 3/5] smb3: fix temporary data corruption in collapse range MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <714207.1661264094.1@warthog.procyon.org.uk> Date: Tue, 23 Aug 2022 15:14:54 +0100 Message-ID: <714208.1661264094@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox wrote: > truncate_pagecache_range(inode, start, end); > > ... and presumably, you'd also want the error check? truncate_pagecache_range() is void. David