Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 Aug 2022 10:38:27 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Heiko Carstens <hca@linux.ibm.com>
Cc:     Thomas Richter <tmricht@linux.ibm.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        svens@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com
Subject: Re: [PATCH v2] perf list: Add PMU pai_crypto event description for
 IBM z16
Message-ID: <YwTYU+xXZJr0kH5u@kernel.org>
References: <20220804075221.1132849-1-tmricht@linux.ibm.com>
 <YvOq3B02x8GqkVPA@kernel.org>
 <YwSdWUt02SFzrMUm@osiris>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YwSdWUt02SFzrMUm@osiris>
Precedence: bulk

Em Tue, Aug 23, 2022 at 11:26:49AM +0200, Heiko Carstens escreveu:
> On Wed, Aug 10, 2022 at 09:55:56AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Aug 04, 2022 at 09:52:21AM +0200, Thomas Richter escreveu:
> > > Add the event description for the IBM z16 pai_crypto PMU released with
> > > commit 1bf54f32f525 ("s390/pai: Add support for cryptography counters")
> > 
> > What tree is this? I tried on torvalds/master:
> > 
> > ⬢[acme@toolbox perf]$ git remote update torvalds
> > Fetching torvalds
> > ⬢[acme@toolbox perf]$ git log --oneline -1 torvalds/master
> > d4252071b97d2027 (torvalds/master) add barriers to buffer_uptodate and set_buffer_uptodate
> > ⬢[acme@toolbox perf]$ git show torvalds/master d4252071b97d2027 | head -5
> > commit d4252071b97d2027d246f6a82cbee4d52f618b47
> > Author: Mikulas Patocka <mpatocka@redhat.com>
> > Date:   Tue Aug 9 14:32:13 2022 -0400
> > 
> >     add barriers to buffer_uptodate and set_buffer_uptodate
> > ⬢[acme@toolbox perf]$ git show torvalds/master 1bf54f32f525 | head -5
> > fatal: ambiguous argument '1bf54f32f525': unknown revision or path not in the working tree.
> > Use '--' to separate paths from revisions, like this:
> > 'git <command> [<revision>...] -- [<file>...]'
> > ⬢[acme@toolbox perf]$ git log --oneline torvalds/master | grep "pai: Add support for cryptography counters"
> > ⬢[acme@toolbox perf]$
> > ⬢[acme@toolbox perf]$ git show torvalds/master d4252071b97d2027 | head -4
> > commit d4252071b97d2027d246f6a82cbee4d52f618b47
> > Author: Mikulas Patocka <mpatocka@redhat.com>
> > Date:   Tue Aug 9 14:32:13 2022 -0400
> > 
> > I'm applying it locally so that it gets included in testing, but please
> > clarify where is that 1bf54f32f525 cset.
> 
> Thomas mixed up our non public development tree and Linus' tree.
> Correct commit id + subject are:
> 
> 39d62336f5c1 ("s390/pai: add support for cryptography counters")

Ok, this is already upstream, with this note:

----
    Committer notes:

    Couldn't find 1bf54f32f525 ("s390/pai: Add support for cryptography
    counters") in torvalds/master, in what tree is that cset?
----

Not a biggie, the description was added, which is what really matters,
right? :)

- Arnaldo