Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3845967rwa; Tue, 23 Aug 2022 11:07:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR5KiNoaQawsQqVAiCoevq0fvu/dFmfooKxDKMUYK+KN0hMTb1tKupkhENTfy3G6swNG7JdT X-Received: by 2002:a17:906:9b92:b0:730:a237:40fe with SMTP id dd18-20020a1709069b9200b00730a23740femr524779ejc.464.1661278021124; Tue, 23 Aug 2022 11:07:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661278021; cv=none; d=google.com; s=arc-20160816; b=qcJFSm74p4DdXvmmfWL8wTDzeQuA7V1/FC809AV1t+bAbUbfbNenwh6cfxzGLzE3aH u210xXZU0e9WQFlHmSYp41RdEdYnift5hBM9nNJEJq74reviE7e16iyD/LfYmU+76sfB kwOo9A21NqXs64MFahhZoCnlYRAcTv5luB0gkiIEJSU8D9D6G7kkfB6xClI73mnvx3R/ eN2YpMycYqKuh+mQNq9lsnX/XXLyvvzV06W5O2n5hxYG2eJ7zNp9jwq7fgCM/RTSSIIb KYC5NSDAhBKR0aZdCVmiZVGoj3sUNo8rPfJnT+51cdTyz+FUPQENWm6LA1iqZuiQHG5j 3/KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=n7iR6psZ0iOUa2Hyhot7GU8syOFqaZ9ER5oGtEDczdg=; b=mp28wx0QRr2lwHERQjiqNEYditnkPMDeUt9afiBahc4mOzrE9rW8Ydu9RfAHpIQ+0V whHDX2w9ey1sOSWZAexhXEeBvcjqVtGcT2sE0iqIhuJbyzyBRWOhJxWr/yhN67Ssaux5 S3AMGoW10tDENQGx+5K75Yi0kn61ZWKKOooocvY9aB0yNVJJEtPaMzbK9emNfZgYU/XN ACuWsPe5Q0L83rvBgQf8+tuObZm10288tWzTwcOLMC0+YV37gdHFHnjrtnLWnoVcGWDy jg8xGf6maCYVChBx9w8SswOQoi+rb9c2loQjD8xES7KrF2GRFmSHB/LOtd9mkfLU001+ A4jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=gzwKQkZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q11-20020a50aa8b000000b0043ba52ffd16si2292377edc.453.2022.08.23.11.06.34; Tue, 23 Aug 2022 11:07:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=gzwKQkZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343978AbiHWRMp (ORCPT + 99 others); Tue, 23 Aug 2022 13:12:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344301AbiHWRKl (ORCPT ); Tue, 23 Aug 2022 13:10:41 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8053115B163 for ; Tue, 23 Aug 2022 06:37:50 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id f4so10457985pgc.12 for ; Tue, 23 Aug 2022 06:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc; bh=n7iR6psZ0iOUa2Hyhot7GU8syOFqaZ9ER5oGtEDczdg=; b=gzwKQkZXZT1UZ65SM/9R7Cl/ZDlYyhZQznytLr5Xu3snKGW/n6vebjP7SWs+snSeJZ LOqBtED5BU9MJhTK4LHepgdwhSfNq6yrJySt3Og5p50NhnanNKmYZB88beBshEgcCjA4 ja9+yF6oNDFw8UK1TWra5d0nKp0+x6ic/UgdqwVk0wJTTt0HmmyVOptAm2cKZ3SZ6am8 6sr6hG2k9GisAKOAu69KMupuHuX5DMNsU4MuMkvJqtkdMNBQ9yr36vZ6b+exebrF364R HCdrrR9J8dr6HnWMTWm1diPzzC5mUrQsM1qDkRa8YyZm1SJE+dniIod67iMCnhD32pNc /edQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc; bh=n7iR6psZ0iOUa2Hyhot7GU8syOFqaZ9ER5oGtEDczdg=; b=HVTyciIqszv5vI64BJ9NX2BP5zhKV3rD2ciG6Pf9V9dZAij7qHK1vN/usSwEQvCsa1 qzt51zYtxeESpRhAMjYur9IoWeVC+hILjzPFzgymuP0Svv1qRjaSl34vFMUzlfbwo6dr k1wAD2iE/oaeiMp9OztI8eaofMGnWh8YES6VmgcFmiuZhUVsK9BhMjFqJ5lu68D75zYf IHWsTxRJfrWdRtHNyYSfeV122TQJ6hCkHuegJyqGXNK2ZYFaVdFo+obdZ/+YWHmnrh35 r5ET3xgopU//s7PkQmSvWEPraIUH8jAms+Z/Yf9EBkQrT7cdU4pT48halDoNEdORqO9p 53nA== X-Gm-Message-State: ACgBeo25MjNxj8mWveFUFdT0dh49HNPO1X5eFZkVezQftb+eFmJDU6XP lHGge5SLKvp4c4iFxGSFeaZ2TA== X-Received: by 2002:a62:1b12:0:b0:536:715c:4d96 with SMTP id b18-20020a621b12000000b00536715c4d96mr12590248pfb.77.1661261869924; Tue, 23 Aug 2022 06:37:49 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id u6-20020a170902e5c600b0016d88dc7745sm10512985plf.259.2022.08.23.06.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 06:37:48 -0700 (PDT) From: Jens Axboe To: jack@suse.cz, osandov@fb.com, yukuai1@huaweicloud.com Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, yi.zhang@huawei.com, yukuai3@huawei.com In-Reply-To: <20220803121504.212071-1-yukuai1@huaweicloud.com> References: <20220803121504.212071-1-yukuai1@huaweicloud.com> Subject: Re: [PATCH] sbitmap: fix possible io hung due to lost wakeup Message-Id: <166126186831.27028.2544657181662350295.b4-ty@kernel.dk> Date: Tue, 23 Aug 2022 07:37:48 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Aug 2022 20:15:04 +0800, Yu Kuai wrote: > From: Yu Kuai > > There are two problems can lead to lost wakeup: > > 1) invalid wakeup on the wrong waitqueue: > > For example, 2 * wake_batch tags are put, while only wake_batch threads > are woken: > > [...] Applied, thanks! [1/1] sbitmap: fix possible io hung due to lost wakeup commit: 040b83fcecfb86f3225d3a5de7fd9b3fbccf83b4 Best regards, -- Jens Axboe