Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3854028rwa; Tue, 23 Aug 2022 11:15:20 -0700 (PDT) X-Google-Smtp-Source: AA6agR4cQryIJtXKr6NUROQgERLJHHIc766tFczBRVDVspiku8sNF6JaKBIzoCYN6rKfIzF9bCIU X-Received: by 2002:a17:90b:164f:b0:1f5:4ced:ed81 with SMTP id il15-20020a17090b164f00b001f54ceded81mr4307796pjb.122.1661278520334; Tue, 23 Aug 2022 11:15:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661278520; cv=none; d=google.com; s=arc-20160816; b=e+DnQ0taMlW9lyhXkiI+X8732xItIhSvFStjfsSiDK9Nw75lSlokQ6CHp10DGvL1IE He1wmRr+cG8tUvjr5phK7Ym3hHeIpFJKJ13LIhPUorD27ycemif1zrsyLcHkampGM66o r4sUhbzSXddUIgLszZTn7bXPOau+0b8j6/tN6Xw1HK/sywAA/zp/EY9t07tn5xpaofwv DIoGvGHeuvqOxdE2VRZYC7zzhv72YOWHBPgu0+pgvRjFmVwwBLaxNv5LfojcD2xPU1es qlcbVy5kXmcHcFgKnvVsABKeqhvBCWPt/Hk1r2gvXS3emwTrJT0/d2OIrTYKsLkhqWQI SIkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=FOjOWwLQNoMllLhbMYaAmzb9tItezkenSK6bkw3lwFQ=; b=teYLby9r4Bf2jIDoEiNgGEz810x4Y1RKETXQ4SwyUpYAJ/7HqK9uswvnqbZKoQHBoU tKZWqjp8whB7uslA0Akok+tz30ITTKYdNlA7ZdN66AZGgWwyRm/0lV62fH+iz3D54mFR hsd1IoCXFyR8zxdBWq1vg53I3/CGam3NQYQKrCnT/G+h6nfn+AymNeEwnzNPNVW7+EMp 6eDGY6C7Euj3cq2cL5HHEfbyWIOYZ22boZlN/Z1f29v1QmeEh9iVN0U0UfX+GOvaCps0 l15ltNomtPAQr3A15Kw7wl7WJN3nErOFvH+0B5iWDLPpUZ3mcuAgYxyKgbJZivgyYtPx dOfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fHoWHDkq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u8-20020a056a00124800b0052ade51b8a7si13795796pfi.361.2022.08.23.11.15.09; Tue, 23 Aug 2022 11:15:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fHoWHDkq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343594AbiHWRCP (ORCPT + 99 others); Tue, 23 Aug 2022 13:02:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344337AbiHWRBM (ORCPT ); Tue, 23 Aug 2022 13:01:12 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94BD48B9A8; Tue, 23 Aug 2022 07:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661263840; x=1692799840; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ygPyyv+pU7SFDB61ANVVMzLHJfkZTW1nqc/MGK8nQSs=; b=fHoWHDkqGG/DkLu9Sxx5O4huPaIoiZNt8MndxlG7aZg5GjCLMEwPPHjD xJTDqAr3aZwJwQ3RkxfXHquqshAmbg2eHxEQyBUgMqlKpozrwIOrHJdMB djC8SbxCtstI9m29IzIq1y71n8Bn/6AtTcV7jIfn8TJQoTLIE/UTMsV/6 xrZiJYsRJGA7v1OVwmFSwkU85GEq8ixSHgv0iTwGj9lrvp+eaPjiBmmfL ZEqDwzbRShEioyU5MZILpf9kAxUztind/lUDCp/CN74VyMZB5bzPcX3Rp fEM9HRrSK80XPF/SiaKvNTo8iIkAqmPVJmD/Y+YuhKy8y6MJrbudiDm36 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10448"; a="294978544" X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="294978544" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 07:10:40 -0700 X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="642453030" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 07:10:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oQUbz-002T6k-2M; Tue, 23 Aug 2022 17:10:35 +0300 Date: Tue, 23 Aug 2022 17:10:35 +0300 From: Andy Shevchenko To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tianshu Qiu , Shawn Tu , Bingbu Cao , Mauro Carvalho Chehab Subject: Re: [PATCH v1 1/8] media: ov2740: Remove duplicative pointer in struct nvm_data Message-ID: References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2022 at 03:05:49PM +0300, Andy Shevchenko wrote: > The struct i2c_client pointer is used only to get driver data, > associated with a struct device or print messages on behalf. > Moreover, the very same pointer to a struct device is already > assigned by a regmap and can be retrieved from there. > No need to keep a duplicative pointer. Thanks, Bungbu, for the review. Can it be now applied? -- With Best Regards, Andy Shevchenko