Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4abccfc9-fbaf-8683-5641-f4b767f3f913@arm.com>
Date:   Tue, 23 Aug 2022 10:04:34 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1] ACPI: processor: Remove freq Qos request for all CPUs
Content-Language: en-US
To:     Riwen Lu <luriwen@hotmail.com>, rafael@kernel.org,
        rui.zhang@intel.com, lenb@kernel.org
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Riwen Lu <luriwen@kylinos.cn>
References: <TYWP286MB2601183235622B29FAF707B5B1709@TYWP286MB2601.JPNP286.PROD.OUTLOOK.COM>
From:   Jeremy Linton <jeremy.linton@arm.com>
In-Reply-To: <TYWP286MB2601183235622B29FAF707B5B1709@TYWP286MB2601.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/23/22 02:43, Riwen Lu wrote:
> From: Riwen Lu <luriwen@kylinos.cn>
> 
> The freq Qos request would be removed repeatedly if the cpufreq policy
> relates to more than one CPU. Then, it would cause the "called for unknown
> object" warning.
> 
> Remove the freq Qos request for each CPU relates to the cpufreq policy,
> instead of removing repeatedly for the last CPU of it.
> 
> Fixes: a1bb46c36ce3 ("ACPI: processor: Add QoS requests for all CPUs")
> Reported-by: Jeremy Linton <Jeremy.Linton@arm.com>
> Signed-off-by: Riwen Lu <luriwen@kylinos.cn>
> ---
>   drivers/acpi/processor_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
> index db6ac540e924..e534fd49a67e 100644
> --- a/drivers/acpi/processor_thermal.c
> +++ b/drivers/acpi/processor_thermal.c
> @@ -151,7 +151,7 @@ void acpi_thermal_cpufreq_exit(struct cpufreq_policy *policy)
>   	unsigned int cpu;
>   
>   	for_each_cpu(cpu, policy->related_cpus) {
> -		struct acpi_processor *pr = per_cpu(processors, policy->cpu);
> +		struct acpi_processor *pr = per_cpu(processors, cpu);
>   
>   		if (pr)
>   			freq_qos_remove_request(&pr->thermal_req);

This appears to have fixed the module unloading problem. I haven't seen 
any newer issues either so:

Tested-by: Jeremy Linton <jeremy.linton@arm.com>


Thanks,