Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df514b30-3a9a-679e-1851-7589526960a1@suse.cz>
Date:   Tue, 23 Aug 2022 17:04:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH v4 13/17] mm/sl[au]b: cleanup
 kmem_cache_alloc[_node]_trace()
Content-Language: en-US
To:     Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Roman Gushchin <roman.gushchin@linux.dev>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20220817101826.236819-1-42.hyeyoo@gmail.com>
 <20220817101826.236819-14-42.hyeyoo@gmail.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20220817101826.236819-14-42.hyeyoo@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/17/22 12:18, Hyeonggon Yoo wrote:
> This patch does:

I've removed this line locally and re-idented the rest.

> 	- Despite its name, kmem_cache_alloc[_node]_trace() is hook for
> 	  inlined kmalloc. So rename it to kmalloc[_node]_trace().
> 
> 	- Move its implementation to slab_common.c by using
>           __kmem_cache_alloc_node(), but keep CONFIG_TRACING=n varients to
> 	  save a function call when CONFIG_TRACING=n.
> 
> 	- Use __assume_kmalloc_alignment for kmalloc[_node]_trace
> 	  instead of __assume_slab_alignement. Generally kmalloc has
> 	  larger alignment requirements.
> 
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>