Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220720052841.1630-1-steev@kali.org> <20220720054152.2450-1-steev@kali.org>
In-Reply-To: <20220720054152.2450-1-steev@kali.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Tue, 23 Aug 2022 09:18:05 -0700
Message-ID: <CAD=FV=V9Z49Qmw+Dy7C7x=c5k3NjmqaoRxbU+1BJEje3t-SW7g@mail.gmail.com>
Subject: Re: [PATCH v2] drm/panel-edp: add IVO M133NW4J-R3 panel entry
To:     Steev Klimaszewski <steev@kali.org>
Cc:     David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Johan Hovold <johan@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, Jul 19, 2022 at 10:42 PM Steev Klimaszewski <steev@kali.org> wrote:
>
> Add an eDP panel entry for IVO M133NW4J-R3.
>
> Due to lack of documentation, use the delay_200_500_e50 timings for now.

Doesn't actually match the commit, which uses "delay_200_500_p2e100".
Fixing while applying.


> Signed-off-by: Steev Klimaszewski <steev@kali.org>
>
> ---
> v2 - actually mark it as R3 in the change, not R2...
>
> I'm basing my information gathering off what I could find for the IVO
> M133NW4J panels on panelook.com.  R0 is glossy, and mine is not.  R2
> says it is discontinued, and I am just guessing that I have the R3 as
> the Thinkpad X13s just came out, roughly a month ago.
>
> Signed-off-by: Steev Klimaszewski <steev@kali.org>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 5024ba690abf..870b98041c60 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1883,6 +1883,7 @@ static const struct edp_panel_entry edp_panels[] = {
>
>         EDP_PANEL_ENTRY('C', 'M', 'N', 0x114c, &innolux_n116bca_ea1.delay, "N116BCA-EA1"),
>
> +       EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R3"),

I resolved the merge conflict and applied. Pushed to drm-misc-next:

0f9fa5f58c78 drm/panel-edp: add IVO M133NW4J-R3 panel entry

-Doug