Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 Aug 2022 21:22:10 +0200
From:   Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
To:     Claudiu Beznea - M18063 <Claudiu.Beznea@microchip.com>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "arnd@arndb.de" <arnd@arndb.de>, "olof@lixom.net" <olof@lixom.net>,
        "soc@kernel.org" <soc@kernel.org>,
        Nicolas Ferre - M43238 <Nicolas.Ferre@microchip.com>,
        UNGLinuxDriver <UNGLinuxDriver@microchip.com>,
        "maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH] ARM: dts: lan966x: add support for pcb8290
Message-ID: <20220823192210.cnkxmdb2eryg4hnz@soft-dev3-1.localhost>
References: <20220817190027.1632721-1-horatiu.vultur@microchip.com>
 <8e6c780e-28ee-1f37-c14c-f0ca5f590743@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <8e6c780e-28ee-1f37-c14c-f0ca5f590743@microchip.com>
Precedence: bulk

The 08/23/2022 07:11, Claudiu Beznea - M18063 wrote:

Hi Claudiu,

> > +&gpio {
> > +	miim_a_pins: mdio-pins {
> > +		/* MDC, MDIO */
> > +		pins =  "GPIO_28", "GPIO_29";
> > +		function = "miim_a";
> > +	};
> > +
> > +	pps_out_pins: pps-out-pins {
> 
> Can you also document this one as well? I can do it while applying if you
> provide the strings.

Yes, I will do that.
I will send a new version because I have seen that there is also a small
error in the commit message.

> 
> > +		pins = "GPIO_38";
> > +		function = "ptpsync_3";
> > +	};
> > +
> > +	ptp_ext_pins: ptp-ext-pins {
> 
> Ditto
> 
> Thank you,
> Claudiu Beznea
> 
> > +		pins = "GPIO_35";
> > +		function = "ptpsync_0";
> > +	};
> > +
> > +	udc_pins: ucd-pins {
> > +		/* VBUS_DET B */
> > +		pins = "GPIO_8";
> > +		function = "usb_slave_b";
> > +	};
> > +};
> > +
> > +&mdio0 {
> > +	pinctrl-0 = <&miim_a_pins>;
> > +	pinctrl-names = "default";
> > +	status = "okay";
> > +
> > +	ext_phy0: ethernet-phy@7 {
> > +		reg = <7>;
> > +		coma-mode-gpios = <&gpio 60 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	ext_phy1: ethernet-phy@8 {
> > +		reg = <8>;
> > +		coma-mode-gpios = <&gpio 60 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	ext_phy2: ethernet-phy@9 {
> > +		reg = <9>;
> > +		coma-mode-gpios = <&gpio 60 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	ext_phy3: ethernet-phy@10 {
> > +		reg = <10>;
> > +		coma-mode-gpios = <&gpio 60 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	ext_phy4: ethernet-phy@15 {
> > +		reg = <15>;
> > +		coma-mode-gpios = <&gpio 60 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	ext_phy5: ethernet-phy@16 {
> > +		reg = <16>;
> > +		coma-mode-gpios = <&gpio 60 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	ext_phy6: ethernet-phy@17 {
> > +		reg = <17>;
> > +		coma-mode-gpios = <&gpio 60 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	ext_phy7: ethernet-phy@18 {
> > +		reg = <18>;
> > +		coma-mode-gpios = <&gpio 60 GPIO_ACTIVE_HIGH>;
> > +	};
> > +};
> > +
> > +&port0 {
> > +	reg = <2>;
> > +	phy-handle = <&ext_phy2>;
> > +	phy-mode = "qsgmii";
> > +	phys = <&serdes 0 SERDES6G(1)>;
> > +	status = "okay";
> > +};
> > +
> > +&port1 {
> > +	reg = <3>;
> > +	phy-handle = <&ext_phy3>;
> > +	phy-mode = "qsgmii";
> > +	phys = <&serdes 1 SERDES6G(1)>;
> > +	status = "okay";
> > +};
> > +
> > +&port2 {
> > +	reg = <0>;
> > +	phy-handle = <&ext_phy0>;
> > +	phy-mode = "qsgmii";
> > +	phys = <&serdes 2 SERDES6G(1)>;
> > +	status = "okay";
> > +};
> > +
> > +&port3 {
> > +	reg = <1>;
> > +	phy-handle = <&ext_phy1>;
> > +	phy-mode = "qsgmii";
> > +	phys = <&serdes 3 SERDES6G(1)>;
> > +	status = "okay";
> > +};
> > +
> > +&port4 {
> > +	reg = <6>;
> > +	phy-handle = <&ext_phy6>;
> > +	phy-mode = "qsgmii";
> > +	phys = <&serdes 4 SERDES6G(2)>;
> > +	status = "okay";
> > +};
> > +
> > +&port5 {
> > +	reg = <7>;
> > +	phy-handle = <&ext_phy7>;
> > +	phy-mode = "qsgmii";
> > +	phys = <&serdes 5 SERDES6G(2)>;
> > +	status = "okay";
> > +};
> > +
> > +&port6 {
> > +	reg = <4>;
> > +	phy-handle = <&ext_phy4>;
> > +	phy-mode = "qsgmii";
> > +	phys = <&serdes 6 SERDES6G(2)>;
> > +	status = "okay";
> > +};
> > +
> > +&port7 {
> > +	reg = <5>;
> > +	phy-handle = <&ext_phy5>;
> > +	phy-mode = "qsgmii";
> > +	phys = <&serdes 7 SERDES6G(2)>;
> > +	status = "okay";
> > +};
> > +
> > +&serdes {
> > +	status = "okay";
> > +};
> > +
> > +&switch {
> > +	pinctrl-0 = <&pps_out_pins>, <&ptp_ext_pins>;
> > +	pinctrl-names = "default";
> > +	status = "okay";
> > +};
> > +
> > +&udc {
> > +	pinctrl-0 = <&udc_pins>;
> > +	pinctrl-names = "default";
> > +	atmel,vbus-gpio = <&gpio 8 GPIO_ACTIVE_HIGH>;
> > +	status = "okay";
> > +};
> 

-- 
/Horatiu