Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 Aug 2022 20:53:54 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Frank <Frank.Sae@motor-comm.com>, Peter Geis <pgwipeout@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, yinghong.zhang@motor-comm.com,
        fei.zhang@motor-comm.com, hua.sun@motor-comm.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4.4] net: phy: Add driver for Motorcomm yt8521 gigabit
 ethernet phy
Message-ID: <YwUiQgSGBhbvk7T6@lunn.ch>
References: <20220817112554.383-1-Frank.Sae@motor-comm.com>
 <20220822202147.4be904de@kernel.org>
 <YwTguA0azox3j5vi@lunn.ch>
 <20220823113712.4c530516@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220823113712.4c530516@kernel.org>
Precedence: bulk

> > The user could of changed the pause settings, which are going to be
> > ignored here. Also, you should not assume the MAC can actually do
> > asymmetric pause, not all can. phydev->advertising will be set to only
> > include what the MAC can actually do.
 
> Interesting. Just to confirm - regardless of the two-sided design..
> -edness.. IIUC my question has merit and we need v5?

Yes, phydev->advertising should be take into account.

     Andrew