Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3972335rwa; Tue, 23 Aug 2022 13:38:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR60SrAEQerLqWL1BDuKwJh7XkvK0hp138w76eRy+HzTzXNnD5hFrH7idVNS/AuEghRcrYj1 X-Received: by 2002:a65:68d0:0:b0:422:ebd2:302 with SMTP id k16-20020a6568d0000000b00422ebd20302mr21147934pgt.340.1661287124525; Tue, 23 Aug 2022 13:38:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661287124; cv=none; d=google.com; s=arc-20160816; b=zEWHaelvGoZe5eA6LWy/OUTrVVTJc4H+ovI2aZ0nOIjf0JoaG2jIPHmHfzdPkhlq3J CtPzBrwVX9Hp9cyMKxSjGqEmqI6v7HIWL2Nb5StLV5w6cjUO6y5ZZCGFtd2h0HTtRl5y JbdS7Sa0rgGKakLNC1dq65nIsmYwt8CqTHIzGkASjgL8q1jCS0m9rVQXAwvZVg3+vvgp c3abIB70M36ILE+EYUM/P6A4aO+wqMsyXmE4Yvxahmm02Mxj4Bgz32Fpw5BSvJ4Bm5oo /N7Gl4hoBCCYkb4wIZFxl1mjoEvhWoImM5Wr14W+3ts2ZfxjYEobqfTo4PTTBZqcsEEm 906A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:reply-to:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature; bh=2RCUwt1b+lcpY49aMgbRIAVLt9QpUtE7/soKWVObSPU=; b=wzdUKBenJlhMRJ2Bk1tC1ncUJ/SyVj1JF+f3TJuZ1wHi7Due6CilHKDo7trsQlE7Nn CQMibxd9/b3X23PH8pxMdSgHQ8oNU6QNn6VS6Ot5fJhj5sGIlfhWsR21EQLwrmak3BK/ 0nhf9mqev9Ru/zsSkGaSB7yW1BOtfV0LYgCT33h9KYoy4vQN3nKpNjFhTHfUN2TJVVuQ NU/nfN2CTMbEjQAz47poJ5YujJ9IDZQUwwBu/RrtAvXKr0aNMYhUGRSRs2qyO7eit+2m 4tuTFlds8UNnguBULVC4elrOquuFGiZaWPd7HNzlKllqsyjJWITEk507n+9ywJZyI9Gc 5dCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="P8H/rWXj"; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=pavdNYUS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020a62e50c000000b0052f20d6e3dcsi12084085pff.196.2022.08.23.13.38.33; Tue, 23 Aug 2022 13:38:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="P8H/rWXj"; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=pavdNYUS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230214AbiHWUYv (ORCPT + 99 others); Tue, 23 Aug 2022 16:24:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232097AbiHWUYd (ORCPT ); Tue, 23 Aug 2022 16:24:33 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B64ED4BC0; Tue, 23 Aug 2022 12:51:51 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5BDEB1F8AC; Tue, 23 Aug 2022 19:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661284310; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2RCUwt1b+lcpY49aMgbRIAVLt9QpUtE7/soKWVObSPU=; b=P8H/rWXj/Zjoc0NMM0FOcZpRJmCIUAK9pBQhVCZnIXqukc5vzCdZF17heyMqwFMuGr+SXI FLOPEwDY7nfgXm6NlfGbBCibvgduB3rrOZcF4amzZsh/kjUnAqak3izLa/kwcAkgx7cIkm 7Ly4lZJF1bDIhS15wFd7o71RAJy0854= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661284310; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2RCUwt1b+lcpY49aMgbRIAVLt9QpUtE7/soKWVObSPU=; b=pavdNYUSyduIZiGeGrOST6NK7MGuRB5eV27vIpkmfD/oUluWAdFQUVnrSI8/Razi8VV6AQ r6CRyPwWtRlwKpBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1B80F13A89; Tue, 23 Aug 2022 19:51:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rnopBdYvBWMQeQAAMHmgww (envelope-from ); Tue, 23 Aug 2022 19:51:50 +0000 Date: Tue, 23 Aug 2022 21:46:35 +0200 From: David Sterba To: "Maciej S. Szmigiero" Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: don't print information about space cache or tree every remount Message-ID: <20220823194635.GM13489@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, "Maciej S. Szmigiero" , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2022 at 05:28:20PM +0200, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > btrfs currently prints information about space cache or free space tree > being in use on every remount, regardless whether such remount actually > enabled or disabled one of these features. > > This is actually unnecessary since providing remount options changing the > state of these features will explicitly print the appropriate notice. > > Let's instead print such unconditional information just on an initial mount > to avoid filling the kernel log when, for example, laptop-mode-tools > remount the fs on some events. > > Signed-off-by: Maciej S. Szmigiero Makes sense, added to misc-next, thanks.