Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3974375rwa; Tue, 23 Aug 2022 13:41:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR5fVesGPOnlkRaXZbz3Y3rwEc50I70nMwwXlM7N9XFO92ugO8WGo+/VTpcUcowndudFPb04 X-Received: by 2002:a63:8aca:0:b0:42b:b13:b252 with SMTP id y193-20020a638aca000000b0042b0b13b252mr1637787pgd.246.1661287307696; Tue, 23 Aug 2022 13:41:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661287307; cv=none; d=google.com; s=arc-20160816; b=BWACNw1Sdfrno7ugkP5MnklGmLNWa8VGsPSC38tB3tks/n3FjU8MBBBPpP/yUVx7e4 Iwjj2KBfm5JIiHGWb1FcmEm25FQfZzR62uwekfHSnW+dp7oYxfNivPUqYm291w8yDzgY 7+aUz/g8uJhjxr2wfw9NdH5EpejgqzNRM97plqAx1x1H4RwetC0s4j1CLuKFVIRLCnAh HHMLbOzjzI2XE+rZKeJEIOWtgI5ynCIO6QCKKPnbMWfv/JpE1KqxOQo/a1C3WNungr3m 0mCvEeQGL9WoP9vKxii0vIuy7H6w0h+NLfAHX2AVEYAkRexd9nFSVWQH+CHklNDV8c5q VS/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uN2VYkdfSwi3E9l7InkWZIaCiw/bp4EoACMi+laaycs=; b=oYrY5m4Luwv6+W0EYF4YECYRzWxyYsZ6/rsLrNjifmLk2jEEYKJI5EgT2C+TU29v4j 2/abxzrpImosUIN15nEGtKGHNmlqRr9H7thPdvh0IFoUUBGinbFxoqVo/5xyf91pGng9 VEyz3Aq6TtARkcX4FfheZn35AZi19aZwZwI1BMo5Yr2hOMgCfUaTbEYRiCO3nNIfY2fl xmpRiJcHWBNmXyIXEJ8XkG1kwTngsRA+F8R2SI7mUXrtQygNtt6N9PUHXQ9TG0UcIA/o YOqSMLqIh8ON1EJHvVpaxLLEGDxaeUirk2LnBenR+NK9+BC/Gqv8DRYrEDcso1edQwUb +4jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YZ+IsORw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b4-20020a170902d88400b0016c474690cfsi13685645plz.318.2022.08.23.13.41.36; Tue, 23 Aug 2022 13:41:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YZ+IsORw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233115AbiHWUko (ORCPT + 99 others); Tue, 23 Aug 2022 16:40:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233734AbiHWUkZ (ORCPT ); Tue, 23 Aug 2022 16:40:25 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF822474E0 for ; Tue, 23 Aug 2022 13:29:42 -0700 (PDT) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 72E711BF204; Tue, 23 Aug 2022 20:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1661286578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uN2VYkdfSwi3E9l7InkWZIaCiw/bp4EoACMi+laaycs=; b=YZ+IsORwoTRAl34hGnLYQTSRf/1RDZwiGQqHMHRDqXVO69juM500eQ7TQO8aiDDK0GO2F8 J4V4itVmHUFxEZaGnrwunGUJ4lAKTlYvoEPpeyexTO6BhwSl+rM9D4GYaZMjjl5VHfD2mm /uvfZ0HuDL340MPaF1loWZwr51pjES88lLrlJVSEARgRutJVQWOvpkcUIGrqVUP1JS0PNV Z/l2mqrvzKDQU1A8qjSJFg7+cIPid1PMdoWGizUIzxx7yFIMchw5BkHcx4cRfn7R9/xsBU I+h+NC+YUlIzRsMBs3prwEZsG1ZfqQ+fCz8xUb2frzR8+x6ucC9PJnlgO5jWyA== Date: Tue, 23 Aug 2022 22:29:37 +0200 From: Alexandre Belloni To: a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linkmauve@linkmauve.fr Cc: j.ne@posteo.net, ash@heyquark.com, r.r.qwertyuiop.r.r@gmail.com Subject: Re: [PATCH] rtc: gamecube: Always reset HW_SRNPROT after read Message-ID: <166128648691.2842653.17959514371682917103.b4-ty@bootlin.com> References: <20220823130702.1046-1-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220823130702.1046-1-linkmauve@linkmauve.fr> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Aug 2022 15:07:02 +0200, Emmanuel Gil Peyrot wrote: > This register would fail to be reset if reading the RTC bias failed for > whichever reason. This commit reorganises the code around to > unconditionally write it back to its previous value, unmap it, and > return the result of regmap_read(), which makes it both simpler and more > correct in the error case. > > > [...] Applied, thanks! [1/1] rtc: gamecube: Always reset HW_SRNPROT after read commit: 509451ac03eb3afa4c4a32d4c11b1938f08de8e4 Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com