Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3981270rwa; Tue, 23 Aug 2022 13:51:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR6qxxStqvAJUq0Z9AGEe8qF+f9YGMw6emUNMZtNllkzGqtkA++4Tjn+pIlwstwOkOKkT7p3 X-Received: by 2002:a05:6a00:22c6:b0:52f:4d67:b370 with SMTP id f6-20020a056a0022c600b0052f4d67b370mr27086555pfj.58.1661287896292; Tue, 23 Aug 2022 13:51:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661287896; cv=none; d=google.com; s=arc-20160816; b=BLwOpz28sX0GI5sAcVPzr5pp4roP6t++Yj/sFTySN8GamEOyJ71qAOMEGETCKB6nsa lfCz4S9HeReHM0PZsyxw6M6CzQvBo6h2DCOQ1pVphAy1F33OIXnVlXk3jfa/1EHghutv avGI7zBCb+xEHzlBaecj231pda0gEN2Gl2Gum31SvxUyHCmK8rUol5O6f72FvRILb5Gi KaFdntjYOQhkLjmq8lTapYmjAAtwJjf/yq9ANxNPHD601zrjmVoQAkxruHLCd7kG34UG d48hQ3ZzScpw0BMi7IrLzuZT1JS4NRAGj4ix1xJGhujzMvqJqfiGJEUgzLj2E8mJhmAT 6byA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cV2NYGANONs+McSZvth2jIIUoxYHU0k9OlnO5k/fti8=; b=LrgNx6ZVA07hmKb4cpyhDAL4CC7UV2lnXhtJJH7xLq6gpYH7ZrO3jtdWIywFFs6tvD CihWwkL3AfmPAcYY2bUnv1YDkKYfgCcIiIHv0aewJddc6/UwxIZV0ZqDJb8mbyqDIKUp OJIoUTrZi1Vpqd28qnLW1LpGqs1nKFm/l9DFhqboZY25xVS9nTMQY+13Ep/9/ofSJfaT nilIw7VBjUZxHXCwHH/km/6CHtn2Ym+fZf3Dm4XSqfnnAKM/hGbdsEkbp7dDk7t+oy9x 4u9DHWpvq1vNXpfdq/uEZG6YKm9PXnDrDxxSHMGDgqXvBPxS8vz3mmCKl+Fxxyqo2dyK 2UxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=g9GRFiJZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020a6553c3000000b0040da5486b4dsi13961328pgr.489.2022.08.23.13.51.25; Tue, 23 Aug 2022 13:51:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=g9GRFiJZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233897AbiHWUnE (ORCPT + 99 others); Tue, 23 Aug 2022 16:43:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231804AbiHWUms (ORCPT ); Tue, 23 Aug 2022 16:42:48 -0400 X-Greylist: delayed 280 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 23 Aug 2022 13:34:20 PDT Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0998495AE; Tue, 23 Aug 2022 13:34:19 -0700 (PDT) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id E16C71BF208; Tue, 23 Aug 2022 20:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1661286858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cV2NYGANONs+McSZvth2jIIUoxYHU0k9OlnO5k/fti8=; b=g9GRFiJZXQBWjLSL7fa3c+GxOy35rFp7co+wXhz2QxRHKdudxe9b4gGUYUJd1m5DSwBhjI k3JXP7zsNIuosPyqVimmgIlb4HE1dATEZThoRQRpHWVWEw7nSKiBNwEXJWePeOco1v2eS6 77jpYArCbpvNqfhLI8mt9xmj0lFZdNfoKjAV+LcGoH01u+rp70LU5/WTYWzYc4gMS9L/+2 eSam3+3tiBbWaf+A+2RovwLNj4QRemNqiWHItiifJsYWkbzeWIOuAf+T/17JVgi1mLL8C4 OnP17U+Cv+LG1DBiEeBVOKKtt3xHof4uFmTeIaAm2G2dlWenTx2NHs841r0uWA== Date: Tue, 23 Aug 2022 22:34:17 +0200 From: Alexandre Belloni To: a.zummo@towertech.it, christophe.jaillet@wanadoo.fr Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH] rtc: mxc: Use devm_clk_get_enabled() helper Message-ID: <166128682527.2843313.7668943064097862489.b4-ty@bootlin.com> References: <1b5ad1877304b01ddbba73ca615274a52f781aa2.1660582728.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b5ad1877304b01ddbba73ca615274a52f781aa2.1660582728.git.christophe.jaillet@wanadoo.fr> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Aug 2022 18:59:23 +0200, Christophe JAILLET wrote: > The devm_clk_get_enabled() helper: > - calls devm_clk_get() > - calls clk_prepare_enable() and registers what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code, the error handling paths and avoid the need of > a dedicated function used with devm_add_action_or_reset(). > > [...] Applied, thanks! [1/1] rtc: mxc: Use devm_clk_get_enabled() helper commit: 25bcfaad5ec4e82aede4270d4925967f8520d4cf Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com