Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 Aug 2022 11:52:33 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     linux-phy@lists.infradead.org,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>, UNGLinuxDriver@microchip.com,
        Rob Herring <robh+dt@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
        devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v1 1/1] dt-bindings: phy: ocelot-serdes: convert to YAML
Message-ID: <YwUh8a8prTbTrNqD@colin-ia-desktop>
References: <20220823060052.3921849-1-colin.foster@in-advantage.com>
 <20220823060052.3921849-2-colin.foster@in-advantage.com>
 <1661280427.824099.3761036.nullmailer@robh.at.kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1661280427.824099.3761036.nullmailer@robh.at.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zQCmM39IgVilr4HQGyDfdjnzlf1k+0+0ZEf7n0NU0Mwse9kztD0qDn/SReSs?=
 =?us-ascii?Q?zBTgjr3PQGMNIlxByIk3ZxM0Pm/DcySB4cgTvO4xNIeXemCC6enXQxJd0aNZ?=
 =?us-ascii?Q?sSkOHj+iy/qdXk1Z064gxPc6Gy3g5PaGRx+x3cisZnb/DFX7bUsP64LugYza?=
 =?us-ascii?Q?mwm/B21hWBb+QhcPjzux3PT/Jeo+rOFV5cytCE69domkVkHZMBb3uMi8dynT?=
 =?us-ascii?Q?3LpI9PkZKEyK7lTLOPBSXsC0yW7JqMH5jWv8gcgVrzedGnTvFB4apzgEs3/T?=
 =?us-ascii?Q?WiKjkos47Uwx/Xn6iF80LSVNv5Y0LUza1RVpd9FTxoVa6yaMHsGPuJjthJME?=
 =?us-ascii?Q?225bjfLRjmFOnapYKegRsA+P6gi1HunNU/WMmk1Em7Q2IxRMu0CKMX5Nj79z?=
 =?us-ascii?Q?poYF2cbnOirAfAqBhwp1dFbCQh1tGI3ru2pNMFGOCrAYDEjkYmUt4Tkjyej2?=
 =?us-ascii?Q?CuOomL8d19AYewg3Zv/L+6kxBixjxQLNwJ4jrjUJKJ7LJCwCzTOgSBMym4hf?=
 =?us-ascii?Q?ns2URQMyx9Ox58kuDoFWEaO8U6LT98S6ENmjOn5J7fJ0TSIlY0M+rLvD+MDI?=
 =?us-ascii?Q?614OfimH+uu7tQDNBtXnqXPbXMV0YpKEJsgYaMr3czZqSjp8BWVywEYjltta?=
 =?us-ascii?Q?IN1r+aOKMoJEyC0wwVi4GKVfPTgdq1pIIJmczIXpQWUG1ZgwIlCGvRF/J4By?=
 =?us-ascii?Q?ltoODkuV5DYLiSnlWb0tynF24qpgfcVRf5f6w+0C+ryouGnhhutGQm+mRWQA?=
 =?us-ascii?Q?uGRa9ks2WO5HzAkzBaQt+oMvtJGEDn+RV5jCRRL9d22uaH+nvBd4X8VhX5CE?=
 =?us-ascii?Q?7VRP/jgxPFwJT7ubg/j3n10UbUD8JqaOE2MdQI5KYfoWdtkU3iSfgUUbjkwZ?=
 =?us-ascii?Q?Y7dOTmqoRrVJ/i5IsQe+NGDBraDLz1sQbgq2DOziXI/s8vtQFY/h7YIhb0uQ?=
 =?us-ascii?Q?U01/bun/qaA2KXT+tZQfiELnD3ULZfzffQpv+Xt3pYTRxVEe6gt2wDJXcvHH?=
 =?us-ascii?Q?wEQjYKFKIT5OwUa0yoJI/fuV0BCN0HcjWDOS0gJwEBge6M128bAmPu+MF7gx?=
 =?us-ascii?Q?la5BHExuNiGTdB69ubRMY+JfwMsrj9PmhDquRZWOF6JjuL6WxjD+yQ8SJLkH?=
 =?us-ascii?Q?pYDL1sR2RQVrsiEZK2w0sgotwaX76jLBmnwB+Vbck8HL0LBfZUQuc3emBFfI?=
 =?us-ascii?Q?pHWpHSbVUFFVhgeT3N1xHpEDF7bq6IQ2e+mzBcq7tAabs14I/RGXvkBdfnBR?=
 =?us-ascii?Q?OkVMp9X/mlfhD7SkZSjvZnjQoG61FqC2uPEm7pF9ooAQfRBTGQ69Q/4y6Umq?=
 =?us-ascii?Q?bxvwYcS+F2O1lYXtQdpvWaJd/35YyHNNO9zLyADa65Ibr+C5HrW51zIgJ69i?=
 =?us-ascii?Q?eJW66tGFEvQxcpbGV9TOIVn7qVkC5alfM3v/xNpWzamaWJuyum7sK2z5+pns?=
 =?us-ascii?Q?QKG80NLCBSayHWmeOJ+s4/8eYKjOgYG9P88yR3qavo6nVhSSD7dzpChpVcrv?=
 =?us-ascii?Q?b4sQchVF98eSQCdtJz+yYmgkUyZ+/Vx2Co3xm/zvWg0VJHtx23tyqTUmk2lb?=
 =?us-ascii?Q?YbKQ0mhun3PQ+Mv8wV5JqbggcDFITmnOBNytL5PY+7z8zTOjobuvkWPwpkz8?=
 =?us-ascii?Q?+R1OuG8Jg/jWkme/q/DeGDY=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5a0c9a2-eba4-4204-4728-08da8538a562
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 18:52:36.8346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bKW0L3Txw369b/y4YPP69O/5upSxKI11hCwJoSt2F8c8GZG13dA7OXE+78qpQFQXQRlWcuH/UuUlNV2PGMvHTZQ0rf4mOdEdwY3/5JpOOx0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1473
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Rob,

I'll fix this up for v2. I ran sanity checks before submitting, but
apparently not all the correct ones.

On Tue, Aug 23, 2022 at 01:47:07PM -0500, Rob Herring wrote:
> On Mon, 22 Aug 2022 23:00:52 -0700, Colin Foster wrote:
> > Convert the phy-ocelot-serdes device tree binding to the new YAML format.
> > 
> > Additionally, add the file to MAINTAINERS since the original file didn't
> > exist.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> >  .../bindings/phy/phy-ocelot-serdes.txt        | 43 -------------
> >  .../bindings/phy/phy-ocelot-serdes.yaml       | 61 +++++++++++++++++++
> >  MAINTAINERS                                   |  1 +
> >  3 files changed, 62 insertions(+), 43 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/phy/phy-ocelot-serdes.txt
> >  create mode 100644 Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml: 'examlpes' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
> 	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml: 'oneOf' conditional failed, one must be fixed:
> 	'unevaluatedProperties' is a required property
> 	'additionalProperties' is a required property
> 	hint: Either unevaluatedProperties or additionalProperties must be present
> 	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml: ignoring, error in schema: 
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
>