Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759812AbXFMSzb (ORCPT ); Wed, 13 Jun 2007 14:55:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752012AbXFMSzR (ORCPT ); Wed, 13 Jun 2007 14:55:17 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:38460 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753959AbXFMSzP (ORCPT ); Wed, 13 Jun 2007 14:55:15 -0400 Message-ID: <46703D8A.4040403@garzik.org> Date: Wed, 13 Jun 2007 14:55:06 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Sergei Shtylyov CC: albertl@mail.com, Alan Cox , Linux Kernel Mailing List , IDE/ATA development list Subject: Re: libata passthru: support PIO multi commands References: <200706112200.l5BM0qFn005767@hera.kernel.org> <20070611233917.4bd8c6d7@the-village.bc.nu> <466DE438.70108@garzik.org> <20070612111621.10074408@the-village.bc.nu> <466EB937.6050807@garzik.org> <20070612170519.5f427a70@the-village.bc.nu> <466F5D11.7000404@tw.ibm.com> <46703DB1.9010702@ru.mvista.com> In-Reply-To: <46703DB1.9010702@ru.mvista.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 594 Lines: 16 Sergei Shtylyov wrote: > This is generally a bad practice to guess protocol based on opcode. > What if the code will have to handle a vendor unique command (or some > other command not yet known to it but known to issuer)? Agreed -- we simply cannot rely on guessing protocol from opcode, we MUST take the protocol that is specified. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/