Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b0f17259-680c-7bc0-b941-26dc54214b86@molgen.mpg.de>
Date:   Wed, 24 Aug 2022 00:23:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [Intel-wired-lan] [PATCH v1] drivers/net/ethernet: check return
 value of e1e_rphy()
Content-Language: en-US
To:     Li Zhong <floridsleeves@gmail.com>
Cc:     edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        davem@davemloft.net, intel-wired-lan@lists.osuosl.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220823060200.1452663-1-floridsleeves@gmail.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20220823060200.1452663-1-floridsleeves@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Li,


Thank you for your patch.

Am 23.08.22 um 08:02 schrieb lily:
> e1e_rphy() could return error value, which need to be checked.

need*s*

> 
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>

The From header field does not match the Signed-off-by line. Could you 
configure git with your user name?

     $ git config --global user.name "Li Zhong"
     $ git commit --amend --author="Li Zhong <floridsleeves@gmail.com>"

> ---
>   drivers/net/ethernet/intel/e1000e/phy.c | 14 +++++++++++---
>   1 file changed, 11 insertions(+), 3 deletions(-)

[…]


Kind regards,

Paul