Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa6c01b8-455e-4be6-2607-985ddbd3449e@intel.com>
Date:   Tue, 23 Aug 2022 15:47:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.12.0
Subject: Re: [PATCH v3 04/10] x86/resctrl: Detect and configure Slow Memory
 Bandwidth allocation
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <fenghua.yu@intel.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <eranian@google.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <corbet@lwn.net>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <bagasdotme@gmail.com>
References: <166117559756.6695.16047463526634290701.stgit@bmoger-ubuntu>
 <166117578936.6695.16882887771401229703.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <166117578936.6695.16882887771401229703.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXd0YmZjMnpoaTFFMzBQc2dMeDc2TU1STlc2RUNOOUw2ejcvaUp5SEcrcmlQ?=
 =?utf-8?B?MmRoTzNlTm5pV25vUFZiYi8yTjBsMXdtSS90K3N4TDRMbElKU0hHV2JiZnht?=
 =?utf-8?B?TDJ1a0FGdDg4RlhyS0NQMGFMSTA2Mlo1aU15cXorVzhTbnA0WUd3TE1WT2dV?=
 =?utf-8?B?VFpVa2NYaUJocEtFYXhZaDcxMEJQUzN1QlVsSFhXRmJJenR5aGVDbXF3K3cy?=
 =?utf-8?B?MzkzR3RjaFFidzJMV3poUFIxMzdDcjRGUDdSQXFQc3djQU0xVXA3K09jeGhZ?=
 =?utf-8?B?aGlXSkxkN3JxaElwRi9YbXBwOVBpTFR0ZzAxUSs2U2lpRXFoZUVQaVhtTDBr?=
 =?utf-8?B?Vkg3V2NBTGkzOS8wakhHYU1JbTlhRUtXQ0xhK3lSYTdZd3NBRnBXSk5ISDBx?=
 =?utf-8?B?V3RjU1dvSCtnaGIzT05sa0htbzZ4UU9RajBlZ2c3SGR4R3hGamIzZjdOVHJq?=
 =?utf-8?B?cHk4a1lYQTdUNER5SkMybGYrU2Z6eVFzTUY4cE52YTVNTWZ2M2pxS1JNUSti?=
 =?utf-8?B?YVNiUnpBMkpqWStaWWE0NTFpZzBDeWFOZjcvMFFnYjEvVGlNMG9aOG1odkQr?=
 =?utf-8?B?K284NlJzeDdrckdOc0REVXBVVGpXc3NBVnlNNkNQUGVyQXdmYzhpOG1LajJS?=
 =?utf-8?B?d0FBU3ZYVmV2WVFidkNKNGk0QS90ZTl5WUNaVmhPSHdML2E5cjdWaXFHMVdH?=
 =?utf-8?B?elZNeFVOY2h5S3U3MGRtYnRLU1RKZWlxRVBzOEhBOVpOOGJjaUErRW9RUUlt?=
 =?utf-8?B?aHVnSHdJV0ZXNHEzeWwzNTNJSUZvY2tYUUdCZ1o4eGh6ZDVtbEZMSDYyQk1U?=
 =?utf-8?B?a2Z0UXFyYXU0TlNwK2c3R0xLNWhyTVJxOVZMSjJGdWdsbUh4V1NCTFNOS2oz?=
 =?utf-8?B?S1BXL2lMUFRYOHpveHp5OGZNeUo0b1NxOWlOVnljNG5DdDI3d2R5cFhmQ1hY?=
 =?utf-8?B?bFF0N3cxQzZEMm40MjNtLzNnZ3FPTmZsNUNXdVJYWVhUaU8rek9SYzRzc05i?=
 =?utf-8?B?Yjl3S1l6N1o4QzVLYUpNZ050V3F3akpkdDJMRlQxK1p6VUE5T21vQ3NXU0FR?=
 =?utf-8?B?TlZuSHFYeGluZTlzV2oxOS9FaFpyaUJiakNnR1YyRW1kVm8rVllNbldSUDFG?=
 =?utf-8?B?eUJORVJob3dYQTQ4S001SHpWendGMDJkalFUTmJzT3BQaUJOQ0VnL2d2SXQ2?=
 =?utf-8?B?Vi81UFZCQnpJVzdzc3dZNzIzMXJHQytESzJ2NUVPK0JkcXhIbThDa1MyL2p1?=
 =?utf-8?B?OWJDWStrekg1THJueFdoaGVGZEJjQzZuTCtENExzTlpueTFsMDd3dE5MbWFL?=
 =?utf-8?B?QS84cUNFVWVVNzQ2dWhZL2JpbGVIemhlM2JWVDcvR1hvVkZ0OHRCcU1JZFo3?=
 =?utf-8?B?MVNlVDNETW44R1Y2VnBUUEtYRk9DVGRlT1JqWXJGVWpPK3l6YVUzTmwzTWt3?=
 =?utf-8?B?ZkdzUWpYYUkraXJBT2hyRisvTUhhWWE2NC85djdxV2R6RzlCQWcrZ204NENq?=
 =?utf-8?B?OXhvdkprbHdDRVRWR2pWODRuMWtQZEN3WHhtb0FaMFRYSU5ndmZOSFhBd1Bx?=
 =?utf-8?B?WHZhYkRDZGVqeFFPL1VRM1FNQURlczFGQjJIelliQXlpSmtROUU2ZndtN3Qy?=
 =?utf-8?B?alR3OElKb01ZQVNnQ0dMa3g3VGNnVDU3MWtrSitNcWhpT1I0bzNZbVNqRFlV?=
 =?utf-8?B?Zkg4VVgvSFBac2FqWjJacGp5ZGlrTVpLakcyU3VvQmlDdk5rUzhmZEpLR0I3?=
 =?utf-8?B?QmEvbHhBZkNnaGZLdDdobHE0UDFocVkvT2wvYWJLM2tDRGNlMGVlVWVGQWpE?=
 =?utf-8?B?QXA0b0ZEWHppejhHa2RLTE1Ka00zQS8rSC9CL25PYkVRcGtlU1NXQXlJNHZw?=
 =?utf-8?B?SzQzVlNpOGZZTFVyek50aHpVSUdTVUJmR0o5M2d0T0VSWFpZVk1ObDB5ckdK?=
 =?utf-8?B?R2tqWEV2SkM1ZnV3dzIyVERFNnEzU01RQ3RLd0YweXZIVTBOM0JyQy96TGdO?=
 =?utf-8?B?V0RhdTdPVE44WUJUQW9LdWpHZkNoYnNmYWRpeDFOU0s0TDlucUg0UHNXWnAr?=
 =?utf-8?B?b0VDYXhnYlppOE4yTW5yeDVwQXl5ZklGbUVXNUlJWC9sdzJvbnpuR1I2MDJG?=
 =?utf-8?B?YStqZms4M2YxdGlEcHRJWXlaamQzZzYwU09vODVZMUVOVmYzNzdYY3ZJTU4v?=
 =?utf-8?B?c0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5a4979c-592d-4e52-8167-08da855979e2
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 22:47:37.0911
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CzgvT4U0XFM71M4r/gf8OjqiWcn096MF2AknqumqF3HGxOP2HMhBFtRhrT6020vi/2yMltkRD/ynovAntme3nUCt3Rj2Wk5n/OjLMT3BJpk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5414
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 8/22/2022 6:43 AM, Babu Moger wrote:
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 6c38427b71a2..36ad97ab7342 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -253,6 +253,37 @@ static bool __rdt_get_mem_config_amd(struct rdt_resource *r)
>  	return true;
>  }
>  
> +static bool __rdt_get_s_mem_config_amd(struct rdt_resource *r)
> +{
> +	struct rdt_hw_resource *hw_res = resctrl_to_arch_res(r);
> +	union cpuid_0x10_3_eax eax;
> +	union cpuid_0x10_x_edx edx;
> +	u32 ebx, ecx;
> +
> +	cpuid_count(0x80000020, 2, &eax.full, &ebx, &ecx, &edx.full);
> +	hw_res->num_closid = edx.split.cos_max + 1;
> +	r->default_ctrl = MAX_MBA_BW_AMD;
> +
> +	/* AMD does not use delay */
> +	r->membw.delay_linear = false;
> +	r->membw.arch_needs_linear = false;
> +
> +	/*
> +	 * AMD does not use memory delay throttle model to control
> +	 * the allocation like Intel does.
> +	 */
> +	r->membw.throttle_mode = THREAD_THROTTLE_UNDEFINED;
> +	r->membw.min_bw = 0;
> +	r->membw.bw_gran = 1;
> +	/* Max value is 2048, Data width should be 4 in decimal */
> +	r->data_width = 4;
> +
> +	r->alloc_capable = true;
> +	r->alloc_enabled = true;
> +
> +	return true;
> +}
> +


From what I can tell this new function is almost identical to (it differs with
one character from) __rdt_get_mem_config_amd(). Could it be refactored to
avoid such duplication?

Reinette