Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 Aug 2022 23:49:35 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Doug Anderson <dianders@chromium.org>
Cc:     Andrew Halaney <ahalaney@redhat.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH] regulator: core: Require regulator drivers to check
 uV for get_optimum_mode()
Message-ID: <YwVZfyDflFuzFAOX@sirena.org.uk>
References: <20220823131629.RFT.1.I137e6bef4f6d517be7b081be926059321102fd3d@changeid>
 <20220823221429.3bte2tgtyniur4wb@halaneylaptop>
 <CAD=FV=WSSrObW2PthmUL+t=VYJ+mN6Z763pozCQDbOdPtAXyQA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Z9oeYD/PD2GvJnOl"
Content-Disposition: inline
In-Reply-To: <CAD=FV=WSSrObW2PthmUL+t=VYJ+mN6Z763pozCQDbOdPtAXyQA@mail.gmail.com>
Precedence: bulk


--Z9oeYD/PD2GvJnOl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 23, 2022 at 03:32:44PM -0700, Doug Anderson wrote:

> I guess maybe we could add the "initial mode" as an implicitly allowed
> mode? I guess the other option is to implicitly disable
> regulator-allow-set-load if no allowed modes are listed? Both of these

We should do the former, or equivalently just noop out of set_load() via
set_optimium_mode() if no modes are allowed.

> I guess the other option would be to say that if
> "regulator-allow-set-load" is set but not "regulator-allowed-modes"
> then we allow all modes? Somehow that doesn't seem like the "safest"
> option, though.

Yes, I'd prefer to avoid that.

--Z9oeYD/PD2GvJnOl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMFWX4ACgkQJNaLcl1U
h9CAyAf9GZvW4cQEOUBHq5ZBD8v/mD+9/727Aa/swqbmz0jYqHaZqOQudN51YG7y
IufNyq3nprs3arGYNj9M2tct3w3OimCJ6QTDKx8Y67+4wJNyhkbiRwpDNfwOVADH
DBgWzD6/R+yHuywjC9it1N7EijcydfCcdafCTnlLhyS203M8rSsltEeux7vKGBye
J6q19vxroEmUQGxpOqYCrEYikbyffQc0sVSM47wHQDwQuhWe/03aw7k2ybm59s1l
Cys4mWc3I09XBld7IUIA1fa5k/7AuLYneAhcFiKxoJqXoHcaxnJtavYo81HWyL8V
8hP8CK38KoeqJMCZLXxX3NRpt073Uw==
=xirN
-----END PGP SIGNATURE-----

--Z9oeYD/PD2GvJnOl--