Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b7e3511-8e69-2e47-0f11-7f1014b38940@intel.com>
Date:   Tue, 23 Aug 2022 15:47:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.12.0
Subject: Re: [PATCH v3 02/10] x86/cpufeatures: Add Slow Memory Bandwidth
 Allocation feature flag
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <fenghua.yu@intel.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <eranian@google.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <corbet@lwn.net>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <bagasdotme@gmail.com>
References: <166117559756.6695.16047463526634290701.stgit@bmoger-ubuntu>
 <166117577662.6695.15496626554784059239.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <166117577662.6695.15496626554784059239.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amJJL1dlcjdBSnpmTUphMCt4dG1EaUh4K21xWUh5OXZPQUxSU0Z5RFl5NVRP?=
 =?utf-8?B?R0gvUWpjdm1FalNTM2VWNm96YzRxRWNqYXM0dFJqZ0dDMHJqOWV5VW85bHpk?=
 =?utf-8?B?eDBxMm1idUNRMU9tbkx3ZkJyWXhHb2hnd2lQVkxzY1VzalZSZXh1dzNIWERo?=
 =?utf-8?B?OWlJZmF2Umlra2pOTDFxelJ1N3JMWHVBMUVuNnpHR1h6WkJJRmxZejB6Qk1S?=
 =?utf-8?B?cVlmTVB2TSs5djFvSnhlSXVLNnRRNDhwOWpTR21BTXdPTVhnbTE1bThndjJO?=
 =?utf-8?B?czZZWEl5OGxaWmp3bVM0S2Vkd0tUbW9QSm9SYUNXN0ZENHdKNkxQNUNVL1I1?=
 =?utf-8?B?SjZLbU9WQ2hXVnNLN0tYT3U0c3FyTXNSUEJ3NUZSVlgwdllUbGREY2I5V0lx?=
 =?utf-8?B?VmF6OEFsNkE0S0NzVVh2SDVaeVpVR3Y3ZTBaQXBqVFF1NFFkQVRiWUxJREFv?=
 =?utf-8?B?U0tMc3VPZzRYbmtqUVdtT3A3VjY0Y3EvdEdZbnpQUGFYR29jOTZ0dHQ4d2pZ?=
 =?utf-8?B?SG42V3d1MXMvZ2F2czVPdEF2cGRweW9hUjAyU2FqWmR3bG9nbjYwbjk1WmhH?=
 =?utf-8?B?TnhmYmZKOFJPQmYzUmxETklISGl6c0prS0pWNklhVWZTV01hN0llWGdwQnE1?=
 =?utf-8?B?OE1yeHNCVCtpbEpkTldBeHhyUUtQNzBpUGErN3JSNCtvOElybk5pR2JxZnZH?=
 =?utf-8?B?bTB3S2hXYy9lZ3I5V1JjbndxTGVNV3dlaFRHRUxUN0RZUXFwRXdMZ1R5V3lH?=
 =?utf-8?B?SzBiOGt6Ujg4Q25jVnRNUmpkaFhsS2gvUERabjdkV0pVempoR0tJNGpKaVZ4?=
 =?utf-8?B?alZ3REJmRDhEaHlvS0ozTmFtQm94Wm9oSWpxdlR5ZDBYam8yTCtjOTlYL0lE?=
 =?utf-8?B?M0hHQ0R1Wnp6aW91WE5UeWF0Q3JlbHZTemhCc2I1c20wNElaZHZxd25tSGpN?=
 =?utf-8?B?Q2REejhFRGNDVGNEcVl4VGFMNktSUWIwaGxxT0xpa0lGT29INGgrZk5xbURB?=
 =?utf-8?B?amtocHZqUHdEMlZHTWNWQmQ3YW1POEw0S25adG9NUFV5eVBKVjFLM0xXRjF6?=
 =?utf-8?B?M3pwSUZsYTI0NmlCanFjU2tLalBneVlWMVgzUm04Y1pXc1JtSGFYYllTNDVV?=
 =?utf-8?B?YTRmTnpycmdyZEN6cDE3TjQ4U1l5VFVUVWRqWk9FcktwT0R4enRIR0VzdVRB?=
 =?utf-8?B?OGM2ditQR0xPdG5Xd0Q0Q2w3dnlOajNRTHY0OG5yVUhYZ05JM29SWU9rVzUw?=
 =?utf-8?B?M3N0akljU2x4bVVjMXp0b0tDaGtmaW5WK2hlckNaWDVVZHl5VlJFSkR6d1lV?=
 =?utf-8?B?SWRXeWtMZHpRKy90Z0lJVFdMd2o3YVVlTlZZaGZDZm1pSTMzcW4rVnorQUJE?=
 =?utf-8?B?cmNDZW00dkFBejU3QkNpbDVGUEMzZmJZR1JuUElQT0hPeUg4ejJxUFY4dndD?=
 =?utf-8?B?MEc5U2RERDQzaDBFUEJUWEdmSXJpdS9pNHRja3NHTU1YOVV2K0Q4UXNhdDZP?=
 =?utf-8?B?dXgvdUd1c1dVaGJMZ0E3Q1VmYm55NUdwaU01Q3ljZDlXOVJ4akdKWUl4blNK?=
 =?utf-8?B?QWh3WmJiYnRVYmpKYzAzdXBnSFlHSEhBclJNQlNEM3NqcWpNaE5GOTIyN2RQ?=
 =?utf-8?B?Wm1BUTNXc2xFb2tLTXhOWXhBV1VlWml5U3JtNWFML2xpUDZkY05GQ2NqR2hv?=
 =?utf-8?B?VUFkdmQrNDJMY3d0cmFtaUtoRHRRRTVMMXZVVndrbUk1V2RsaHZqd2pkblJM?=
 =?utf-8?B?ZVBwZll1Z1NJbjBUVVgrTDVpVkp5MGlQVkFFbnNwUHNma2VyRHp1QnNaalZX?=
 =?utf-8?B?QlNQS0xpMmk2bjFDQkNKZzJ6THlsdVhZZ3lienBGTWxYQ1RNVTF5Q1pSSm9I?=
 =?utf-8?B?S3F1WWxPYXFsZUpuMytta0JaUkZHWmlCL1V3eTIxcUMxZ2Roa3ZzdElnL3Bw?=
 =?utf-8?B?ZzdFWGx0TW52c1RtMXJIMTcxVTFxUjZtZkRDbzZRMWlWelNOenM3Y3NlbjQy?=
 =?utf-8?B?MTRnYVY5cCtIdEZpa3JENmY5aExMTE9qWlVVNTRhOVVNMmZOMjF5cFQvQlJG?=
 =?utf-8?B?MG5mSGN3TnRvVUM1empxRHhsYklIUHVLUnlqeTc2ZVdJMEF2enhCeUVEVjBv?=
 =?utf-8?B?VWRSY2RIOCtDQnhOR01FSFcvLzk4elFjai8rRlJobEFMUklHRWpkWXRWa0tp?=
 =?utf-8?B?UVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d952b10-3b6d-45c4-7cb9-08da855976c1
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 22:47:31.9040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0WYikChI80JuOvU6W2ELSvTFdL2EiyLkmp1FUder5MQ5oZ5i87WN/QWbMctnTn/touCLfcJJy/9ddHTerd27hmVeRcHu//Bg+blsYhYWU9E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5414
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 8/22/2022 6:42 AM, Babu Moger wrote:
> Adds the new AMD feature X86_FEATURE_SMBA. With this feature, the QOS
> enforcement policies can be applied to external slow memory connected
> to the host. QOS enforcement is accomplished by assigning a Class Of
> Service (COS) to a processor and specifying allocations or limits for
> that COS for each resource to be allocated.
> 
> This feature is identified by the CPUID Function 8000_0020_EBX_x0.
> 
> CPUID Fn8000_0020_EBX_x0 AMD Bandwidth Enforcement Feature Identifiers (ECX=0)
> Bits    Field Name      Description
> 2       L3SBE           L3 external slow memory bandwidth enforcement
> 
> Feature description is available in the specification, "AMD64 Technology Platform Quality
> of Service Extensions, Revision: 1.03 Publication # 56375 Revision: 1.03 Issue Date: February 2022".
> 
> Link: https://www.amd.com/en/support/tech-docs/amd64-technology-platform-quality-service-extensions
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
> ---

resctrl currently supports "memory bandwidth allocation" and this series adds
"slow memory bandwidth allocation". Could you please provide more detail about
what the difference is between "MBA" and "SMBA"? It is clear that the implementation
treats them as different resources, but both resources are associated with L3 cache
domains and (from what I understand) throttling always occurs at the CPU. Can both
types of memory resources thus be seen as downstream from L3 cache? How can
a user know what memory is considered when configuring MBA and what memory is
considered when configuring SMBA? Additionally, I do find the term "slow" to be
vague as a way to distinguish between different memory types. What is the
definition of "slow"? Would all "slow" memory on the system support SMBA?

Reinette