Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bonnie Lo/WYHQ/Wiwynn <Bonnie_Lo@wiwynn.com>
To:     Guenter Roeck <linux@roeck-us.net>,
        Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
CC:     "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "BMC-SW@aspeedtech.com" <BMC-SW@aspeedtech.com>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: RE: [PATCH] watchdog: aspeed_wdt: Reorder output signal register
 configuration
Thread-Topic: [PATCH] watchdog: aspeed_wdt: Reorder output signal register
 configuration
Thread-Index: AQHYs7D0uN4boim1rEaXFKnwiugQQq22GsqAgAcg3zA=
Date:   Wed, 24 Aug 2022 00:40:32 +0000
Message-ID: <HK0PR04MB310516FD4FE71B22690F4224F8739@HK0PR04MB3105.apcprd04.prod.outlook.com>
References: <20220819094905.1962513-1-chin-ting_kuo@aspeedtech.com>
 <20220819114449.GF3106213@roeck-us.net>
In-Reply-To: <20220819114449.GF3106213@roeck-us.net>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Arv4Osxds0YZpYIdgFs4LHckhRheCd7qTSa1L5ws4MDxvpWnhWZy/TkYyj2A?=
 =?us-ascii?Q?e/QGkffT5M4sybINUWBRDgOXjKfAq2kFGvsW91RnVv9TwVvviYbS1jjDbdxn?=
 =?us-ascii?Q?YeKbGnvSitaHsF+tTeMYFsgU1IFB1tHOcOvuvaqiu4xU4LtTydKWonuc+qLK?=
 =?us-ascii?Q?ORmTf4xV4I7fQ4XLnckxTmboXkki4rdL91y/igXttA8XgG0IUJ9agd1wtSp9?=
 =?us-ascii?Q?3LzGK98Ga/yuTMlzdmtoHpYEEdF8SSN0Lzsv4LlMcKHUT69erGb+I7A+arwX?=
 =?us-ascii?Q?arbnspxoH5W8KZgWzMG2UB6kycUeY5Vzq0lzcXhSF+bYusEHTzZIys/rAKNG?=
 =?us-ascii?Q?5waxEn6vgFUKIdnfR9EGjK0S0tKWYfVt09BlIxvOrWVyc/dwjaWS5Txisnqt?=
 =?us-ascii?Q?cI+nzatD168J8mp4JLyRtqaTYi9WW6BPk8m2Jevu3/boTkvOIyijJQn+eKyy?=
 =?us-ascii?Q?Jq3O+MxpGfZzlCBeS722TjJXlMDisbEp17ysKNhIavb5uynUMDABEc/VLwzB?=
 =?us-ascii?Q?C9kcQcrik4Q4l8aJZbqn5t9Sv6bS65vYK5giCkAdq6egfucJatd3gWN5fHrN?=
 =?us-ascii?Q?9IbsiOIXu6kNohj9OXOvoViQTZTHKhh0zWvhhPWibYbcl4o9baPRafh5j4O7?=
 =?us-ascii?Q?zaBAF8z75R1U6erVudonnrKEKl/QSCiK1DTX8AikcN6stJrSXKZJzo38kMDT?=
 =?us-ascii?Q?Hpx+Xd+xA1Fj9+HSle0szU+VPz/InX7mFgEd4G5RS/pS6C+HJ5QgjEjtOcgy?=
 =?us-ascii?Q?WFrst7WdAhOOKAprgPFqZX1+9rd5LYPBJIpBp8CNNVs3vjhkP1xhnoA3ql8j?=
 =?us-ascii?Q?GJFNPrWvVlRdTZVe+1RhAbSSXl4aIj9tVvgM/YhpOoZp5ZdHZ+r3AyNH1zLu?=
 =?us-ascii?Q?21OBtcBiZUMNwzMhapk5nmBu3LrUrxTKGQI97KssQ0ySD+iVmApTIR5xSb93?=
 =?us-ascii?Q?6HtE2EFL1p6xpvgwH7OzGSzPhfz/3dZtvnS+2tUNacAAUPteUYN4zMJ7/9er?=
 =?us-ascii?Q?Vyco+xt8lUo9nfZt6m4GqEqgVxJ7SsXBDkA/3b0DWREXjpAMK2XzNSX52B4b?=
 =?us-ascii?Q?nv7v8gIAgHRZBX/Ubzu+lBpCybE9ZSN1ATH51CjPkxXuVvdXg7o6E/xi2jzB?=
 =?us-ascii?Q?QquM7OOifDeBpY7+AFuVtfYI8+HtoWY7SANvIWV2+jWYM20+ciyYq7nNtSCf?=
 =?us-ascii?Q?0jk7o/8Ls23XSxAB2448cqEKnahN2Lx8IFbcGoh6ms+0O3D19WDssRSQ1OvS?=
 =?us-ascii?Q?m+GSR5E1076lmlTgFvivqYoaN/Wd/AX2avYwPD652KvkAlY+eBicaR4C5qwN?=
 =?us-ascii?Q?/j1fExhO4BgAa+WnFgjPtIAwvdrMzsPSksJyK/pxYc1JNkzcH9V/MdZ/iSlE?=
 =?us-ascii?Q?TIsnCnvmBPHPZmGFIXhLq0QjRBVSn6Tx2xnyPUAR2/70M0qRX3dhfQDd/ys1?=
 =?us-ascii?Q?X2s1Cu4F3b0SoAQXQFzNihxkw0Rtoga/hZ0NSJNsAtUq119owQ3ysItxL4vN?=
 =?us-ascii?Q?Bwz7VN/y4HLN3u11EY6L8RsWtglOxFyzJU+7ZYnHlInOtgD4pv2HlYubR0gS?=
 =?us-ascii?Q?CwneqaezpFJid4zFoO5XvvQvLAN4KKHW0OZSGS6i?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wiwynn.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR04MB3105.apcprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24b995a1-80ea-4460-7ce5-08da85694094
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2022 00:40:32.7723
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: da6e0628-fc83-4caf-9dd2-73061cbab167
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: toiqR3hFecHK0I020c9RC62Y8uee858TGxUTKkX3Wy7gBA7bVp8M8pLUpCSX17PCRXHFBBBHWk12PCId67E7rQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR04MB6464
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Friday, August 19, 2022 7:45 PM
> To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> Cc: wim@linux-watchdog.org; joel@jms.id.au; andrew@aj.id.au;
> BMC-SW@aspeedtech.com; linux-watchdog@vger.kernel.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> openbmc@lists.ozlabs.org; Bonnie Lo/WYHQ/Wiwynn
> <Bonnie_Lo@wiwynn.com>
> Subject: Re: [PATCH] watchdog: aspeed_wdt: Reorder output signal register
> configuration
>
>   Security Reminder: Please be aware that this email was sent by an
> external sender.
>
> On Fri, Aug 19, 2022 at 05:49:05PM +0800, Chin-Ting Kuo wrote:
> > If the output driving type is push-pull mode, the output polarity
> > should be selected in advance. Otherwise, an unexpected value will be
> > output at the moment of changing to push-pull mode.
> > Thus, output polarity, WDT18[31], must be configured before changing
> > driving type, WDT18[30].
> >
> > Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>

Tested-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>

> > ---
> >  drivers/watchdog/aspeed_wdt.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/watchdog/aspeed_wdt.c
> > b/drivers/watchdog/aspeed_wdt.c index 436571b6fc79..a03e4ff812a2
> > 100644
> > --- a/drivers/watchdog/aspeed_wdt.c
> > +++ b/drivers/watchdog/aspeed_wdt.c
> > @@ -325,18 +325,18 @@ static int aspeed_wdt_probe(struct
> platform_device *pdev)
> >               u32 reg =3D readl(wdt->base + WDT_RESET_WIDTH);
> >
> >               reg &=3D config->ext_pulse_width_mask;
> > -             if (of_property_read_bool(np, "aspeed,ext-push-pull"))
> > -                     reg |=3D WDT_PUSH_PULL_MAGIC;
> > +             if (of_property_read_bool(np, "aspeed,ext-active-high"))
> > +                     reg |=3D WDT_ACTIVE_HIGH_MAGIC;
> >               else
> > -                     reg |=3D WDT_OPEN_DRAIN_MAGIC;
> > +                     reg |=3D WDT_ACTIVE_LOW_MAGIC;
> >
> >               writel(reg, wdt->base + WDT_RESET_WIDTH);
> >
> >               reg &=3D config->ext_pulse_width_mask;
> > -             if (of_property_read_bool(np, "aspeed,ext-active-high"))
> > -                     reg |=3D WDT_ACTIVE_HIGH_MAGIC;
> > +             if (of_property_read_bool(np, "aspeed,ext-push-pull"))
> > +                     reg |=3D WDT_PUSH_PULL_MAGIC;
> >               else
> > -                     reg |=3D WDT_ACTIVE_LOW_MAGIC;
> > +                     reg |=3D WDT_OPEN_DRAIN_MAGIC;
> >
> >               writel(reg, wdt->base + WDT_RESET_WIDTH);
> >       }
> > --
> > 2.25.1
> >
WIWYNN PROPRIETARY This email (and any attachments) contains proprietary or=
 confidential information and is for the sole use of its intended recipient=
. Any unauthorized review, use, copying or distribution of this email or th=
e content of this email is strictly prohibited. If you are not the intended=
 recipient, please notify the sender and delete this email immediately.