Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0dc95a9a-e801-aa7e-9075-4017a9cbb122@huawei.com>
Date:   Wed, 24 Aug 2022 10:11:41 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH -next] genirq: Change irq_can_set_affinity() return value
 type to bool
To:     <tglx@linutronix.de>, <peterz@infradead.org>,
        <frederic@kernel.org>, <tannerlove@google.com>,
        <edumazet@google.com>, <bigeasy@linutronix.de>,
        <zouyipeng@huawei.com>, <liaochang1@huawei.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20220809124009.543646-1-chris.zjh@huawei.com>
From:   "zhangjianhua (E)" <chris.zjh@huawei.com>
In-Reply-To: <20220809124009.543646-1-chris.zjh@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

kindly ping

在 2022/8/9 20:40, Zhang Jianhua 写道:
> The function irq_can_set_affinity() return from __irq_can_set_affinity()
> directly, whose return value type is bool, so make irq_can_set_affinity()
> return bool too.
>
> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
> ---
>   include/linux/interrupt.h | 2 +-
>   kernel/irq/manage.c       | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index a92bce40b04b..29de49af6dea 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -308,7 +308,7 @@ extern cpumask_var_t irq_default_affinity;
>   extern int irq_set_affinity(unsigned int irq, const struct cpumask *cpumask);
>   extern int irq_force_affinity(unsigned int irq, const struct cpumask *cpumask);
>   
> -extern int irq_can_set_affinity(unsigned int irq);
> +extern bool irq_can_set_affinity(unsigned int irq);
>   extern int irq_select_affinity(unsigned int irq);
>   
>   extern int __irq_apply_affinity_hint(unsigned int irq, const struct cpumask *m,
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 40fe7806cc8c..dd9aeef68834 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -156,7 +156,7 @@ static bool __irq_can_set_affinity(struct irq_desc *desc)
>    *	@irq:		Interrupt to check
>    *
>    */
> -int irq_can_set_affinity(unsigned int irq)
> +bool irq_can_set_affinity(unsigned int irq)
>   {
>   	return __irq_can_set_affinity(irq_to_desc(irq));
>   }