Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759340AbXFMTkA (ORCPT ); Wed, 13 Jun 2007 15:40:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753653AbXFMTju (ORCPT ); Wed, 13 Jun 2007 15:39:50 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:38834 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752401AbXFMTjt (ORCPT ); Wed, 13 Jun 2007 15:39:49 -0400 Message-ID: <46704801.1070107@garzik.org> Date: Wed, 13 Jun 2007 15:39:45 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: bryan.wu@analog.com CC: LKML , netdev@vger.kernel.org, torvalds@linux-foundation.org, Andrew Morton Subject: Re: [PATCH] Blackfin ethernet driver: on chip ethernet MAC controller driver References: <1179912533.10328.26.camel@roc-desktop> In-Reply-To: <1179912533.10328.26.camel@roc-desktop> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 33 Bryan Wu wrote: > From: "Wu, Bryan" > > This patch implements the driver necessary use the Analog Devices > Blackfin processor's on-chip ethernet MAC controller. > > Signed-off-by: Bryan Wu > Cc: Jeff Garzik > Signed-off-by: Andrew Morton > --- > > drivers/net/Kconfig | 44 + > drivers/net/Makefile | 1 > drivers/net/bfin_mac.c | 981 +++++++++++++++++++++++++++++++++++++++ > drivers/net/bfin_mac.h | 147 +++++ > 4 files changed, 1173 insertions(+) Finally got back to this. Please run this patch through scripts/checkpatch.pl (found in latest linux-2.6.git upstream kernel tree), and follow most of the recommendations. Personally I would ignore the lines slightly over 80 columns, but the other warnings look like real issues. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/