Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5688e47a-fc2c-457c-fa78-071733bf06f3@kernel.org>
Date:   Wed, 24 Aug 2022 08:33:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH -next 1/2] rv/monitors: add 'static' qualifier for local
 symbols
Content-Language: en-US
To:     Zeng Heng <zengheng4@huawei.com>, mingo@redhat.com,
        rostedt@goodmis.org
Cc:     linux-kernel@vger.kernel.org
References: <20220824034357.2014202-1-zengheng4@huawei.com>
 <20220824034357.2014202-2-zengheng4@huawei.com>
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <20220824034357.2014202-2-zengheng4@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/24/22 05:43, Zeng Heng wrote:
> The sparse tool complains as follows:
> 
> kernel/trace/rv/monitors/wwnr/wwnr.c:18:19:
> warning: symbol 'rv_wwnr' was not declared. Should it be static?
> 
> The `rv_wwnr` symbol is not dereferenced by other extern files,
> so add static qualifier for it.
> 
> So does wip module.
> 
> Fixes:	ccc319dcb450 ("rv/monitor: Add the wwnr monitor")
> Fixes:	8812d21219b9 ("rv/monitor: Add the wip monitor skeleton created by dot2k")
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>

Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>

Thanks!
-- Daniel