Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20220818125038.2247720-1-sunke32@huawei.com>
References: <20220818125038.2247720-1-sunke32@huawei.com>
To:     Sun Ke <sunke32@huawei.com>
Cc:     dhowells@redhat.com, linux-cachefs@redhat.com,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com
Subject: Re: [PATCH v3] cachefiles: fix error return code in cachefiles_ondemand_copen()
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3700078.1661336363.1@warthog.procyon.org.uk>
Date:   Wed, 24 Aug 2022 11:19:23 +0100
Message-ID: <3700079.1661336363@warthog.procyon.org.uk>
Precedence: bulk

	/* fail OPEN request if copen format is invalid */
	ret = kstrtol(psize, 0, &size);
	if (ret) {
		req->error = ret;
		goto out;
	}

	/* fail OPEN request if daemon reports an error */
	if (size < 0) {
		if (!IS_ERR_VALUE(size))
			ret = size = -EINVAL;
		req->error = size;
		goto out;
	}

Should ret get set to the error in size?

David