Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ca13b742-7bb9-da20-4e50-2d04233aaf93@redhat.com>
Date:   Wed, 24 Aug 2022 13:11:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev
 support
Content-Language: en-US
To:     PaddyKP Yao <ispaddy@gmail.com>, Pavel Machek <pavel@ucw.cz>
Cc:     PaddyKP_Yao@asus.com, andy.shevchenko@gmail.com,
        acpi4asus-user@lists.sourceforge.net, corentin.chary@gmail.com,
        linux-kernel@vger.kernel.org, luke@ljones.dev,
        mgross@linux.intel.com, platform-driver-x86@vger.kernel.org
References: <HK0PR04MB33636680A6DC47211560BB43FA879@HK0PR04MB3363.apcprd04.prod.outlook.com>
 <20220711024718.1700067-1-PaddyKP_Yao@asus.com> <20220824100615.GA1049@bug>
 <20220824110908.GB111@AA2000783-NB2.corpnet.asus>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220824110908.GB111@AA2000783-NB2.corpnet.asus>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/24/22 13:09, PaddyKP Yao wrote:
> Hi Pavel,
> 
> On Wed, Aug 24, 2022 at 12:06:15PM +0200, Pavel Machek wrote:
>>>  drivers/platform/x86/asus-wmi.c            | 25 ++++++++++++++++++++++
>>>  include/linux/platform_data/x86/asus-wmi.h |  1 +
>>>  3 files changed, 28 insertions(+)
>>>
>>> asus->micmute_led.name = "asus::micmute";
>>
>> Please see/modify well-known-leds.txt file. We want this consistent on all devices.
> 
> Thanks for your feedback.
> Do you mean I should use "platform::micmute" instead of "asus::micmute"?

Yes. Since I have already merged your original patch can you please make
this a new patch on top of your original patch ?  In other words just
make this 1 small change in the new patch:

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 2d9d709aa59f..18e584eb9f0f 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -1060,7 +1060,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
 	}
 
 	if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
-		asus->micmute_led.name = "asus::micmute";
+		asus->micmute_led.name = "platform::micmute";
 		asus->micmute_led.max_brightness = 1;
 		asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
 		asus->micmute_led.brightness_set_blocking = micmute_led_set;

Regards,

Hans