Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 Aug 2022 19:17:34 +0800
From:   PaddyKP Yao <ispaddy@gmail.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Pavel Machek <pavel@ucw.cz>, PaddyKP_Yao@asus.com,
        andy.shevchenko@gmail.com, acpi4asus-user@lists.sourceforge.net,
        corentin.chary@gmail.com, linux-kernel@vger.kernel.org,
        luke@ljones.dev, mgross@linux.intel.com,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev
 support
Message-ID: <20220824111734.GA8434@AA2000783-NB2.corpnet.asus>
References: <HK0PR04MB33636680A6DC47211560BB43FA879@HK0PR04MB3363.apcprd04.prod.outlook.com>
 <20220711024718.1700067-1-PaddyKP_Yao@asus.com>
 <20220824100615.GA1049@bug>
 <20220824110908.GB111@AA2000783-NB2.corpnet.asus>
 <ca13b742-7bb9-da20-4e50-2d04233aaf93@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ca13b742-7bb9-da20-4e50-2d04233aaf93@redhat.com>
Precedence: bulk

Hi Hans,

On Wed, Aug 24, 2022 at 01:11:32PM +0200, Hans de Goede wrote:
> Yes. Since I have already merged your original patch can you please make
> this a new patch on top of your original patch ?  In other words just
> make this 1 small change in the new patch:
> 
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 2d9d709aa59f..18e584eb9f0f 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1060,7 +1060,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
>  	}
>  
>  	if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
> -		asus->micmute_led.name = "asus::micmute";
> +		asus->micmute_led.name = "platform::micmute";
>  		asus->micmute_led.max_brightness = 1;
>  		asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
>  		asus->micmute_led.brightness_set_blocking = micmute_led_set;
> 
> Regards,
> 
> Hans
> 

Thanks for your advice.
No problem, I will fix it soon.

Best Regards, Paddy