Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp529606rwe; Wed, 24 Aug 2022 05:16:43 -0700 (PDT) X-Google-Smtp-Source: AA6agR59vYiJBvQkRT4f3POzpiwEr6gLE9fLpToFza/cElVxYa9m+I6gRoUP8GbCx0KsjIZzp2k4 X-Received: by 2002:a17:907:7d86:b0:730:cd48:e2bc with SMTP id oz6-20020a1709077d8600b00730cd48e2bcmr2778711ejc.167.1661343403115; Wed, 24 Aug 2022 05:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661343403; cv=none; d=google.com; s=arc-20160816; b=k5H+P+1Xv+rOvA+qiMv7b5xMHjSbr8jG667qNlV6dHX+l6vknr7ldIeG/nrDGYs2NM ucvyo3IYezd5UogGfnwH8nCSt5QJ78mmvSkPzXLHHMY6uw80xwm6nAl5ilWiTaV09M1W +014oL+t5cVOhT+TQSSF2mulhoYlWNU3fzfAW/ZguQnT06IxGOeNUZUjqh8Y5y25nb5L aCajMf1vlEd1ngfijnquI5uO5V29BJCRk9PqHrN+xJiJ0IInlFosIWnDLafgjvWIiOmu qZqPgV8/Eokw8XHz2YWLL48W6VcGA7HXxouV2oOv3iR7wPOhOsl6b78f5+MHcZPXCSyf 3iDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=tiA+kXcRDLYjMpsQ82gj//QO32sha7CTPOzDIGUNCR8=; b=MEBsNwdG1flIIRN6Xp5SJTW5OxKRPVNg5I7xX6DPar/eppj6TmeBPZMck4FifLFXPg G5ZMfOsAncevEpcQuV+C0H2oCL4NRks7dT9Nel7lZ0FxvZujwf6JYuiY/+4RKcjUL8ql 21FEzy8CUIM2/0DXEr/9oAs0O6pBTtusvTxIHigA7mgH90rFrdwuIc6ZJ3s6Ory6n9/0 3NN+z4JMnTsMVhFA+Cnf5dikwGHCIL39p73ZHp0XiCdS/CwBQ3rI5iBlUwPRt2nkp80w XB7cTE3YM9BgtwbNAwQaq+P1mWWxbADEzYPO4a9WpNl88/wsIKSJPhu5W+NrAAP6NB8Q 3LOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v4-20020a1709061dc400b0072aeac5f74bsi1581396ejh.119.2022.08.24.05.16.16; Wed, 24 Aug 2022 05:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235369AbiHXLpO (ORCPT + 99 others); Wed, 24 Aug 2022 07:45:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233776AbiHXLpG (ORCPT ); Wed, 24 Aug 2022 07:45:06 -0400 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 102A867448; Wed, 24 Aug 2022 04:45:03 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R531e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VN7Mkhl_1661341497; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VN7Mkhl_1661341497) by smtp.aliyun-inc.com; Wed, 24 Aug 2022 19:45:01 +0800 From: Jiapeng Chong To: deller@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err() Date: Wed, 24 Aug 2022 19:44:55 +0800 Message-Id: <20220824114455.5167-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. ./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundant because platform_get_irq() already prints an error. ./drivers/video/fbdev/omap/omapfb_main.c:1646:2-9: line 1646 is redundant because platform_get_irq() already prints an error. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1957 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/video/fbdev/omap/omapfb_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index fbb3af883d4d..17cda5765683 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -1643,14 +1643,12 @@ static int omapfb_do_probe(struct platform_device *pdev, } fbdev->int_irq = platform_get_irq(pdev, 0); if (fbdev->int_irq < 0) { - dev_err(&pdev->dev, "unable to get irq\n"); r = ENXIO; goto cleanup; } fbdev->ext_irq = platform_get_irq(pdev, 1); if (fbdev->ext_irq < 0) { - dev_err(&pdev->dev, "unable to get irq\n"); r = ENXIO; goto cleanup; } -- 2.20.1.7.g153144c