Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c8450362-ab4b-c45f-17c8-2bd88a61770f@suse.com>
Date:   Wed, 24 Aug 2022 14:13:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH 3/5] dt-bindings: mfd: sensehat: Add Raspberry Pi Sense
 HAT schema
Content-Language: en-US
To:     Charles Mirabile <cmirabil@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     Peter Robinson <pbrobinson@gmail.com>,
        Serge Schneider <serge@raspberrypi.org>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Nicolas Saenz Julienne <nicolassaenzj@gmail.com>,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, rh-kdlp@googlegroups.com,
        Miguel Ojeda <ojeda@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Lee Jones <lee.jones@linaro.org>, devicetree@vger.kernel.org,
        linux-input@vger.kernel.org, Joel Savitz <jsavitz@redhat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
References: <20220823174158.45579-1-cmirabil@redhat.com>
 <20220823174158.45579-4-cmirabil@redhat.com>
From:   Matthias Brugger <mbrugger@suse.com>
In-Reply-To: <20220823174158.45579-4-cmirabil@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0MvY0hVZE9FSU5PSGhudTc5YXc1S2c3YU1zcVRONFloK3R4UWJvTXJlVURR?=
 =?utf-8?B?TytuUUtCMzRDdnM2T0Rod25VRVl4Yk9IenFQYy9DL1Q0SWVIYWpQZXpQYnRG?=
 =?utf-8?B?YzBlK3Bkb0NuUGxrYTBkSlQ5OWMxY1kreHZKUzNYZnFKelk0UmptRkxUZ3dM?=
 =?utf-8?B?QzkwU0d5QjdHNk41OFFFMS9jakNGdGptZWZ2dWtFa0U1UGNkaGkxVWFqQjFT?=
 =?utf-8?B?QWkyQkRkNlhLcFdMaEFMZ0hEdjNFWElHWW1hbFVLV2ZCY3NjSXFJUlJLVTh2?=
 =?utf-8?B?RHpTU2NuT3cyWE9qMlU4WmZaSnd3TXN1T0ZtQnRieDdjTDJ3RzV1eDhiaEEv?=
 =?utf-8?B?WFo2OG1jeVg2bUJ2S2wrM3VTVjc2WHRZOFBHNTR1c2FPNnJROURoMmtnWkxp?=
 =?utf-8?B?OGx3K2FhdXdnTU5mZi85M2RhRG1JUS9MbUdwRyt0bHJBRVJXNXVrSGtqVVpF?=
 =?utf-8?B?aXpNME9Qb2I2SUpUUXI2TlQvQkM4elMwcVVCckxnZHZsejhVYVpjc2dQelpK?=
 =?utf-8?B?WHRDaklOam1USzhTaTFVRjlmQ1dMWFlNeUlORitHZDMxVm1DRXJEYmR5TGgx?=
 =?utf-8?B?cHZoSDBIc0lTRUZLa095TmNQZDhLaFFielVaMWI5cHd4c1JPT3AySEZ2Q21m?=
 =?utf-8?B?MEorek9ybmlsa3FjU0J5WnNaWDRXS0Ezc21EOVFPMnVnUDlvUFUwUVNadmdM?=
 =?utf-8?B?UDhySDhOS21SSFUwYk9VZjZ4MzRoaUxWdDk5Y2tlU0RPRWFNai80Y3diVndU?=
 =?utf-8?B?Q2pTNVdjMzNOVG5LNTVCMWNyVG5HSTA4QVJPMVhkNlYxblRCSEhFa01WTXkr?=
 =?utf-8?B?SmpPTzFpOWsrSStqZGhTSHlMdW5XNUFZUzJjdEEvMlI0QlVDaFBiM1hWL2xN?=
 =?utf-8?B?bldBUTluK3lKUHVidzhiMmRWeFRFdmc2aFZMdnI5MmRxYWRqdnlwVnQvNzA3?=
 =?utf-8?B?MFllQldXTy9idG1NaWZsNVV1TldoRUJ2R2pSOXY4Y29UbnFnUmx1NmRBclo4?=
 =?utf-8?B?bmt1bWNYcEZBZW1KeVVLc3dFVDdoVXN6SnlISWFjNWh5dFpObWNvdmJLVWNx?=
 =?utf-8?B?VUF0Qi9yUldYaGw5aHJlcDJxL1dBcCtYM295c25lSUtCajMzekRhUEZTVm5D?=
 =?utf-8?B?UFZpMjlXTHR2cU15bEg0QmRkL2lBQTA2MnJCS2ZWN28rSkZ2Mm5BTGd4Kzhv?=
 =?utf-8?B?QVMzMkhIUy9BSUZBSk9BSC9mOERQL2ExdVM1OE5oMVdLOWd4VGhZYTFHSm5m?=
 =?utf-8?B?WG9MQUZhQ3gydzdxSXJFcW9aSjFsYkZSWFlDRERwZUJHVXZwT0pyT1ZzTnV1?=
 =?utf-8?B?YUU4b2ZUVjV1M0VRMWxGTlJ6VlhNeTJrcnlndElCRklBSER6eTFqWjVYcTBG?=
 =?utf-8?B?cW9RaHJRSS9YMWhEejlBaWtNQ01EbGFMdWRHQWpwNkJRQ1dNWWoxWXI0S05r?=
 =?utf-8?B?MlpUWlh0V3MveWc5aVh5RTQxaDZLeTZBczFoNktoWnVzckhpL0xKaURGOXR1?=
 =?utf-8?B?TS9EdzRHdUdtTUZGMFN3L1MraUl4bGVLczZISENtaEh2SGVZWEVEREtySmJp?=
 =?utf-8?B?L1lxVEFqbElGSkpsRWVtN2FkM3VidlVUdVNSa2xRNldNZ29mbTFvWklzRHI4?=
 =?utf-8?B?dS9nRFVmSXNEcS9zc1ZPQnlRZ2hBNXprNjdOQ09wcVZZOVVqY1BIa3ZDamRN?=
 =?utf-8?B?azhZYUxQclVnL042cUVKSjJvWXFPZ080REtrRS9ESFJOOXZOVjhZUGZhMis4?=
 =?utf-8?B?cVczbUx6M3FwdE1Hdm5pZ1RxNnFjRW80amZ1WVYzZWFWSFZjL2wrUmFUMHQw?=
 =?utf-8?B?ZXprYlVqSGZnOEZ5N21TbWg4QW1oOGtsbVN2c0FaNzk3RTJiaWVTRlFmQThZ?=
 =?utf-8?B?V2wvTzlSV0tCMHBncDZEQyt0YmthckhjR00vNnlrNitIVklOSGM4VmUvbXNq?=
 =?utf-8?B?ZmZGemVveWVvZkVPaVFySlpJa3JjeDdLcDhPTStYU3BvRTgvZlZodG5URE9k?=
 =?utf-8?B?eUVLWG9mMTF5bmhvVVNoczhIK2R3bG92K2ZJRnhndjR4ZENNMHFvSFZZTm0v?=
 =?utf-8?B?Wk1pSW1iV3RrOGFDbTN6REtVODR2S25TQW44N0ZTZGxiWTdwaW85SlVlUmRM?=
 =?utf-8?Q?hbu3DRiGAkyJPwnf0YY/1NPyX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af00fa85-9396-4cd4-a86d-08da85ca1d45
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 12:13:55.0463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /zEyc9Qzyl3zNMFa+wx20/O0ggAIt6FzTPm49/yg/DUu5Qr1bL7bTelr00x7rrMNXbCyPy8VuFmUhfUFr37phA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7472
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 23/08/2022 19:41, Charles Mirabile wrote:
> This patch adds the device tree bindings for the Sense HAT
> and each of its children devices in yaml form.
> 
> Co-developed-by: Joel Savitz <jsavitz@redhat.com>
> Signed-off-by: Joel Savitz <jsavitz@redhat.com>
> Signed-off-by: Charles Mirabile <cmirabil@redhat.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

When doing a v11, maybe decide if you want to split this patch up. This way 
every maintainer (MFD, auxdisplay, input) can take his part of the binding 
description through his tree. Otherwise you will need Acked-by tags from them 
and one maintainer to volunteer, maybe provide a stable tag... Having it split 
up seems easier to me.

Regards,
Matthias

> ---
>   .../raspberrypi,sensehat-display.yaml         | 26 +++++++++
>   .../input/raspberrypi,sensehat-joystick.yaml  | 31 ++++++++++
>   .../bindings/mfd/raspberrypi,sensehat.yaml    | 57 +++++++++++++++++++
>   3 files changed, 114 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
>   create mode 100644 Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
>   create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
> 
> diff --git a/Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml b/Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
> new file mode 100644
> index 000000000000..0cf59b0a519c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/auxdisplay/raspberrypi,sensehat-display.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Raspberry Pi Sensehat Display
> +
> +maintainers:
> +  - Charles Mirabile <cmirabil@redhat.com>
> +  - Joel Savitz <jsavitz@redhat.com>
> +
> +description:
> +  This device is part of the sensehat multi function device.
> +  For more information see ../mfd/raspberrypi,sensehat.yaml.
> +
> +  This device features a programmable 8x8 RGB LED matrix.
> +
> +properties:
> +  compatible:
> +    const: raspberrypi,sensehat-display
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> diff --git a/Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml b/Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
> new file mode 100644
> index 000000000000..98b03878a570
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
> @@ -0,0 +1,31 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/raspberrypi,sensehat-joystick.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Raspberry Pi Sensehat Joystick
> +
> +maintainers:
> +  - Charles Mirabile <cmirabil@redhat.com>
> +  - Joel Savitz <jsavitz@redhat.com>
> +
> +description:
> +  This device is part of the sensehat multi function device.
> +  For more information see ../mfd/raspberrypi,sensehat.yaml.
> +
> +  This device features a five button joystick (up, down,left,
> +  right, click)
> +
> +properties:
> +  compatible:
> +    const: raspberrypi,sensehat-joystick
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - interrupts
> +
> +additionalProperties: false
> diff --git a/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml b/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
> new file mode 100644
> index 000000000000..bc53834fbaa7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/raspberrypi,sensehat.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Raspberry Pi Sensehat
> +
> +maintainers:
> +  - Charles Mirabile <cmirabil@redhat.com>
> +  - Joel Savitz <jsavitz@redhat.com>
> +
> +description:
> +  The Raspberry Pi Sensehat is an addon board originally developed
> +  for the Raspberry Pi that has a joystick and an 8x8 RGB LED display
> +  as well as several environmental sensors. It connects via i2c and
> +  a gpio for irq.
> +
> +properties:
> +  compatible:
> +    const: raspberrypi,sensehat
> +
> +  reg:
> +    maxItems: 1
> +
> +  joystick:
> +    $ref: /schemas/input/raspberrypi,sensehat-joystick.yaml#
> +
> +  display:
> +    $ref: /schemas/auxdisplay/raspberrypi,sensehat-display.yaml#
> +
> +required:
> +  - compatible
> +  - reg
> +  - joystick
> +  - display
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      hat@46 {
> +        compatible = "raspberrypi,sensehat";
> +        reg = <0x46>;
> +        display {
> +          compatible = "raspberrypi,sensehat-display";
> +        };
> +        joystick {
> +          compatible = "raspberrypi,sensehat-joystick";
> +          interrupts = <23 IRQ_TYPE_EDGE_RISING>;
> +        };
> +      };
> +    };