Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7122b146-46c7-7e58-5b26-4b94d3a8c1d8@xs4all.nl>
Date:   Wed, 24 Aug 2022 14:06:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] media: v4l2-ctrl: Add main 10 still picture profile for
 hevc
Content-Language: en-US
To:     Dikshita Agarwal <quic_dikshita@quicinc.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        ezequiel@collabora.com
Cc:     stanimir.varbanov@linaro.org, linux-arm-msm@vger.kernel.org,
        quic_vgarodia@quicinc.com, quic_majja@quicinc.com,
        quic_jdas@quicinc.com
References: <1661239563-14346-1-git-send-email-quic_dikshita@quicinc.com>
From:   Hans Verkuil <hverkuil-cisco@xs4all.nl>
In-Reply-To: <1661239563-14346-1-git-send-email-quic_dikshita@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Dikshita,

On 23/08/2022 09:26, Dikshita Agarwal wrote:
> Add main 10 still picture profile for HEVC encoder.

Hmm, is this the same as the "Main 4:4:4 Still Picture" profile mentioned here:

https://en.wikipedia.org/wiki/High_Efficiency_Video_Coding#Version_2_profiles

If not, where it is defined? I would also prefer to have this patch merged together
with a driver that uses it.

Regards,

	Hans

> 
> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
> ---
>  Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 2 ++
>  include/uapi/linux/v4l2-controls.h                        | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> index 2a165ae..5b2da84 100644
> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> @@ -2424,6 +2424,8 @@ enum v4l2_mpeg_video_hevc_profile -
>        - Main still picture profile.
>      * - ``V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10``
>        - Main 10 profile.
> +    * - ``V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10_STILL_PICTURE``
> +      - Main 10 still picture profile.
>  
>  .. raw:: latex
>  
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index 5f46bf4..1159337 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -743,6 +743,7 @@ enum v4l2_mpeg_video_hevc_profile {
>  	V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN = 0,
>  	V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE = 1,
>  	V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10 = 2,
> +	V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10_STILL_PICTURE = 3,
>  };
>  #define V4L2_CID_MPEG_VIDEO_HEVC_LEVEL		(V4L2_CID_CODEC_BASE + 616)
>  enum v4l2_mpeg_video_hevc_level {