Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp609780rwe; Wed, 24 Aug 2022 06:28:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR7K2oxJb0tOBrKk+qeO5PQ3O2akRWeSOQWQRiwQhU/QlMSEirz7iKmLqFTo9oq7fgx2ZSOM X-Received: by 2002:a17:902:b94b:b0:170:c9d6:a06d with SMTP id h11-20020a170902b94b00b00170c9d6a06dmr29157590pls.105.1661347703009; Wed, 24 Aug 2022 06:28:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661347702; cv=none; d=google.com; s=arc-20160816; b=oNanxGjxAc4675gpF64twBkcV1ExOu99SjGAI95MZBBFNCP555kRcvyfUz0TOVjGPD XVaP5FHpaThu4DPKoIH1u2YcF4nqpJshTFraXr2PuwIplzr73tUjS28qYSDue5i9k39t 64Rd2ZjoicL4mhdIN/vCF46ZqiaPa2WRniDM1TO66sa7mOvtJPBZDOmNKdLe0r35BiXC RTL7Z9VEO7iroXK+mUEi0tF2ojJUMVHxpWvxyFLRxZqjWGDzn52bQeabefAy8uoInxaw evnA4MTgbXf5NVHdlchRS0r+Uv9cPUuDZoYweEiSz7EB0CMerX3oGFWKCBiOYiHKFhA2 K2cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2VBvEifQjJ0B2yEyDwr1KfnpR0QVvoOJrb8XD2pI0T4=; b=UKHuzsdoUzlxEGS2PTHIuzw0PE3RwP9mPdUJEWDODkGF369JwWyPyUKVxyTF7oQRn+ 9JosNXt4Spz/h49o3kKmb3D3cQECGX/nKuJ+QPFs4tkUcccBWcUMgjmBzOZfIQitN4O/ fjjbiZ0RlSXw3wF1CMjQXNZx7T8RlAfIZ+2W7jUntCjafbMUFPf3gTB22k6MGBeK1o2E sJ28psbp64UYPRZjS45vdDt9wZIJQIjV7KGI6Mf/RMufzKdvAp/fpWxPVFYEU9lpWHtR T1CDAzUvBvi/Gpmf0mRtciSg6oUu2M7N8Ivs1O58Ce/vR0MLsOjACCrnp1fYEmdrBKUF cVbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="VrXTD/1G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a191-20020a6390c8000000b0042aeddae776si4050455pge.290.2022.08.24.06.28.09; Wed, 24 Aug 2022 06:28:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="VrXTD/1G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237728AbiHXM6L (ORCPT + 99 others); Wed, 24 Aug 2022 08:58:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231596AbiHXM6I (ORCPT ); Wed, 24 Aug 2022 08:58:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E1D979DC; Wed, 24 Aug 2022 05:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2VBvEifQjJ0B2yEyDwr1KfnpR0QVvoOJrb8XD2pI0T4=; b=VrXTD/1Gt1++tPqmEJJZcE06QC HuraL9RvVOD2Gr1Kg5a+FP38JYMFJ66udtbfysdVRDvBbiZwaLYqx54wnhn7/tjtZeu5r3qjKiwmX lSKIvV3wUmyUJBbgsGtuUzGOSf6vTOVLJBF/P2d3w9vEm1BXWeeLFl4dAFYDapASZML5uGKISvD1b TSpRMC9TabM+CWy7pZPhN5/2rhM1sD47YesIFjrDEeBviAPjXMnmoz3Gqf6e5DPiu7bhQ3dMkyjs4 VitTic6le3eAIuY8uB0Rlx40LnH6b5hi+OV3gusBZvIK4odFICYRXJHHFNLBmNkNYySW0Q3z0lfLy w3DaE+9g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQpxM-00GLHL-Qr; Wed, 24 Aug 2022 12:58:04 +0000 Date: Wed, 24 Aug 2022 13:58:04 +0100 From: Matthew Wilcox To: xu xin Cc: akpm@linux-foundation.org, corbet@lwn.net, bagasdotme@gmail.com, adobriyan@gmail.com, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, xu xin , Xiaokai Ran , Yang Yang Subject: Re: [PATCH v4 1/2] ksm: count allocated ksm rmap_items for each process Message-ID: References: <20220824124512.223103-1-xu.xin16@zte.com.cn> <20220824124615.223158-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220824124615.223158-1-xu.xin16@zte.com.cn> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2022 at 12:46:15PM +0000, xu xin wrote: > #ifdef CONFIG_KSM > ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), > + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), You misspelled "rmap" in the file name. > + /* > + * Represent how many pages are checked for ksm merging > + * including merged and not merged. > + */ > + unsigned long ksm_rmp_items; Also here.