Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 Aug 2022 15:50:38 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     simon.guinot@sequanux.org
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Pavel Machek <pavel@ucw.cz>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>, Lee Jones <lee@kernel.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Sheng-Yuan Huang <syhuang3@nuvoton.com>,
        Tasanakorn Phaipool <tasanakorn@gmail.com>
Subject: Re: [PATCH v4 1/5] gpio-f7188x: Add GPIO support for Nuvoton
 NCT6116
Message-ID: <20220824155038.5aa19495@md1za8fc.ad001.siemens.net>
In-Reply-To: <YwYjXzsSHNe+J3aO@76cbfcf04d45>
References: <20220823102344.17624-1-henning.schild@siemens.com>
        <20220823102344.17624-2-henning.schild@siemens.com>
        <YwToilxquEZGqzQD@smile.fi.intel.com>
        <20220823165459.143e1c30@md1za8fc.ad001.siemens.net>
        <YwYjXzsSHNe+J3aO@76cbfcf04d45>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aGTZyZ0DUSD8U2DhSw13GXhhjLY7wpAENlvL5DfhLTckGTGJIYK90g3+OAxk?=
 =?us-ascii?Q?nN+vJSjd0T28wAn6k7zX1QrWxu42vk7Z6kRxG4ydg7vY+IZxJvvM7+6nMpEi?=
 =?us-ascii?Q?+9z3Yz3tt+Bv7K4Gx8FRGN9Ig+8JPv3eT8r+Qw0vuVWGgZHqrgRNKhUBjAtc?=
 =?us-ascii?Q?POWk8fEDTjqkoPksi/Lk1ZTCMBjsMzk7H/gZDedVt2X+V1SVeE4BE/i+tSod?=
 =?us-ascii?Q?6qPDE/uNYdsZI6KtiOr/Wtf8RyOgGK2ATFGZFudfGbr2KDYMy85wdTYETPfp?=
 =?us-ascii?Q?M8eT2ZKo2giBP+zBc9ctbRFVnFHTZlyFYLSha3DWBt1yiWhtCQ+kZhtwavQx?=
 =?us-ascii?Q?frrDgHEwe6Emnz/HAH9t1xVYoQUqk56+V1UPgnThuDGnBrGCh8djcVvULyRS?=
 =?us-ascii?Q?cBTjZBDyOF9R8yJk4BLKZaZLGIAITCcW+CRgju+2saZ/dW0dv15s7qAL7+nu?=
 =?us-ascii?Q?W2KTPmjZA8DWrBKnE4z0y+JPW0sxDmYf6OZSrvowKEc3HqLBCRMBxwiUSBDJ?=
 =?us-ascii?Q?R36vnjbWNVApQU9vN+/ak+kEJl0VPafm9HFQYSurku1a2uTgcpY3DhGMwyk1?=
 =?us-ascii?Q?cT2lH2JruJtZCHPbxfiuy6abzLdoPpkI/vuiZVorGvi69rMrADK/Z0/vdQN7?=
 =?us-ascii?Q?svqymohyMJCZ3QeIDMQGWt9hFXTdUHFcEePj/1GV0HpwRQQkC5WBaoEHeqMm?=
 =?us-ascii?Q?KWgo1DzFQKX1pepO196lBiSdSP4Ai37ZgfeKetXbB8d+tUObJ3XjBXfFFlRa?=
 =?us-ascii?Q?k8jkBnMbjtjnHV5IW0DSkRSfIXtIQLENF4Vx6uSz680ORSXCft3TTKLIdzUV?=
 =?us-ascii?Q?X4JL+2eb3XQisCzLJ2dATax1bPuOCLZFe26Cok4rMYl1y14lDSr5L3KDZwgh?=
 =?us-ascii?Q?KfAuMlEUlXIOCcFKy0BniB7fg7nv8xrTFzrw/merNSkBCagZ1sOHZBdCxhHB?=
 =?us-ascii?Q?72C7IEsnQygLXmqaXUgDEcAdiK/Y3zjBH1kNFmCw85hSO6L6j29JV15o2Zht?=
 =?us-ascii?Q?IWdfU4NY0euXVKZ7SZzfsgPSarG/O4tGGWBbTsBB9x9sIXSIEInl0k0QNjPd?=
 =?us-ascii?Q?6mUdxVOHhUIptlzcmPJXfXqOQEDv+F/ofKz/V9QR3AGiH7h8KLbrdRZlB1ZF?=
 =?us-ascii?Q?eNp7LIXCIu8vTU8qNsaX/l1Mt4sf+sSTAxuRvKx2XeBQ3YKwvArKG4/t/cjy?=
 =?us-ascii?Q?A5QeCuYIBKt8KV4udK+bEQowjBeIwuvfZcwvCiNbxMQ85kppOk5daL9iEgjB?=
 =?us-ascii?Q?EN+4lEjY/MtewFPT8DsilEynOI4OqBb4EbAlfzduqOkBUxQaNyCFmo/X1BWS?=
 =?us-ascii?Q?KAL0bEXwmoyLDwZl48hC7AuzR/DGsAcE1i+1xk9L+uHuw8u/ob4sqwVBH/on?=
 =?us-ascii?Q?2f9w0axu52jYQyeRPG4xw3rWsHw3Ik2d/Yrkkq5iHqwMyKjDdj7I64wGDKaz?=
 =?us-ascii?Q?kzIwSBNqFUdB1UJVZooqa5pm7/NnLqONXLYD8RcHY798rpAR5xQhQxDmVQPz?=
 =?us-ascii?Q?lxVvRAKc6063UeNKfzf3kDDYqK6cBWRZfhwfSbl1HwzaBMN5qGyGcjlotZ8m?=
 =?us-ascii?Q?hkWGtlNMMAeqgZc5h5rYDRrKcq32sMhg1L3ZYWbCfZSMVngvwGXopiOAjboo?=
 =?us-ascii?Q?pQ=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8374d61-c017-46de-45aa-08da85d7a213
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 13:50:41.1074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sCmzx9EKxjnpcGx8qrjY7jsD4Kxx0xJj7qvBtBL9zJygKg212TdqnG/+4r9GIMONBqQMRkEpPTKHwe0SbC5G7bm9lMWcpxY1Xke+srKjPMQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB4700
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 24 Aug 2022 15:10:55 +0200
schrieb simon.guinot@sequanux.org:

> On Tue, Aug 23, 2022 at 04:54:59PM +0200, Henning Schild wrote:
> > Am Tue, 23 Aug 2022 17:47:38 +0300
> > schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:  
> 
> Hi Andy,
> 
> Thanks for this new version. It is looking good to me.
> 
> >   
> > > On Tue, Aug 23, 2022 at 12:23:40PM +0200, Henning Schild wrote:  
> > > > Add GPIO support for Nuvoton NCT6116 chip. Nuvoton SuperIO
> > > > chips are very similar to the ones from Fintek. In other
> > > > subsystems they also share drivers and are called a family of
> > > > drivers.
> > > > 
> > > > For the GPIO subsystem the only difference is that the direction
> > > > bit is reversed and that there is only one data bit per pin. On
> > > > the SuperIO level the logical device is another one.
> > > > 
> > > > On a chip level we do not have a manufacturer ID to check and
> > > > also no revision.    
> > > 
> > > ...
> > >   
> > > > - * GPIO driver for Fintek Super-I/O F71869, F71869A, F71882,
> > > > F71889 and F81866
> > > > + * GPIO driver for Fintek and Nuvoton Super-I/O chips    
> > > 
> > > I'm not sure it's good idea to drop it from here. It means reader
> > > has to get this info in a hard way.
> > > 
> > > ...  
> > 
> > Let us see what others say. I wanted to keep this in line with what
> > Kconfig says and the oneliner in the Kconfig was getting pretty
> > longish. Hence i decided to shorten that. Other drivers also seem to
> > not list all the possible chips in many places, it is all maint
> > effort when a new chips is added and the list is in like 5 places.  
> 
> I agree with you that we can drop this line. It was already incomplete
> and the information is quite readable a few lines below in both the
> define list and the chip enumeration.
> 
> >   
> > > > +#define gpio_dir_invert(type)	((type) == nct6116d)
> > > > +#define gpio_data_single(type)	((type) == nct6116d)    
> > > 
> > > What's prevents us to add a proper prefix to these? I don't like
> > > the idea of them having "gpio" prefix.
> > > 
> > > ...
> > >   
> > > > +		pr_info(DRVNAME ": Unsupported device
> > > > 0x%04x\n", devid);
> > > > +			pr_debug(DRVNAME ": Not a Fintek
> > > > device at 0x%08x\n", addr);
> > > > +	pr_info(DRVNAME ": Found %s at %#x\n",
> > > > +		pr_info(DRVNAME ":   revision %d\n",    
> > > 
> > > Can we, please, utilize pr_fmt()?
> > >   
> > > > +			(int)superio_inb(addr,
> > > > SIO_FINTEK_DEVREV));    
> > > 
> > > Explicit casting in printf() means wrong specifier in 99% of
> > > cases. 
> > 
> > For all the other comments i will wait for a second opinion. I
> > specifically did not change existing code for more than the
> > functional changes needed. And a bit of checkpatch.pl fixing.
> > Beautification could be done on the way but would only cause
> > inconsistency. That driver is what it is, if someone wants to
> > overhaul the style ... that should be another patch. One likely not
> > coming from me.  
> 
> About the int cast, I think you can drop it while you are updating
> this line. It is unneeded.

Ok two voices for doing that one fix along the way. I will send a v5
and hope nobody insists on me fixing the other findings in code i never
wrote.

regards,
Henning

> I have no opinion on the other comments and I am OK with the rest of
> the patch.
> 
> Simon