Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <45dee40a-e1a9-2554-2af8-ea6b9dbbb161@amd.com>
Date:   Wed, 24 Aug 2022 16:01:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 5/9] dma-buf: Move dma_buf_mmap_unlocked() to dynamic
 locking specification
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        David Airlie <airlied@linux.ie>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Daniel Almeida <daniel.almeida@collabora.com>,
        Gert Wollny <gert.wollny@collabora.com>,
        Gustavo Padovan <gustavo.padovan@collabora.com>,
        Daniel Stone <daniel@fooishbar.org>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Rob Clark <robdclark@gmail.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Tomasz Figa <tfiga@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= <thomas_os@shipmail.org>,
        Qiang Yu <yuq825@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
        amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        kernel@collabora.com, virtualization@lists.linux-foundation.org,
        linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        lima@lists.freedesktop.org
References: <20220824102248.91964-1-dmitry.osipenko@collabora.com>
 <20220824102248.91964-6-dmitry.osipenko@collabora.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220824102248.91964-6-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2YxM0JqT2p1azdnZEo5U1JJd0piSGtEYWZBU2NKb3I4TUgxSjgxY292bXpl?=
 =?utf-8?B?MWpBZGFTWlJqZ3BuazUxY2RIc0g0VUQxZlNaQU9VZkNTeFQ0QUkreVBvcWRy?=
 =?utf-8?B?dWhIRFpXN2ppRnhxWFBYQ3d3cDQ4VGxrY1BISXhUN21JWVVTdkxoaXFJSnk1?=
 =?utf-8?B?ZHoxQ2NOMmpJaFh0clZiRHJIQnpmNEorYm5ZcGNmNGhTcEsvZzdRSXRqaHJH?=
 =?utf-8?B?dlZQdGJpUm42dWIyZFA2WTArbTBSQ0pYUEhzeCs5MVdJcVFLYXBNWTN5Vm53?=
 =?utf-8?B?djBBcGQ4RzZ6SkxkQXB1aWZ5OXpaa05QdkN2anFSWXBrQjBrcmdad3ZKN25O?=
 =?utf-8?B?RUpBMWtURHZxdW1oZGhJeGlac2U3My9TZVM4eFFjSWxSUVJlQXZWSzY1R2Mr?=
 =?utf-8?B?RDkvNHcxeWVrUElYWC9mWGhWMU5CejY4dmNBVFJiRHpHemNoQUI3aUtjLzBP?=
 =?utf-8?B?K3RZb1FieUl6dmt4Nnp2RzQxdDUrRlp0Qk9IWENqU1NVa0pYRXVYOWpIVnBC?=
 =?utf-8?B?bEZVeWVqVE1kb3dIcVBCRGtnSWJ4ZUt3R1JnSWJjL09kUWJHQlB0TjA1SVpI?=
 =?utf-8?B?K3VucGJ6QncxK0hVS0FOMEsxeVlSYXBOYnFYSXdzOGVIcUo3MHlKcEpDTlB3?=
 =?utf-8?B?dklLMzk0WjNqV0FZMGxla0g5cUZlb1FveS9oRWU4bk9jd0hoSWEzU1NMT1Jy?=
 =?utf-8?B?TDk4TUJPVVA3TWxKUGV3dHkydzkvbk41a2RHN0NwN0h2RUFSWUxTak9halh5?=
 =?utf-8?B?UTRqdk01bm1TSTNDeXE1enFmK2luS2xob1QySFNaZmRWZDA5NjJwTHUzalRR?=
 =?utf-8?B?NE9udlBDcmFieFIreUhwQ1NkV280WWJFQVVBUkQ0emF5cHlUNVNzNUo2OStI?=
 =?utf-8?B?YmF6K25GYS84aGxLMmhQVFVkRDBBS3lLdjhJc3dmVGc2OGFVdXF3MVczeisw?=
 =?utf-8?B?bzVXaEljSUxTOXF5ZkRvSC9pZnRrTjlsSFZqVEFoWjRKeVBscDJXNUNzWXZk?=
 =?utf-8?B?RzJuSFlKTHhjdy9UUVAwNEx6RzBndXdVa0pLTDEvQlVUTFJzdmUwRGxaelAz?=
 =?utf-8?B?NVpvNS9BOWZIWGNzdWo4RDZRWU1nYkt5Zi9zS3owRHlWcU9VTFk2N3R1R05t?=
 =?utf-8?B?TlVTRitabzYzUDJhTUtiTmpWeTRXUlFvcjg1QUdLenVLMUhsWXBCNXdtWmY1?=
 =?utf-8?B?VHpmOU42dDEyVnA4eG5TRFMrcUdWeTVaaTRZRks0dzlSK0hQeTdtU1kvcG9T?=
 =?utf-8?B?cjBybGdvL3VOZTlnUFF5YUY1NzZaZnZSZ0dSTjFwdDR2T3NvTkVmMXg0amNz?=
 =?utf-8?B?RTJZK3hwaWxNekRhc05OcUQvd1Yzdjg0VXF6blZ2cFdwUDl4dVREVnZBbWNq?=
 =?utf-8?B?MENENG1ISHJPa0hrYlV2SFU4L01KdHhFZDlHYmo2MjBYaVA0TndPOTkzdGx4?=
 =?utf-8?B?bmFDRnhRNU9VbTJXdzJOaTBLSjZJZzBOUjB4TkJKNnpPR2dwTXRrR3JQTm81?=
 =?utf-8?B?ZHR3bnVBb2k3RHdyMTRCckJWVWFacFB4V0VSZkc3UlJjVVZFcG1IdjJZZ3NP?=
 =?utf-8?B?UnlNNU1Rc1ByRXhMQWJMdFMrMHVORlB4eTNKcmRRcmd2VWdyRFNSL09oVzI3?=
 =?utf-8?B?TmsyVllTdlZUb3N0dUlPUkJRMVFaZEJVSUs0RU1MUnJITTh2U0pjc2tERG9n?=
 =?utf-8?B?ck03VXFzMlVFYUdMNHUwTWJJdjZyUVlFTlNjMEMxSjV1S2NraXV0VC8vdnJr?=
 =?utf-8?B?QlVJMHMvN1Z1NHk4MUNXa3NvU2pIMEsvVVdsN0t4bnRnZVk2RSsyM2hzVUZC?=
 =?utf-8?B?dUZrTFJtdWdsTUtqNHRDdk55NEpkaW1OVm5EdFBzSldXWlNiRi9LVWRTSmRw?=
 =?utf-8?B?SGZlM1Q0T2g1N0pWbUFWQkdvV0xIS1BQODYwNVhQbGdWOHdYeFJiVE1MbERD?=
 =?utf-8?B?OHhma3EyaFVPMW1TTnQxenRwMkhpeFBtVis5SWo1a1dKSXFLWHJ5Zk1rOGlV?=
 =?utf-8?B?UlN5VCszOXpCaEFqQWxoRTNrVkd0VE5qbkkxMjJLQStvbXgvd001NTA3dUwx?=
 =?utf-8?B?Y2ZuTXlncVBCdVBUdGJyWVZGZk9RYzFaKzVVaVR1Nmpjb2ZpRVdoSklJak0z?=
 =?utf-8?B?dFRvc3BBV3pEbU91U1NKNytLR1ZjMU9JZEZPRmlvRk53Um5oL2xYRTdUQUl1?=
 =?utf-8?Q?OkHNpLdnTExpDKrMoqdy67Q3ZiZx7uLLUJzCPB6JirLX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18d244fd-891b-4415-1a87-08da85d91c9a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 14:01:16.3261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yIgqr06rV9pGCDGmg1lDmtmR9+TYmrXu7b/z/1OIahmSG9RUbWlHBv8OYypGN5S4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1305
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This should work, but I'm really wondering if this makes a difference 
for somebody.

Anyway the approach is fine with me: Acked-by: Christian König 
<christian.koenig@amd.com>

Regards,
Christian.

Am 24.08.22 um 12:22 schrieb Dmitry Osipenko:
> Move dma_buf_mmap_unlocked() function to the dynamic locking specification
> by taking the reservation lock. Neither of the today's drivers take the
> reservation lock within the mmap() callback, hence it's safe to enforce
> the locking.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>   drivers/dma-buf/dma-buf.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index f358af401360..4556a12bd741 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -1348,6 +1348,8 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_end_cpu_access, DMA_BUF);
>   int dma_buf_mmap_unlocked(struct dma_buf *dmabuf, struct vm_area_struct *vma,
>   			  unsigned long pgoff)
>   {
> +	int ret;
> +
>   	if (WARN_ON(!dmabuf || !vma))
>   		return -EINVAL;
>   
> @@ -1368,7 +1370,11 @@ int dma_buf_mmap_unlocked(struct dma_buf *dmabuf, struct vm_area_struct *vma,
>   	vma_set_file(vma, dmabuf->file);
>   	vma->vm_pgoff = pgoff;
>   
> -	return dmabuf->ops->mmap(dmabuf, vma);
> +	dma_resv_lock(dmabuf->resv, NULL);
> +	ret = dmabuf->ops->mmap(dmabuf, vma);
> +	dma_resv_unlock(dmabuf->resv);
> +
> +	return ret;
>   }
>   EXPORT_SYMBOL_NS_GPL(dma_buf_mmap_unlocked, DMA_BUF);
>