Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 Aug 2022 16:17:57 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     simon.guinot@sequanux.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Pavel Machek <pavel@ucw.cz>, Mark Gross <markgross@kernel.org>,
        Lee Jones <lee@kernel.org>, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        Sheng-Yuan Huang <syhuang3@nuvoton.com>,
        Tasanakorn Phaipool <tasanakorn@gmail.com>
Subject: Re: [PATCH v4 1/5] gpio-f7188x: Add GPIO support for Nuvoton
 NCT6116
Message-ID: <20220824161757.4ca3bb97@md1za8fc.ad001.siemens.net>
In-Reply-To: <a001efb5-95a3-d89d-32bd-557b6f11bb80@redhat.com>
References: <20220823102344.17624-1-henning.schild@siemens.com>
        <20220823102344.17624-2-henning.schild@siemens.com>
        <YwToilxquEZGqzQD@smile.fi.intel.com>
        <20220823165459.143e1c30@md1za8fc.ad001.siemens.net>
        <YwYjXzsSHNe+J3aO@76cbfcf04d45>
        <20220824155038.5aa19495@md1za8fc.ad001.siemens.net>
        <a001efb5-95a3-d89d-32bd-557b6f11bb80@redhat.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r1Lh/a7CdBGY/Ku1JxZY5387pYJ+5Hk2rqqFB+HpPPSds7u+rGxBl+UPclSm?=
 =?us-ascii?Q?f/DSv8l52TC6a2mUIc4eKKckgJnjB9QaId7dTLyQF+83ogk6F5LGPgUIkAVi?=
 =?us-ascii?Q?eFQZBGKIrFQkh+2yXVe0zU2fh2KT7o0xv0b8gAZTkfp7H+lL5OIikBrGZHnA?=
 =?us-ascii?Q?e9K9HqB9LFPaJ8kRL+e/1pdsXQIVDsLrDid1Qy+ttatnJHDHE7FPhjpek6//?=
 =?us-ascii?Q?flBCxZdAFME9MbTzXzAxhaR0cXwTaYUIeeFJYjPehmfc7TZ1LJr0uEjywVAG?=
 =?us-ascii?Q?MispFTnFIO86wBjhQ266p97p8NXZI3UqCafqLtrFIxsR8YgRy/N7w9hgAUxB?=
 =?us-ascii?Q?OB1IKsA/fHAIeb9lUWopDGbvNNKyWC4F4AI07eCQ9c9599rcaZzOGj2+8oWh?=
 =?us-ascii?Q?xXlOsk9kdugvjieF9gp0pOc/ySr79Ds2XLjO0gMci9KGiQKMEPL0g/mvfiRz?=
 =?us-ascii?Q?NUzypYR7aVNrUKF9Yp74m63/q9FAKS+A7hOVmLVBf7MvCyRteuR8fIdtD+gu?=
 =?us-ascii?Q?B0Rlloc1cezPvELMB1r7uFDPtyq1s2Tcwk8e12d6EPsmvDGYFw6N9R93r0PB?=
 =?us-ascii?Q?3GxjAoG309VnUtuWoYipuymK8pESfZyKMdqujSoq1XX6u17ORNEdyH8XG4Y2?=
 =?us-ascii?Q?bC5lD0kno/01UCE20y3ZRA3Oclt6cDuwrrWjspATUIfp/UAWDnGhyl+AUr58?=
 =?us-ascii?Q?9/NnldYoAuS3jCO/kdDzUP6T1Fowt7IJ1VwngjjbiEzlUH3UwTjBA0dic3i2?=
 =?us-ascii?Q?VcHo+9X4Bc4eQgNCa917IObOJqMafiKx10Pu9jyFETZEy7tnqgvN93E+Kvz2?=
 =?us-ascii?Q?IBVOhiVHVoGt/ZBIp2hBbXPuFpLH+hDDepXbpftwqhTXSZ8+IWvavP92+NU3?=
 =?us-ascii?Q?9Ts1F3eXQ89IvsEm6mNRxyRYG6rJ3E9EDYU1WAwXHc7+SqFzWo6ArpmQxaR1?=
 =?us-ascii?Q?ELh+LxZNExEJ0/3S19GGCr8DfCJt1zKPuxdYwaKZIe/4nI4owHftuE75Fd1j?=
 =?us-ascii?Q?l77vZKk4oFWl+rIrRs0ScOkBEzCZxmbNiTwqrp+ZqXJ2FvEDdCZsIMlDyB9f?=
 =?us-ascii?Q?E5wrQVvQL0K9WmeEoNHkiFuvLSJ3Pqy4TzU3Jn0bSZOawo9Dxpf56IBYwNq7?=
 =?us-ascii?Q?s3Xch4VM8LKYHTqdEDx4EXPhsXq5RNrxZRiAkxcCb+jZePyNjr11AJlrRguo?=
 =?us-ascii?Q?NqBhh3Ah3PYRsvO+LbYomoJv/zPLGI1q+EzJIv7yET47yr8iq2rTo2MjqmoR?=
 =?us-ascii?Q?6cP2p7wM/6bfjFI/Nyk/fl0J4ZY+CmnDS1UTxc31YTm83GH8CGUuSLW6G0aL?=
 =?us-ascii?Q?J4Z9+g8kqejEhmeNOiRlDP11FlVD0p7mocG1OqCyi7Brm3JpARMd70xCBIug?=
 =?us-ascii?Q?Xh5Hw6jIryxshvLNsrRjqppUUSmJTLNMit7AKu9NQDZ/BxGydjASdgysDkTQ?=
 =?us-ascii?Q?B4UyheY2KjcreHWrCess8tNXFiVkvJhauP8Mpfsjad5tpfu5ixsGAqg/Np9K?=
 =?us-ascii?Q?60k1hdzp1X1AjAp7tCzfaquwRVmtwc1NLfsgWtEBgZnACZlVoaXaBLxKnnmz?=
 =?us-ascii?Q?It8nZIvCRbjkRau2AYP7RYd6FSbF/LpAsGViYXP7KLkX/DNgT7VMJs1mmsgi?=
 =?us-ascii?Q?4A=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 891837c7-0a86-41c2-7e07-08da85db73b1
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 14:18:01.2485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: swUKA20+pmmaxLA7h1X5oKdTCTn7X9i3LbE9Hmi+0yJV3WAXG7bLTmV17EP4r7nIKZdkrG9YRTniLHd4FyrbmoEsw7MHe2OH9KDvSzsRTPI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB2216
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 24 Aug 2022 15:54:28 +0200
schrieb Hans de Goede <hdegoede@redhat.com>:

> Hi Henning,
> 
> On 8/24/22 15:50, Henning Schild wrote:
> > Am Wed, 24 Aug 2022 15:10:55 +0200
> > schrieb simon.guinot@sequanux.org:
> >   
> >> On Tue, Aug 23, 2022 at 04:54:59PM +0200, Henning Schild wrote:  
> >>> Am Tue, 23 Aug 2022 17:47:38 +0300
> >>> schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:    
> >>
> >> Hi Andy,
> >>
> >> Thanks for this new version. It is looking good to me.
> >>  
> >>>     
> >>>> On Tue, Aug 23, 2022 at 12:23:40PM +0200, Henning Schild wrote:
> >>>>   
> >>>>> Add GPIO support for Nuvoton NCT6116 chip. Nuvoton SuperIO
> >>>>> chips are very similar to the ones from Fintek. In other
> >>>>> subsystems they also share drivers and are called a family of
> >>>>> drivers.
> >>>>>
> >>>>> For the GPIO subsystem the only difference is that the direction
> >>>>> bit is reversed and that there is only one data bit per pin. On
> >>>>> the SuperIO level the logical device is another one.
> >>>>>
> >>>>> On a chip level we do not have a manufacturer ID to check and
> >>>>> also no revision.      
> >>>>
> >>>> ...
> >>>>     
> >>>>> - * GPIO driver for Fintek Super-I/O F71869, F71869A, F71882,
> >>>>> F71889 and F81866
> >>>>> + * GPIO driver for Fintek and Nuvoton Super-I/O chips      
> >>>>
> >>>> I'm not sure it's good idea to drop it from here. It means reader
> >>>> has to get this info in a hard way.
> >>>>
> >>>> ...    
> >>>
> >>> Let us see what others say. I wanted to keep this in line with
> >>> what Kconfig says and the oneliner in the Kconfig was getting
> >>> pretty longish. Hence i decided to shorten that. Other drivers
> >>> also seem to not list all the possible chips in many places, it
> >>> is all maint effort when a new chips is added and the list is in
> >>> like 5 places.    
> >>
> >> I agree with you that we can drop this line. It was already
> >> incomplete and the information is quite readable a few lines below
> >> in both the define list and the chip enumeration.
> >>  
> >>>     
> >>>>> +#define gpio_dir_invert(type)	((type) == nct6116d)
> >>>>> +#define gpio_data_single(type)	((type) == nct6116d)
> >>>>>  
> >>>>
> >>>> What's prevents us to add a proper prefix to these? I don't like
> >>>> the idea of them having "gpio" prefix.
> >>>>
> >>>> ...
> >>>>     
> >>>>> +		pr_info(DRVNAME ": Unsupported device
> >>>>> 0x%04x\n", devid);
> >>>>> +			pr_debug(DRVNAME ": Not a Fintek
> >>>>> device at 0x%08x\n", addr);
> >>>>> +	pr_info(DRVNAME ": Found %s at %#x\n",
> >>>>> +		pr_info(DRVNAME ":   revision %d\n",      
> >>>>
> >>>> Can we, please, utilize pr_fmt()?
> >>>>     
> >>>>> +			(int)superio_inb(addr,
> >>>>> SIO_FINTEK_DEVREV));      
> >>>>
> >>>> Explicit casting in printf() means wrong specifier in 99% of
> >>>> cases.   
> >>>
> >>> For all the other comments i will wait for a second opinion. I
> >>> specifically did not change existing code for more than the
> >>> functional changes needed. And a bit of checkpatch.pl fixing.
> >>> Beautification could be done on the way but would only cause
> >>> inconsistency. That driver is what it is, if someone wants to
> >>> overhaul the style ... that should be another patch. One likely
> >>> not coming from me.    
> >>
> >> About the int cast, I think you can drop it while you are updating
> >> this line. It is unneeded.  
> > 
> > Ok two voices for doing that one fix along the way. I will send a v5
> > and hope nobody insists on me fixing the other findings in code i
> > never wrote.  
> 
> You did not write it, but you are using it to do hw-enablement for
> your company's products. So being asked to also some touch-ups
> left and right while you are at it really is not unexpected IMHO.

Sure thing. Dropping a few characters from a line i touch anyhow is
easy enough. But i.e a refactoring to pr_fmt would feel like asking too
much in my book. That feels like work of the author or maintainer.

In fact i am just doing the homework of what i think should have long
been done by Nuvoton.

I hope that v5 will be acceptable.

Henning 

> Regards,
> 
> Hans
>