Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220824075213.221397-1-ye.xingchen@zte.com.cn>
In-Reply-To: <20220824075213.221397-1-ye.xingchen@zte.com.cn>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Wed, 24 Aug 2022 16:30:36 +0200
Message-ID: <CAMGffEm=Ss1=Qvg_pd3MUT=XsKr+tvKn4bVaLUu4GEpDxHoC_g@mail.gmail.com>
Subject: Re: [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable
To:     cgel.zte@gmail.com
Cc:     axboe@kernel.dk, haris.iqbal@ionos.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Aug 24, 2022 at 9:52 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value from rtrs_clt_rdma_cq_direct() directly instead of
> storing it in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn
Acked-by: Jack Wang <jinpu.wang@ionos.com>
thx!
> ---
>  drivers/block/rnbd/rnbd-clt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
> index 9d01e7ab33e4..78334da74d8b 100644
> --- a/drivers/block/rnbd/rnbd-clt.c
> +++ b/drivers/block/rnbd/rnbd-clt.c
> @@ -1159,10 +1159,8 @@ static int rnbd_rdma_poll(struct blk_mq_hw_ctx *hctx, struct io_comp_batch *iob)
>  {
>         struct rnbd_queue *q = hctx->driver_data;
>         struct rnbd_clt_dev *dev = q->dev;
> -       int cnt;
>
> -       cnt = rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
> -       return cnt;
> +       return rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
>  }
>
>  static void rnbd_rdma_map_queues(struct blk_mq_tag_set *set)
> --
> 2.25.1