Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp761502rwe; Wed, 24 Aug 2022 08:34:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR62ShRCCcADKJdY84wbJ69gTST6NR509HMXIHPTTiVAnI2irtXdQkeURARDG3Wm8oBIfK4f X-Received: by 2002:a17:907:7b8e:b0:73d:7c69:4d67 with SMTP id ne14-20020a1709077b8e00b0073d7c694d67mr3141940ejc.609.1661355274751; Wed, 24 Aug 2022 08:34:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661355274; cv=none; d=google.com; s=arc-20160816; b=eq8AiRbB7KFOb+ncmgblBAflLDcYcCEQmN2I0ttKSywKm7gfDGZvZBEQJck/XRzofr rnr+TrqCUWBuMWlNwYixhakljj5jvoiscpdiGpEZZto4+ZhXEVSV+USp36OG7JLReIGp WbYX6TVLui3HAdh6GEUzWAlE4Q97h5OeJHf2eRpQiENQbjjUwKDGl+Faoi7yEaODwjfB +Pb73nnPkUM7Z5GOuWcaXxYn1Ynyu4I5XAwSSkQLbOPPO7HOEsVgTqTBqJ8okiRYLydz zlcN4NPDJkyHxBgxm/4qeveIkkSI0kUMLeLYu/oFb7IrWwpLWsMOl73sWhHzKj9E1SoD JiYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=yF4Z8Wba5KOhLWJ2hFirrTICWXMXcXiCQAsAVYho6bs=; b=v2puqOifgHgyyisEGKmviZMZ3/5xjWvy2SMTYb6iyXFAY/OzL11lS99C9EGDjs8f6H pJseYWEcBeWtwzz9R5wTTS+tjG7PL5PEnRLS7FvHDfilYAXOvkkzW/NEzSzIBaocF9ww /MS2IjUo4uhu/5Wt27u1hXg7Rj2SxqpL4q4HO+ZSmoGp5vrYLz0Qq05CAnAP1Dl3fDz9 BjXF5reLH6uqc7ZN5jV5R72Kz+q1NK5ICApGPFUJwR2TuWbcf87kXXPTADt2VyC5ZbxV QdXVAuQHtTRbxnHn9IhCHLQV5vPMsxd5yxF4p6z8AkUnqnusJWiBoSQ4+XC4nyXNtoCQ io9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=SDns1Nk4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b10-20020aa7cd0a000000b0043e728bfb58si4051770edw.164.2022.08.24.08.34.06; Wed, 24 Aug 2022 08:34:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=SDns1Nk4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236946AbiHXO6Q (ORCPT + 99 others); Wed, 24 Aug 2022 10:58:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239393AbiHXO6I (ORCPT ); Wed, 24 Aug 2022 10:58:08 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E044090809 for ; Wed, 24 Aug 2022 07:58:00 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id o3so9184668ilf.7 for ; Wed, 24 Aug 2022 07:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=yF4Z8Wba5KOhLWJ2hFirrTICWXMXcXiCQAsAVYho6bs=; b=SDns1Nk4QoTPheeQ1bpwTTyzwsCPkpnhEUdDJ1mLOtNBX5aaBxoN/Pd1JSweF1nXog DJd0OqK+z9SN3tXaoigWDHgRkIkvbEq+bygb3E91A/dOfk49qRSp1wuS3phar/YBrnz8 3SWwE/rsMfEFGfKz5ysQW9BzcVYkjdOGYHTV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=yF4Z8Wba5KOhLWJ2hFirrTICWXMXcXiCQAsAVYho6bs=; b=Rf2Oe92Di9YYOYSzVem68+voVf1DKl3uBHroFpO2zk7TTusSUZ2j2+a/qSnD4pTZ8/ IpyG98reOFSpOmA2TK1+4I0aHKR8rfICqzEh42XTXa5A4AnhWLjwjDgyzJ6vqw9zTpcj kk1ep1eDsw5gY9ydwx8olt3MDif11vXiCzKRQBiML75vIxCTQ5hRxAcfv3dTAKmLhKuZ KnSbdbG3yGsvqSkCQLpexmmu73reA9uYFYje8txOrrZuMgLiiaZHIOiAnBd19YsL3CJf UaCLxbdyiPxylKxg1PmHuiaJIynALqt5F7keVjViKfU1OqQG/lVlB54BmlbTGfiPrWVK Iebw== X-Gm-Message-State: ACgBeo2N26wmkHGvNsn6/bBZpRapzbcfA/TGR3htJKB8VMw5J/W6wsVq ulZl1b9t4yKQqk6wLA2juekjqo+7ZYATTi6+ciI= X-Received: by 2002:a05:6e02:b27:b0:2df:abc0:8a20 with SMTP id e7-20020a056e020b2700b002dfabc08a20mr2363132ilu.291.1661353079919; Wed, 24 Aug 2022 07:57:59 -0700 (PDT) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com. [209.85.166.175]) by smtp.gmail.com with ESMTPSA id g20-20020a02c554000000b00344c3583535sm3913115jaj.94.2022.08.24.07.57.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 07:57:58 -0700 (PDT) Received: by mail-il1-f175.google.com with SMTP id q3so6056722ilc.6 for ; Wed, 24 Aug 2022 07:57:58 -0700 (PDT) X-Received: by 2002:a92:60e:0:b0:2e8:f08b:de04 with SMTP id x14-20020a92060e000000b002e8f08bde04mr2131199ilg.177.1661353077650; Wed, 24 Aug 2022 07:57:57 -0700 (PDT) MIME-Version: 1.0 References: <20220822074139.3810-1-jensenhuang@friendlyarm.com> <23552842.6Emhk5qWAg@diego> In-Reply-To: From: Doug Anderson Date: Wed, 24 Aug 2022 07:57:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on rk3399 To: Jensen Huang Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Rob Herring , Krzysztof Kozlowski , Vinod Koul , Chris Ruehl , Brian Norris , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:ARM/Rockchip SoC..." , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Aug 23, 2022 at 8:11 PM Jensen Huang wrote: > > Hi, > > Sorry for sending an email in HTML format. > > I realized that only some devices may be affected, so I considered > modifying rk3399-nanopi4.dtsi only, > but other boards without external pull-down should still need this patch. I guess the other alternative would be to change how the dt property works. You could say: 1. If `enable-strobe-pulldown` is set then enable the strobe pulldown. 2. If `enable-strobe-pulldown` is not set then don't touch the pin in the kernel. 3. If someone later needs to explicitly disable the strobe pulldown they could add a new property like `disable-strobe-pulldown`. Obviously there are tradeoffs between that and what you've done and I'm happy to let others make the call of which they'd prefer. > BR, > Jensen > > On Tue, Aug 23, 2022 at 10:13 PM Doug Anderson wr= ote: > > > > Hi, > > > > On Tue, Aug 23, 2022 at 4:53 AM Heiko St=C3=BCbner wr= ote: > > > > > > Am Montag, 22. August 2022, 09:41:39 CEST schrieb Jensen Huang: > > > > Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabl= ed > > > > by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode. > > > > > > > > Tested on NanoPC-T4. > > > > > > > > Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line i= n dts") > > > > Signed-off-by: Jensen Huang > > > > > > ok, so this looks like it restores previous functionality. > > > > > > I'm just wondering as the "offending" patch is from 2020, why this > > > only turns up now. Any ideas? > > > > Ah, I see. So before the offending patch we used to just leave the > > pull state at whatever the default was when the kernel was booted. > > After the offending patch we chose a default. > > > > On kevin I see an external pull down on this line. Enabling both the > > internal and external is probably not a huge deal, it'll just affect > > the strength of the pull. > > > > On bob I _think_ the external pull down is also stuffed. > > > > ...so I guess that would explain why it didn't cause a problem for at > > least those two boards? > > > > -Doug