Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Wed, 24 Aug 2022 17:30:51 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Charles Mirabile <cmirabil@redhat.com>
Cc:     Stefan Wahren <stefan.wahren@i2se.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Peter Robinson <pbrobinson@gmail.com>,
        Serge Schneider <serge@raspberrypi.org>,
        Nicolas Saenz Julienne <nicolassaenzj@gmail.com>,
        Mattias Brugger <mbrugger@suse.com>,
        linux-rpi-kernel@lists.infradead.org,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        rh-kdlp@googlegroups.com, Joel Slebodnick <jslebodn@redhat.com>,
        Joel Savitz <jsavitz@redhat.com>,
        Noralf =?utf-8?Q?Tr=C3=B8nnes?= <noralf@tronnes.org>
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
Message-ID: <20220824153051.bx6kfcih76kh3exc@houat>
References: <20220823174158.45579-1-cmirabil@redhat.com>
 <fc54a7a3-c67b-79ab-5e87-d468695e5553@i2se.com>
 <CABe3_aFJ0gkLDFB9k5FEn1SmupbLEKxAn8y=WTt-Rc0xUEK4Dw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qnkn4bktoy4h2gpu"
Content-Disposition: inline
In-Reply-To: <CABe3_aFJ0gkLDFB9k5FEn1SmupbLEKxAn8y=WTt-Rc0xUEK4Dw@mail.gmail.com>
Precedence: bulk


--qnkn4bktoy4h2gpu
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 24, 2022 at 08:06:59AM -0400, Charles Mirabile wrote:
> On Tue, Aug 23, 2022 at 5:30 PM Stefan Wahren <stefan.wahren@i2se.com> wr=
ote:
> > >    drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
> > We don't have an Ack for this display driver. Maybe we should ask Maxime
> > Ripard and Noralf Tr=F8nnes especially Pavel Machek had concerns about =
the
> > right subsystem?
>
> I just looked back at the comments from Pavel on v9. I had meant to
> reply to him, and I actually drafted something but it got lost in the
> shuffle and I never sent it (also my bad).
>
> The driver is an fbdev in the raspberry pi tree, and that is where we
> started when upstreaming, but right from the outset we were told that
> it couldn't be an fbdev since that subsystem is being deprecated
> the replacement is the DRM subsystem

Indeed

> but (as Matthias Brugger suggests) that is probably overkill for an
> 8x8 display. Does that settle the subsystem question?

If you were aiming for an fbdev driver, a KMS driver these days would be
notably simpler.

We've added simpler and simpler devices, such as the SSD1306 recently,
so I can't see anything wrong with using KMS either.

Maxime

--qnkn4bktoy4h2gpu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYwZEKwAKCRDj7w1vZxhR
xeP5AP49OPG5mL6W0tELzpbzif+x+BpthcKKwThVhaPXEL3JcwD+PBhrC2xNONxU
yrmVGBo/7cUtnUmAjR/2f1Ih0jR0Kws=
=QqBo
-----END PGP SIGNATURE-----

--qnkn4bktoy4h2gpu--