Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bd89a246-ee32-7b54-9c9c-7090cc7d51a2@redhat.com>
Date:   Wed, 24 Aug 2022 17:58:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH drm-misc-next v2 2/4] drm/vc4: plane: protect device
 resources after removal
Content-Language: en-US
To:     Maxime Ripard <maxime@cerno.tech>
Cc:     airlied@linux.ie, dri-devel@lists.freedesktop.org,
        tzimmermann@suse.de, linux-kernel@vger.kernel.org
References: <20220819110849.192037-1-dakr@redhat.com>
 <20220819110849.192037-3-dakr@redhat.com>
 <20220824154823.qu3tdwypg5o3ci4z@houat>
From:   Danilo Krummrich <dakr@redhat.com>
Organization: RedHat
In-Reply-To: <20220824154823.qu3tdwypg5o3ci4z@houat>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Maxime,

On 8/24/22 17:48, Maxime Ripard wrote:
>> @@ -1252,12 +1261,17 @@ void vc4_plane_async_set_fb(struct drm_plane *plane, struct drm_framebuffer *fb)
>>   	WARN_ON_ONCE(plane->state->crtc_x < 0 || plane->state->crtc_y < 0);
>>   	addr = bo->dma_addr + fb->offsets[0];
>>   
>> +	if (!drm_dev_enter(plane->dev, &idx))
>> +		return;
>> +
>>   	/* Write the new address into the hardware immediately.  The
>>   	 * scanout will start from this address as soon as the FIFO
>>   	 * needs to refill with pixels.
>>   	 */
>>   	writel(addr, &vc4_state->hw_dlist[vc4_state->ptr0_offset]);
>>   
>> +	drm_dev_exit(idx);
>> +
> 
> You did change the CRTC patch, but the comment to protect the entire
> function also applies to this one.

Yes, I changed this one too, but missed this particular function - gonna 
send a v3.

- Danilo

> 
> Maxime