Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp831249rwe; Wed, 24 Aug 2022 09:36:51 -0700 (PDT) X-Google-Smtp-Source: AA6agR560QZ6e9gRYeRVNcInR3Jd7Prujo8nDRFWxUFwWZwWzweaR954TEb8/AtjAoMy+A79ZdcL X-Received: by 2002:a17:90a:ad45:b0:1fa:f352:4522 with SMTP id w5-20020a17090aad4500b001faf3524522mr9064473pjv.176.1661359011681; Wed, 24 Aug 2022 09:36:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661359011; cv=none; d=google.com; s=arc-20160816; b=h4MNTaxmjiAAYX2QZWmu9jnwttQvsXQBErJofoy/hO8N1uLBK954AZC3m7yBMvo8Qj ZYO+YP/9EjBo9scIISBLCTo3l/tjyQEOD04/jNO9DQN5rwTHH24efcsHVOEiRXMBDOMN 3KAIrGoTcX+jjjOWqFH/Um4ODPmaSPoLvGy5UUNeTUblnb15pJ88RCH940+R8z3oLy1R 1ryZob+xnxQyMY9domhjYIzg/8srevfE6OJKcWUnuDwcaCGtvF8d2DMWxely+bGUqXAC U80ix1FlC/mG5anh7hAtUauB2JAe4bLBCmi6PWoP1pn4fhoddbl+h0GbVLjwGT7m4wQR gUsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kULtSLmXAg2mmU6izdJJrTMPsKQ/4zaIhDQaWWwzK3o=; b=t4A42L3MuXvcJV6VVY5KgL2ehrJu0PYnqQi52PozGaJ9cWVpdJlIKu3ZFIlts67WRy BQJoS8p46VWTj2UP4A1tCDKeQS3zN2zDnbJXdReimHq26UyBqPWC9VMVQb4UIJbFB2bZ x/wicjKjoKVQyZhlWzrWB3HdW4af+oCtifjKI6x/1mxnCFrlbudC3KoYgdwvC9vmggz8 tDY7+7QNxag1gpCf5yL3b+CGadh5JllSwY0AjG1ZYzlOR8dQ62siVVCbiV7CHTb+tsvz DCIwnzHgT9I28FEsqEyyEOOEPDNmAe92vt5o65BJzxdNRSPupbBVtG7HncAEWlwd1O1W OKYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=bSCAwSIR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q12-20020a632a0c000000b0042abd0010fdsi8441335pgq.724.2022.08.24.09.36.39; Wed, 24 Aug 2022 09:36:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=bSCAwSIR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239002AbiHXQQw (ORCPT + 99 others); Wed, 24 Aug 2022 12:16:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237458AbiHXQQu (ORCPT ); Wed, 24 Aug 2022 12:16:50 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9113326F6; Wed, 24 Aug 2022 09:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kULtSLmXAg2mmU6izdJJrTMPsKQ/4zaIhDQaWWwzK3o=; b=bSCAwSIRCDDU3VeFWu5DIbeSkm umiEh7LIyj/bJoGk0OvRlrrD1yOzHRRZNXwUnzIR64kfonK293kfPZ+CcWM4sPAlInpI5qedl2emb UelxpwtyFgSaT7SiTugm6xMJaZwJZmUNspe0SCqQ1UucOhwSm5E79jREOnAEmLynj4+BvaN2ZImLr dPya6YujQolbZs2U0ATbu0flgEWVaxn+OFsRF+0NCrqEmJqkpcuIETKrzycB5+I2/yX71IqpxuBwT 3OVNOvn9JsCi6hpnlnzKPn6ZgEAtbOkHTLaAi9F47SreGec6tI2/28cNkAlqY7MhUgu6+8e4KnLKy KZAsKBTQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQt3V-005mck-5m; Wed, 24 Aug 2022 16:16:37 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 14379980BE2; Wed, 24 Aug 2022 18:16:35 +0200 (CEST) Date: Wed, 24 Aug 2022 18:16:34 +0200 From: Peter Zijlstra To: Borislav Petkov Cc: X86 ML , Michael Matz , linux-toolchains@vger.kernel.org, LKML , Josh Poimboeuf Subject: Re: [PATCH] x86/sev: Mark snp_abort() noreturn Message-ID: References: <20220824152420.20547-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2022 at 05:48:56PM +0200, Borislav Petkov wrote: > On Wed, Aug 24, 2022 at 05:38:26PM +0200, Peter Zijlstra wrote: > > You'll probably also have to add it to the > > objtool/check.c:global_noreturn[] list, for the case where objtool fails > > to recognise it as noreturn. > > How come? > > Doesn't objtool see the attribute? If only there would be a trace of it left in the ELF file...